378032: BooleanAttributeEditor should initialize attribute to false

Change-Id: I29c92306b8055e6d9867f77ef222f1d301020443
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=378032

1 files changed, 12 insertions, 0 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/BooleanAttributeEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/BooleanAttributeEditor.java
index 4e2df2ffc..4b7d0606d 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/BooleanAttributeEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/BooleanAttributeEditor.java
@@ -19,6 +19,7 @@ import org.eclipse.swt.events.SelectionAdapter;
 import org.eclipse.swt.events.SelectionEvent;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
+import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.forms.widgets.FormToolkit;
 
 /**
@@ -56,6 +57,17 @@ public class BooleanAttributeEditor extends AbstractAttributeEditor {
 		button.setToolTipText(getDescription());
 		refresh();
 		setControl(button);
+		if (!getTaskAttribute().hasValue()) {
+			// set initial value to false to match what the editor shows 
+			// use asyncExec to ensure this happens after decorating, otherwise this appears as an incoming change
+			PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
+				public void run() {
+					if (!getTaskAttribute().hasValue()) {
+						getAttributeMapper().setBooleanValue(getTaskAttribute(), false);
+					}
+				}
+			});
+		}
 	}
 
 	@Override