Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam Davis2014-02-12 02:13:06 +0000
committerGerrit Code Review @ Eclipse.org2014-02-18 00:01:36 +0000
commit4174196b0241970994352ba203b437a80783a7f8 (patch)
tree1f54a2a7fbf820402865320a4b5627685b6da288 /org.eclipse.mylyn.tasks.ui
parentf739f4db9c98d1beacff0ab3cd5a70196a7574c2 (diff)
downloadorg.eclipse.mylyn.tasks-4174196b0241970994352ba203b437a80783a7f8.tar.gz
org.eclipse.mylyn.tasks-4174196b0241970994352ba203b437a80783a7f8.tar.xz
org.eclipse.mylyn.tasks-4174196b0241970994352ba203b437a80783a7f8.zip
378032: error icon is clipped
[api] provide editor support for required attributes Change-Id: I5245ff32201eb19dca546f390c67900012554f33 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=378032
Diffstat (limited to 'org.eclipse.mylyn.tasks.ui')
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractTaskEditorAttributeSection.java1
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPeoplePart.java5
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractAttributeEditor.java2
3 files changed, 6 insertions, 2 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractTaskEditorAttributeSection.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractTaskEditorAttributeSection.java
index eb630127e..c75256325 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractTaskEditorAttributeSection.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractTaskEditorAttributeSection.java
@@ -158,6 +158,7 @@ public abstract class AbstractTaskEditorAttributeSection extends AbstractTaskEdi
ColumnSpan columnSpan = (layoutHint != null && layoutHint.columnSpan != null)
? layoutHint.columnSpan
: ColumnSpan.SINGLE;
+ gd.horizontalIndent = 1;// prevent clipping of decorators on Windows
if (rowSpan == RowSpan.SINGLE && columnSpan == ColumnSpan.SINGLE) {
gd.widthHint = COLUMN_WIDTH;
gd.horizontalSpan = 1;
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPeoplePart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPeoplePart.java
index 3c71c0585..495e5be59 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPeoplePart.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorPeoplePart.java
@@ -43,7 +43,10 @@ public class TaskEditorPeoplePart extends AbstractTaskEditorPart {
editor.createControl(composite, toolkit);
getTaskEditorPage().getAttributeEditorToolkit().adapt(editor);
- GridDataFactory gridDataFactory = GridDataFactory.fillDefaults().grab(true, false).align(SWT.FILL, SWT.TOP);
+ GridDataFactory gridDataFactory = GridDataFactory.fillDefaults()
+ .grab(true, false)
+ .align(SWT.FILL, SWT.TOP)
+ .indent(3, 0);// prevent clipping of decorators on Mac
if (editor instanceof MultiSelectionAttributeEditor) {
gridDataFactory.hint(SWT.DEFAULT, 95);
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractAttributeEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractAttributeEditor.java
index 1fa334791..8f7f8fc19 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractAttributeEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractAttributeEditor.java
@@ -276,7 +276,7 @@ public abstract class AbstractAttributeEditor {
*/
protected void decorateRequired() {
if (decoration == null) {
- decoration = new ControlDecoration(getLabelControl(), SWT.TOP | SWT.RIGHT);
+ decoration = new ControlDecoration(getLabelControl(), SWT.BOTTOM | SWT.RIGHT);
decoration.setDescriptionText(Messages.AbstractAttributeEditor_AttributeIsRequired);
decoration.setMarginWidth(0);
Image image = FieldDecorationRegistry.getDefault()

Back to the top