ASSIGNED - bug 349003: [patch] support opening multiple tasks at once

https://bugs.eclipse.org/bugs/show_bug.cgi?id=349003

3 files changed, 22 insertions, 10 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java
index 7d7a34922..81d17e31f 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java
@@ -7,6 +7,8 @@
  *
  * Contributors:
  *     Willian Mitsuda - initial API and implementation
+ *     Abner Ballardo - fixes for bug 349003
+ *     Tasktop Technologies - improvements 
  *******************************************************************************/
 
 package org.eclipse.mylyn.internal.tasks.ui.actions;
@@ -23,6 +25,8 @@ import org.eclipse.ui.actions.ActionDelegate;
 
 /**
  * @author Willian Mitsuda
+ * @author Abner Ballardo
+ * @author Steffen Pingel
  */
 public class OpenTaskAction extends ActionDelegate implements IWorkbenchWindowActionDelegate {
 
@@ -34,7 +38,7 @@ public class OpenTaskAction extends ActionDelegate implements IWorkbenchWindowAc
 
 	@Override
 	public void run(IAction action) {
-		TaskSelectionDialog dlg = new TaskSelectionDialog(window.getShell());
+		TaskSelectionDialog dlg = new TaskSelectionDialog(window.getShell(), true);
 		dlg.setTitle(Messages.OpenTaskAction_Open_Task);
 		dlg.setMessage(Messages.OpenTaskAction_Select_a_task_to_open__);
 		dlg.setShowExtendedOpeningOptions(true);
@@ -43,13 +47,14 @@ public class OpenTaskAction extends ActionDelegate implements IWorkbenchWindowAc
 			return;
 		}
 
-		Object result = dlg.getFirstResult();
-		if (result instanceof ITask) {
-			AbstractTask task = (AbstractTask) result;
-			if (dlg.getOpenInBrowser()) {
-				TasksUiUtil.openWithBrowser(task);
-			} else {
-				TasksUiInternal.refreshAndOpenTaskListElement(task);
+		for (Object result : dlg.getResult()) {
+			if (result instanceof ITask) {
+				AbstractTask task = (AbstractTask) result;
+				if (dlg.getOpenInBrowser()) {
+					TasksUiUtil.openWithBrowser(task);
+				} else {
+					TasksUiInternal.refreshAndOpenTaskListElement(task);
+				}
 			}
 		}
 	}
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java
index a59ace76e..0b7d0cb5f 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java
@@ -429,7 +429,11 @@ public class TaskSelectionDialog extends FilteredItemsSelectionDialog {
 	private final TaskActivationHistory taskActivationHistory;
 
 	public TaskSelectionDialog(Shell parent) {
-		super(parent);
+		this(parent, false);
+	}
+	
+	public TaskSelectionDialog(Shell parent, boolean multi) {
+		super(parent, multi);
 		this.taskActivationHistory = TasksUiPlugin.getTaskActivityManager().getTaskActivationHistory();
 		this.history = new LinkedHashSet<AbstractTask>(taskActivationHistory.getPreviousTasks());
 		this.itemsComparator = new TaskHistoryItemsComparator(new ArrayList<AbstractTask>(history));
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialogWithRandom.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialogWithRandom.java
index 6041ba5de..7e8cafdd5 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialogWithRandom.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialogWithRandom.java
@@ -42,13 +42,16 @@ public class TaskSelectionDialogWithRandom extends TaskSelectionDialog {
 
 	private boolean activateTask = false;
 
+	public TaskSelectionDialogWithRandom(Shell parent, boolean multi) {
+		super(parent, multi);
+	}
+
 	public TaskSelectionDialogWithRandom(Shell parent) {
 		super(parent);
 	}
 
 	@Override
 	protected void createAdditionalButtons(Composite parent) {
-
 		randomTaskButton = createButton(parent, RANDOM_ID, Messages.TaskSelectionDialog_Random_Task, false);
 		randomTaskButton.setToolTipText(Messages.TaskSelectionDialogWithRandom_Feeling_Lazy_Tooltip);
 		randomTaskButton.addSelectionListener(new SelectionListener() {