diff options
| author | spingel | 2008-10-28 00:01:41 +0000 |
|---|---|---|
| committer | spingel | 2008-10-28 00:01:41 +0000 |
| commit | 028db55c1a863b0b8e5f3ad41bac9f8a70cd8313 (patch) | |
| tree | 665745ef463971a43bbc61df56e8a7dac94bbc6b /org.eclipse.mylyn.tasks.ui | |
| parent | a49c3010371474f9d523a82ca7ab1f7b674b69c1 (diff) | |
| download | org.eclipse.mylyn.tasks-028db55c1a863b0b8e5f3ad41bac9f8a70cd8313.tar.gz org.eclipse.mylyn.tasks-028db55c1a863b0b8e5f3ad41bac9f8a70cd8313.tar.xz org.eclipse.mylyn.tasks-028db55c1a863b0b8e5f3ad41bac9f8a70cd8313.zip | |
NEW - bug 252249: AbstractTaskHyperlinkDetector fails with NPE
https://bugs.eclipse.org/bugs/show_bug.cgi?id=252249
Diffstat (limited to 'org.eclipse.mylyn.tasks.ui')
2 files changed, 2 insertions, 1 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractHyperlinkTextPresentationManager.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractHyperlinkTextPresentationManager.java index a3de1ac44..4820603db 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractHyperlinkTextPresentationManager.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/AbstractHyperlinkTextPresentationManager.java @@ -82,7 +82,7 @@ public abstract class AbstractHyperlinkTextPresentationManager { } protected StyleRange[] computeStyleRanges(IRegion extent) { - if (viewer == null || hyperlinkDetectors == null || viewer.getDocument() == null) { + if (viewer == null || hyperlinkDetectors == null || viewer.getDocument() == null || extent == null) { return null; } List<IRegion> regions = getRegions(extent); diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java index 2a466c666..a2f653ea2 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java @@ -587,6 +587,7 @@ public class TasksUiInternal { * @since 3.0 */ public static void closeEditorInActivePage(ITask task, boolean save) { + Assert.isNotNull(task); IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow(); if (window == null) { return; |