NEW - bug 232180: stop unnecessary saves of task list and related information upon startup

https://bugs.eclipse.org/bugs/show_bug.cgi?id=232180

6 files changed, 13 insertions, 13 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TaskJobFactory.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TaskJobFactory.java
index d3cc167b7..5794ef439 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TaskJobFactory.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TaskJobFactory.java
@@ -138,7 +138,7 @@ public class TaskJobFactory implements ITaskJobFactory {
 			}
 
 			@Override
-			public IStatus getError() {
+			public IStatus getErrorStatus() {
 				return error;
 			}
 		};
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttributePart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttributePart.java
index 7776e230d..17e268280 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttributePart.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttributePart.java
@@ -171,10 +171,10 @@ public class TaskEditorAttributePart extends AbstractTaskEditorPart {
 						PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
 							public void run() {
 								getTaskEditorPage().showEditorBusy(false);
-								if (job.getError() != null) {
+								if (job.getErrorStatus() != null) {
 									getTaskEditorPage().getTaskEditor().setStatus(
 											"Updating of repository configuration failed", "Update Failed",
-											job.getError());
+											job.getErrorStatus());
 								} else {
 									getTaskEditorPage().refreshFormContent();
 								}
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java
index 995550bf3..c238c4034 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TasksUiInternal.java
@@ -235,10 +235,10 @@ public class TasksUiInternal {
 				synchronized (taskRepository) {
 					taskRepository.setUpdating(false);
 				}
-				if (job.getError() != null) {
+				if (job.getErrorStatus() != null) {
 					Display display = PlatformUI.getWorkbench().getDisplay();
 					if (!display.isDisposed()) {
-						TasksUiInternal.displayStatus("Configuration Refresh Failed", job.getError());
+						TasksUiInternal.displayStatus("Configuration Refresh Failed", job.getErrorStatus());
 					}
 				}
 			}
@@ -355,9 +355,9 @@ public class TasksUiInternal {
 			job.addJobChangeListener(new JobChangeAdapter() {
 				@Override
 				public void done(IJobChangeEvent event) {
-					if (task.getSynchronizationStatus() != null) {
+					if (task.getErrorStatus() != null) {
 						TasksUiInternal.asyncDisplayStatus("Task Synchronization Failed",
-								task.getSynchronizationStatus());
+								task.getErrorStatus());
 					}
 				}
 			});
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskElementLabelProvider.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskElementLabelProvider.java
index 47c738aff..4ed81aefc 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskElementLabelProvider.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskElementLabelProvider.java
@@ -185,7 +185,7 @@ public class TaskElementLabelProvider extends LabelProvider implements IColorPro
 			} else if (repositoryTask.getSynchronizationState() == SynchronizationState.CONFLICT) {
 				imageDescriptor = CommonImages.OVERLAY_SYNC_CONFLICT;
 			}
-			if (imageDescriptor == null && repositoryTask.getSynchronizationStatus() != null) {
+			if (imageDescriptor == null && repositoryTask.getErrorStatus() != null) {
 				return CommonImages.OVERLAY_SYNC_WARNING;
 			} else if (imageDescriptor != null) {
 				return imageDescriptor;
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java
index cac00f11c..9709500f5 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java
@@ -305,7 +305,7 @@ public class TaskListToolTip extends ToolTip {
 		IStatus status = null;
 		if (element instanceof ITask) {
 			ITask task = (ITask) element;
-			status = task.getSynchronizationStatus();
+			status = task.getErrorStatus();
 		} else if (element instanceof IRepositoryQuery) {
 			RepositoryQuery query = (RepositoryQuery) element;
 			status = query.getSynchronizationStatus();
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/TaskAttachmentWizard.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/TaskAttachmentWizard.java
index 7e58cc1d2..c43888860 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/TaskAttachmentWizard.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/TaskAttachmentWizard.java
@@ -273,8 +273,8 @@ public class TaskAttachmentWizard extends Wizard {
 	}
 
 	private void handleDone(SubmitJob job) {
-		if (job.getError() != null) {
-			TasksUiInternal.displayStatus(getShell(), "Attachment Failed", job.getError());
+		if (job.getErrorStatus() != null) {
+			TasksUiInternal.displayStatus(getShell(), "Attachment Failed", job.getErrorStatus());
 		}
 	}
 
@@ -318,7 +318,7 @@ public class TaskAttachmentWizard extends Wizard {
 			public void done(IJobChangeEvent event) {
 				Display.getDefault().asyncExec(new Runnable() {
 					public void run() {
-						if (job.getError() != null) {
+						if (job.getErrorStatus() != null) {
 							getContainer().getShell().setVisible(true);
 						}
 						handleDone(job);
@@ -339,7 +339,7 @@ public class TaskAttachmentWizard extends Wizard {
 				}
 			});
 			handleDone(job);
-			return job.getError() == null;
+			return job.getErrorStatus() == null;
 		} catch (InvocationTargetException e) {
 			StatusHandler.fail(new Status(IStatus.ERROR, TasksUiPlugin.ID_PLUGIN, "Unexpected error", e));
 			return false;