RESOLVED - bug 194138: cleanup unnecesary casts and null checks

https://bugs.eclipse.org/bugs/show_bug.cgi?id=194138

11 files changed, 22 insertions, 7 deletions

diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.core.prefs
index 4f6160a5e..888de1277 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.core.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.core.prefs
@@ -1,4 +1,4 @@
-#Wed Jun 06 17:09:48 EDT 2007
+#Sun Jun 24 11:52:58 EDT 2007
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
@@ -36,6 +36,7 @@ org.eclipse.jdt.core.compiler.problem.nullReference=error
 org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
 org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
+org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning
 org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
 org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
 org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
@@ -45,7 +46,7 @@ org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
 org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
 org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
-org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
+org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning
 org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
 org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
 org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.ui.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.ui.prefs
index e0802aadf..276c2e6d8 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.ui.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.jdt.ui.prefs
@@ -1,4 +1,4 @@
-#Mon Feb 05 18:45:12 PST 2007
+#Mon Feb 05 18:45:19 PST 2007
 eclipse.preferences.version=1
 formatter_profile=_Mylar based on Eclipse [built-in]
 formatter_settings_version=11
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.ltk.core.refactoring.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.ltk.core.refactoring.prefs
index e9c914fef..7ab03bdac 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.ltk.core.refactoring.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.ltk.core.refactoring.prefs
@@ -1,3 +1,3 @@
-#Fri Jun 02 15:30:30 PDT 2006
+#Fri Jun 02 15:30:09 PDT 2006
 eclipse.preferences.version=1
 org.eclipse.ltk.core.refactoring.enable.project.refactoring.history=true
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylar.tasklist.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylar.tasklist.prefs
index a7ca082bb..a6cf96a98 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylar.tasklist.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylar.tasklist.prefs
@@ -1,4 +1,4 @@
-#Fri Oct 20 16:44:00 PDT 2006
+#Fri Oct 20 16:54:30 PDT 2006
 eclipse.preferences.version=1
 project.repository.kind=bugzilla
 project.repository.url=https\://bugs.eclipse.org/bugs
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasklist.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasklist.prefs
index 5532461b9..0a2cc0b30 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasklist.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasklist.prefs
@@ -1,4 +1,4 @@
-#Mon Jun 18 17:13:23 PDT 2007
+#Mon Jun 18 17:14:59 PDT 2007
 eclipse.preferences.version=1
 project.repository.kind=bugzilla
 project.repository.url=https\://bugs.eclipse.org/bugs
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasks.ui.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasks.ui.prefs
new file mode 100644
index 000000000..d8c6d26af
--- /dev/null
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.mylyn.tasks.ui.prefs
@@ -0,0 +1,4 @@
+#Mon Jun 25 03:02:37 GMT 2007
+eclipse.preferences.version=1
+project.repository.kind=bugzilla
+project.repository.url=https\://bugs.eclipse.org/bugs
diff --git a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.pde.prefs b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.pde.prefs
index 05f9494ff..769b229ff 100644
--- a/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.pde.prefs
+++ b/org.eclipse.mylyn.bugzilla.ui/.settings/org.eclipse.pde.prefs
@@ -1,4 +1,4 @@
-#Thu Nov 03 15:46:12 PST 2005
+#Thu Nov 03 15:45:55 PST 2005
 compilers.p.deprecated=2
 compilers.p.no-required-att=0
 compilers.p.not-externalized-att=2
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
index 98934cd2a..ddb35fc44 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
@@ -685,6 +685,7 @@ public class BugzillaTaskEditor extends AbstractRepositoryTaskEditor {
 
 	}
 
+	@Override
 	protected String getHistoryUrl() {
 		if (repository != null && taskData != null) {
 			return repository.getUrl() + IBugzillaConstants.URL_BUG_ACTIVITY + taskData.getId();
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java
index 2c696e467..e2f3319ec 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java
@@ -158,10 +158,12 @@ public class BugzillaConnectorUi extends AbstractRepositoryConnectorUi {
 		}
 	}
 	
+	@Override
 	public String getTaskKindLabel(AbstractTask repositoryTask) {
 		return IBugzillaConstants.BUGZILLA_TASK_KIND;
 	}
 	
+	@Override
 	public String getTaskKindLabel(RepositoryTaskData taskData) {
 		return IBugzillaConstants.BUGZILLA_TASK_KIND;
 	}
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java
index a98352d1e..7f1f25a4e 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java
@@ -320,6 +320,7 @@ public class BugzillaRepositorySettingsPage extends AbstractRepositorySettingsPa
 			versions[0] = version;
 		}
 
+		@Override
 		public void run(IProgressMonitor monitor) throws CoreException {
 			try {
 				validate(monitor);
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaTaskEditorFactory.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaTaskEditorFactory.java
index 555ba7da5..0f22a53ba 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaTaskEditorFactory.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaTaskEditorFactory.java
@@ -34,6 +34,7 @@ public class BugzillaTaskEditorFactory extends AbstractTaskEditorFactory {
 
 	private static final String TITLE = "Bugzilla";
 
+	@Override
 	public EditorPart createEditor(TaskEditor parentEditor, IEditorInput editorInput) {
 		AbstractRepositoryTaskEditor editor = null;
 		if (editorInput instanceof RepositoryTaskEditorInput) {
@@ -49,6 +50,7 @@ public class BugzillaTaskEditorFactory extends AbstractTaskEditorFactory {
 		return editor;
 	}
 
+	@Override
 	public IEditorInput createEditorInput(AbstractTask task) {
 		if (task instanceof BugzillaTask) {
 			BugzillaTask bugzillaTask = (BugzillaTask) task;
@@ -60,18 +62,22 @@ public class BugzillaTaskEditorFactory extends AbstractTaskEditorFactory {
 		return null;
 	}
 
+	@Override
 	public String getTitle() {
 		return TITLE;
 	}
 
+	@Override
 	public boolean canCreateEditorFor(AbstractTask task) {
 		return task instanceof BugzillaTask;
 	}
 
+	@Override
 	public boolean providesOutline() {
 		return true;
 	}
 
+	@Override
 	public boolean canCreateEditorFor(IEditorInput input) {
 		if (input instanceof RepositoryTaskEditorInput) {
 			return BugzillaCorePlugin.REPOSITORY_KIND.equals(((RepositoryTaskEditorInput) input).getRepository()