diff options
author | Steffen Pingel | 2013-07-05 11:34:53 +0000 |
---|---|---|
committer | Gerrit Code Review @ Eclipse.org | 2013-07-12 09:37:50 +0000 |
commit | 2f0e8608f6a5cb97515905d030e040d865676544 (patch) | |
tree | 3e480d0019ce2a1c60072c9a1c73da8dacdb5dda | |
parent | 2a308fa2699dcc362a7f9a3eb2915357a31ab2af (diff) | |
download | org.eclipse.mylyn.tasks-2f0e8608f6a5cb97515905d030e040d865676544.tar.gz org.eclipse.mylyn.tasks-2f0e8608f6a5cb97515905d030e040d865676544.tar.xz org.eclipse.mylyn.tasks-2f0e8608f6a5cb97515905d030e040d865676544.zip |
412394: [api] provide editor as context when obtaining label and image
from task editor page factory
Change-Id: I5eba949deec9ca4ed31934103b2d12cfe0add2e0
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=412394
2 files changed, 32 insertions, 2 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPageFactory.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPageFactory.java index 081e3c7c5..026632cb4 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPageFactory.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPageFactory.java @@ -85,4 +85,34 @@ public abstract class AbstractTaskEditorPageFactory implements IPluginContributi this.pluginId = pluginId; } + /** + * Clients should override to provide an image for <code>page</code>. Invokes {@link #getPageImage()} for backwards + * compatibility. + * + * @param editor + * the task editor instance + * @param page + * the page that uses the image + * @return an image + * @since 3.10 + */ + public Image getPageImage(TaskEditor editor, IFormPage page) { + return getPageImage(); + } + + /** + * Clients should override to provide a label for <code>page</code>. Invokes {@link #getPageText()} for backwards + * compatibility. + * + * @param editor + * the task editor instance + * @param page + * the page that uses the label + * @return a label + * @since 3.10 + */ + public String getPageText(TaskEditor editor, IFormPage page) { + return getPageText(); + } + } diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java index daf2998ff..cd9113ab9 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/TaskEditor.java @@ -408,8 +408,8 @@ public class TaskEditor extends SharedHeaderFormEditor { try { IFormPage page = factory.createPage(this); int index = addPage(page); - setPageImage(index, factory.getPageImage()); - setPageText(index, factory.getPageText()); + setPageImage(index, factory.getPageImage(this, page)); + setPageText(index, factory.getPageText(this, page)); if (factory.getPriority() == AbstractTaskEditorPageFactory.PRIORITY_TASK) { setActivePage(index); } |