NEW - bug 293638: New Trac task repositories cannot be added as the Finish button is always disabled

https://bugs.eclipse.org/bugs/show_bug.cgi?id=293638

1 files changed, 7 insertions, 5 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
index 9669b2d0e..7449dc63b 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
@@ -1259,13 +1259,15 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
 	public boolean isPageComplete() {
 		String errorMessage = null;
 		String url = getRepositoryUrl();
+		// check for errors
 		errorMessage = isUniqueUrl(url);
-		if (errorMessage == null && !isValidUrl(url)) {
-			errorMessage = Messages.AbstractRepositorySettingsPage_Enter_a_valid_server_url;
-		}
-
 		if (errorMessage == null) {
-			if ((!needsAnonymousLogin() || !anonymousButton.getSelection()) && isMissingCredentials()) {
+			// check for messages
+			if (!isValidUrl(url)) {
+				errorMessage = Messages.AbstractRepositorySettingsPage_Enter_a_valid_server_url;
+			}
+			if (errorMessage == null && (!needsAnonymousLogin() || !anonymousButton.getSelection())
+					&& isMissingCredentials()) {
 				errorMessage = Messages.AbstractRepositorySettingsPage_Enter_a_user_id_Message0;
 			}
 			setMessage(errorMessage, repository == null ? IMessageProvider.NONE : IMessageProvider.ERROR);