diff options
author | spingel | 2011-06-13 15:41:51 +0000 |
---|---|---|
committer | spingel | 2011-06-13 15:41:51 +0000 |
commit | a33f035234ba165c9be411c71106445d0ebf1563 (patch) | |
tree | 1ead07c60fb43d649028ef7f5c4e8f2473d225a1 | |
parent | 7b5e3141365a0d035971e2170da86755b61ce20a (diff) | |
download | org.eclipse.mylyn.tasks-a33f035234ba165c9be411c71106445d0ebf1563.tar.gz org.eclipse.mylyn.tasks-a33f035234ba165c9be411c71106445d0ebf1563.tar.xz org.eclipse.mylyn.tasks-a33f035234ba165c9be411c71106445d0ebf1563.zip |
RESOLVED - bug 348356: reduce the number of warnings in framework plugins
https://bugs.eclipse.org/bugs/show_bug.cgi?id=348356
3 files changed, 11 insertions, 4 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java index ea5deb59e..7c91d3c40 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java @@ -1379,7 +1379,8 @@ public class TasksUiPlugin extends AbstractUIPlugin { try { taskListNotificationManager.addNotificationProvider(REMINDER_NOTIFICATION_PROVIDER); // taskListNotificationManager.addNotificationProvider(INCOMING_NOTIFICATION_PROVIDER); - TaskListNotifier taskListNotifier = new TaskListNotifier(getTaskDataManager(), getSynchronizationManger()); + TaskListNotifier taskListNotifier = new TaskListNotifier(getRepositoryModel(), getTaskDataManager(), + getSynchronizationManger()); getTaskDataManager().addListener(taskListNotifier); taskListNotificationManager.addNotificationProvider(taskListNotifier); taskListNotificationManager.startNotification(NOTIFICATION_DELAY); diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/notifications/TaskListNotifier.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/notifications/TaskListNotifier.java index 34bad046c..03c2877b7 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/notifications/TaskListNotifier.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/notifications/TaskListNotifier.java @@ -23,6 +23,7 @@ import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Status; import org.eclipse.mylyn.commons.core.StatusHandler; import org.eclipse.mylyn.internal.provisional.commons.ui.AbstractNotification; +import org.eclipse.mylyn.internal.tasks.core.RepositoryModel; import org.eclipse.mylyn.internal.tasks.core.data.ITaskDataManagerListener; import org.eclipse.mylyn.internal.tasks.core.data.SynchronizationManger; import org.eclipse.mylyn.internal.tasks.core.data.TaskDataDiff; @@ -46,11 +47,16 @@ public class TaskListNotifier implements ITaskDataManagerListener, ITaskListNoti private final List<TaskListNotification> notificationQueue = new ArrayList<TaskListNotification>(); + @SuppressWarnings("unused") + private final RepositoryModel repositoryModel; + public boolean enabled; private final SynchronizationManger synchronizationManger; - public TaskListNotifier(TaskDataManager taskDataManager, SynchronizationManger synchronizationManger) { + public TaskListNotifier(RepositoryModel repositoryModel, TaskDataManager taskDataManager, + SynchronizationManger synchronizationManger) { + this.repositoryModel = repositoryModel; this.taskDataManager = taskDataManager; this.synchronizationManger = synchronizationManger; } diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java index bcb70ee57..49aff359d 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListToolTip.java @@ -297,8 +297,8 @@ public class TaskListToolTip extends GradientToolTip { ITask task = (ITask) element; if (task.getSynchronizationState().isIncoming()) { String text = null; - TaskListNotifier notifier = new TaskListNotifier(TasksUiPlugin.getTaskDataManager(), - TasksUiPlugin.getDefault().getSynchronizationManger()); + TaskListNotifier notifier = new TaskListNotifier(TasksUiPlugin.getRepositoryModel(), + TasksUiPlugin.getTaskDataManager(), TasksUiPlugin.getDefault().getSynchronizationManger()); TaskDataDiff diff = notifier.getDiff(task); if (diff != null && diff.hasChanged()) { text = TaskDiffUtil.toString(diff, MAX_TEXT_WIDTH, false); |