diff options
author | Tomasz Zarna | 2013-05-27 17:52:55 +0000 |
---|---|---|
committer | Gerrit Code Review @ Eclipse.org | 2013-06-28 21:49:06 +0000 |
commit | 801d86f518e5d9d7b1d6297cbfab31b06f8a5da7 (patch) | |
tree | 7727a2890c1221078fcee9c407c7ab2e5e0e9354 | |
parent | 0f39bd71eb7b7e092ae2af0d3d23d997864589c6 (diff) | |
download | org.eclipse.mylyn.tasks-801d86f518e5d9d7b1d6297cbfab31b06f8a5da7.tar.gz org.eclipse.mylyn.tasks-801d86f518e5d9d7b1d6297cbfab31b06f8a5da7.tar.xz org.eclipse.mylyn.tasks-801d86f518e5d9d7b1d6297cbfab31b06f8a5da7.zip |
remove redundant StatusHandler#log call when reading ext points
ExtensionPointReader#read already logs status if it's not ok, see
#handleResult
Change-Id: I8611eb62fa24610f7ab7636648e236ac5714ef67
2 files changed, 6 insertions, 13 deletions
diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskJobFactory.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskJobFactory.java index c838ef843..c99315d0c 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskJobFactory.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/TaskJobFactory.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2004, 2010 Tasktop Technologies and others. + * Copyright (c) 2004, 2013 Tasktop Technologies and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -86,10 +86,7 @@ public class TaskJobFactory implements ITaskJobFactory { ExtensionPointReader<TaskJobListener> reader = new ExtensionPointReader<TaskJobListener>( ITasksCoreConstants.ID_PLUGIN, "taskJobListeners", "listener", TaskJobListener.class, "connectorKind", connectorKind); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ - IStatus status = reader.read(); - if (!status.isOK()) { - StatusHandler.log(status); - } + reader.read(); return reader.getItems(); } diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskDropHandler.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskDropHandler.java index 21f556aa7..b893a858f 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskDropHandler.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/util/TaskDropHandler.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2012 Tasktop Technologies and others. + * Copyright (c) 2012, 2013 Tasktop Technologies and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -9,9 +9,7 @@ * Tasktop Technologies - initial API and implementation *******************************************************************************/ -package org.eclipse.mylyn.internal.tasks.ui.util; - -import java.util.List; +package org.eclipse.mylyn.internal.tasks.ui.util;import java.util.List; import org.eclipse.core.runtime.ISafeRunnable; import org.eclipse.core.runtime.IStatus; @@ -23,6 +21,7 @@ import org.eclipse.mylyn.internal.tasks.ui.TasksUiPlugin; import org.eclipse.mylyn.tasks.core.ITask; import org.eclipse.mylyn.tasks.ui.TaskDropListener; import org.eclipse.mylyn.tasks.ui.TaskDropListener.TaskDropEvent; +; /** * @author Sam Davis @@ -38,10 +37,7 @@ public class TaskDropHandler { if (taskDropListeners == null) { ExtensionPointReader<TaskDropListener> reader = new ExtensionPointReader<TaskDropListener>( TasksUiPlugin.ID_PLUGIN, "taskDropListener", "listener", TaskDropListener.class); //$NON-NLS-1$//$NON-NLS-2$ - IStatus status = reader.read(); - if (!status.isOK()) { - StatusHandler.log(status); - } + reader.read(); taskDropListeners = reader.getItems(); } } |