diff options
author | Kilian Matt | 2011-02-06 17:45:19 +0000 |
---|---|---|
committer | Kilian Matt | 2011-03-09 20:57:02 +0000 |
commit | 5fe6054a3835b11a4432e3da770f779183de4291 (patch) | |
tree | 5a7bd8092ec5ff7769b42a405aa31a69a6e92b16 /tbr | |
parent | 61c86d94ddb0ca3be328ea8e07120a595a597665 (diff) | |
download | org.eclipse.mylyn.reviews-5fe6054a3835b11a4432e3da770f779183de4291.tar.gz org.eclipse.mylyn.reviews-5fe6054a3835b11a4432e3da770f779183de4291.tar.xz org.eclipse.mylyn.reviews-5fe6054a3835b11a4432e3da770f779183de4291.zip |
Minor cleanup
-ignore warning about internal api
-minor reformatting
Diffstat (limited to 'tbr')
2 files changed, 16 insertions, 10 deletions
diff --git a/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/CreateReviewActionFromAttachment.java b/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/CreateReviewActionFromAttachment.java index d92650326..81c8bf285 100644 --- a/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/CreateReviewActionFromAttachment.java +++ b/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/CreateReviewActionFromAttachment.java @@ -39,6 +39,12 @@ import org.eclipse.mylyn.tasks.core.data.TaskMapper; import org.eclipse.mylyn.tasks.ui.TasksUi; import org.eclipse.ui.IActionDelegate; +/** + * + * @author mattk + * + */ +@SuppressWarnings("restriction") public class CreateReviewActionFromAttachment extends Action implements IActionDelegate { @@ -53,7 +59,8 @@ public class CreateReviewActionFromAttachment extends Action implements ITaskDataManager manager = TasksUi.getTaskDataManager(); TaskData parentTaskData = manager.getTaskData(taskAttachment .getTask()); - ITaskProperties parentTask= TaskProperties.fromTaskData(manager, parentTaskData); + ITaskProperties parentTask = TaskProperties.fromTaskData(manager, + parentTaskData); TaskMapper initializationData = new TaskMapper(parentTaskData); IReviewMapper taskMapper = ReviewsUiPlugin.getMapper(); @@ -69,12 +76,13 @@ public class CreateReviewActionFromAttachment extends Action implements ITaskProperties taskProperties = TaskProperties.fromTaskData( manager, taskData); - taskProperties.setSummary("[review] " + parentTask.getDescription()); + taskProperties + .setSummary("[review] " + parentTask.getDescription()); String reviewer = taskRepository.getUserName(); taskProperties.setAssignedTo(reviewer); - initTaskProperties(taskMapper, taskProperties,parentTask); + initTaskProperties(taskMapper, taskProperties, parentTask); TasksUiInternal.createAndOpenNewTask(taskData); } catch (CoreException e) { @@ -84,15 +92,13 @@ public class CreateReviewActionFromAttachment extends Action implements } private void initTaskProperties(IReviewMapper taskMapper, - ITaskProperties taskProperties,ITaskProperties parentTask) { + ITaskProperties taskProperties, ITaskProperties parentTask) { ReviewScope scope = new ReviewScope(); for (ITaskAttachment taskAttachment : selection2) { // FIXME date from task attachment - Attachment attachment = ReviewsUtil - .findAttachment(taskAttachment.getFileName(), - taskAttachment.getAuthor().getPersonId(), - taskAttachment.getCreationDate().toString(), - parentTask); + Attachment attachment = ReviewsUtil.findAttachment(taskAttachment + .getFileName(), taskAttachment.getAuthor().getPersonId(), + taskAttachment.getCreationDate().toString(), parentTask); if (attachment.isPatch()) { scope.addScope(new PatchScopeItem(attachment)); } else { @@ -127,5 +133,4 @@ public class CreateReviewActionFromAttachment extends Action implements } } } - } diff --git a/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/editors/ReviewTaskEditorPage.java b/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/editors/ReviewTaskEditorPage.java index a7b674caf..71f035d55 100644 --- a/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/editors/ReviewTaskEditorPage.java +++ b/tbr/org.eclipse.mylyn.reviews.tasks.ui/src/org/eclipse/mylyn/reviews/tasks/ui/internal/editors/ReviewTaskEditorPage.java @@ -40,6 +40,7 @@ import org.eclipse.swt.widgets.Listener; /* * @author Kilian Matt */ +@SuppressWarnings("restriction") public class ReviewTaskEditorPage extends AbstractTaskEditorPage { private ReviewScope scope; |