Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam Davis2015-01-14 00:30:07 +0000
committerGerrit Code Review @ Eclipse.org2015-01-16 18:08:24 +0000
commit2ffa929988874d6a1596a0600c40b598d9f6b3ac (patch)
tree4095a9edeed4b7665b9e54d4b265aa558c751551
parent83aea24696944dc490d0f3c710e136e4f77304d9 (diff)
downloadorg.eclipse.mylyn.reviews-2ffa929988874d6a1596a0600c40b598d9f6b3ac.tar.gz
org.eclipse.mylyn.reviews-2ffa929988874d6a1596a0600c40b598d9f6b3ac.tar.xz
org.eclipse.mylyn.reviews-2ffa929988874d6a1596a0600c40b598d9f6b3ac.zip
453957: show CR and V flags in the correct columns
Change-Id: I3fbb3b998d1e36a54c87e86f3804e3f66533f3e8 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453957
-rw-r--r--org.eclipse.mylyn.gerrit.dashboard.ui/src/org/eclipse/mylyn/gerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java46
1 files changed, 10 insertions, 36 deletions
diff --git a/org.eclipse.mylyn.gerrit.dashboard.ui/src/org/eclipse/mylyn/gerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java b/org.eclipse.mylyn.gerrit.dashboard.ui/src/org/eclipse/mylyn/gerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
index eb060e88f..40d18d5ca 100644
--- a/org.eclipse.mylyn.gerrit.dashboard.ui/src/org/eclipse/mylyn/gerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
+++ b/org.eclipse.mylyn.gerrit.dashboard.ui/src/org/eclipse/mylyn/gerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
@@ -27,7 +27,7 @@ import org.eclipse.swt.widgets.Display;
/**
* This class implements the implementation of the Dashboard-Gerrit UI view label provider.
- *
+ *
* @author Jacques Bouthillier
* @version $Revision: 1.0 $
*/
@@ -116,7 +116,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
/**
* Return an image representing the state of the object
- *
+ *
* @param int aState
* @return Image
*/
@@ -140,7 +140,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
/**
* Return an image representing the state of the object
- *
+ *
* @param int aState
* @return Image
*/
@@ -162,7 +162,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
/**
* Return an image representing the state of the ID object
- *
+ *
* @param Boolean
* aState
* @return Image
@@ -179,7 +179,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
/**
* Return the text associated to the column
- *
+ *
* @param Object
* structure of the table
* @param int column index
@@ -256,7 +256,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
/**
* Return the image associated to the column
- *
+ *
* @param Object
* structure of the table
* @param int column index
@@ -264,9 +264,6 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
*/
@SuppressWarnings("restriction")
public Image getColumnImage(Object aObj, int aIndex) {
- // GerritPlugin.Ftracer
- // .traceWarning("getColumnImage column: " + aIndex);
- Image image = null;
String value = null;
if (aObj instanceof GerritTask) {
GerritTask reviewSummary = (GerritTask) aObj;
@@ -277,19 +274,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
return getReviewId(Boolean.valueOf(value.toLowerCase()));
}
break;
- case 1:
- return image;
- case 2:
- return image;
- case 3:
- return image;
- case 4:
- return image;
- case 5:
- return image;
- case 6:
- return image;
- case 7:
+ case 8:
value = reviewSummary.getAttribute(GerritTask.REVIEW_STATE);
if (null != value && !value.equals(EMPTY_STRING)) {
@@ -297,15 +282,7 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
return getReviewStateImage(val);
}
break;
- case 8:
-// value = reviewSummary.getAttribute(GerritTask.IS_IPCLEAN);
-//
-// if (null != value && !value.equals(EMPTY_STRING)) {
-// int val = Integer.parseInt(value);
-// return getReviewSate(val);
-// }
-// break;
-// case 9:
+ case 9:
value = reviewSummary.getAttribute(GerritTask.VERIFY_STATE);
if (null != value && !value.equals(EMPTY_STRING)) {
@@ -313,17 +290,14 @@ public class ReviewTableLabelProvider extends LabelProvider implements ITableLab
return getVerifyStateImage(val);
}
break;
- default:
- return image;
}
}
-
- return image;
+ return null;
}
/**
* Adjust the column color
- *
+ *
* @param Object
* ReviewTableListItem
* @param int columnIndex

Back to the top