NEW - bug 375181: After upgrade to Mylyn 3.7 on workbench shutdown:v0.9.1R_3_7_1e_3_8_m_3_7_x

HudsonException: Unexpected parameter 'parameterDefinition' with type
'ListSubversionTagsParameterDefinition' 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=375181

1 files changed, 18 insertions, 25 deletions

diff --git a/org.eclipse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/HudsonServerBehaviour.java b/org.eclipse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/HudsonServerBehaviour.java
index 50dee618..96f3d0ca 100644
--- a/org.eclipse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/HudsonServerBehaviour.java
+++ b/org.eclipse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/HudsonServerBehaviour.java
@@ -14,7 +14,6 @@
 
 package org.eclipse.mylyn.internal.hudson.core;
 
-import java.io.IOException;
 import java.io.Reader;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
@@ -27,8 +26,6 @@ import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
 
-import javax.xml.parsers.ParserConfigurationException;
-
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.mylyn.builds.core.BuildState;
@@ -88,11 +85,9 @@ import org.eclipse.mylyn.internal.hudson.model.HudsonTasksJunitTestResult;
 import org.eclipse.mylyn.internal.hudson.model.HudsonTasksTestAggregatedTestResultAction;
 import org.eclipse.mylyn.internal.hudson.model.HudsonTasksTestAggregatedTestResultActionChildReport;
 import org.eclipse.osgi.util.NLS;
-import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
-import org.xml.sax.SAXException;
 
 /**
  * @author Markus Knittig
@@ -599,13 +594,11 @@ public class HudsonServerBehaviour extends BuildServerBehaviour {
 				Element child = (Element) children.item(i);
 				String tagName = child.getTagName();
 				if ("parameterDefinition".equals(tagName)) { //$NON-NLS-1$
-					IParameterDefinition parameterDefinition;
 					try {
-						parameterDefinition = parseParameter(child);
+						IParameterDefinition parameterDefinition = parseParameter(child);
 						parameterDefinitions.add(parameterDefinition);
 					} catch (HudsonException e) {
-						e.printStackTrace();
-						// ignore
+						// unknown parameter type, ignore 
 					}
 				}
 			}
@@ -680,22 +673,22 @@ public class HudsonServerBehaviour extends BuildServerBehaviour {
 				getElementContent(element, "type", false)));
 	}
 
-	private void parseParametersFromJobConfig(Document document, List<IParameterDefinition> definitions)
-			throws ParserConfigurationException, SAXException, IOException, HudsonException {
-		NodeList containers = document.getElementsByTagName("parameterDefinitions"); //$NON-NLS-1$
-		for (int i = 0; i < containers.getLength(); i++) {
-			Element container = (Element) containers.item(i);
-			NodeList elements = container.getChildNodes();
-			for (int j = 0; j < elements.getLength(); j++) {
-				Node node = elements.item(j);
-				if (node instanceof Element) {
-					Element element = (Element) elements.item(j);
-					IParameterDefinition definition = parseParameter(element);
-					definitions.add(definition);
-				}
-			}
-		}
-	}
+//	private void parseParametersFromJobConfig(Document document, List<IParameterDefinition> definitions)
+//			throws ParserConfigurationException, SAXException, IOException, HudsonException {
+//		NodeList containers = document.getElementsByTagName("parameterDefinitions"); //$NON-NLS-1$
+//		for (int i = 0; i < containers.getLength(); i++) {
+//			Element container = (Element) containers.item(i);
+//			NodeList elements = container.getChildNodes();
+//			for (int j = 0; j < elements.getLength(); j++) {
+//				Node node = elements.item(j);
+//				if (node instanceof Element) {
+//					Element element = (Element) elements.item(j);
+//					IParameterDefinition definition = parseParameter(element);
+//					definitions.add(definition);
+//				}
+//			}
+//		}
+//	}
 
 	private BuildStatus parseResult(Node node) {
 		if (node != null) {