diff options
| author | Igor Fedorenko | 2011-03-08 18:37:27 +0000 |
|---|---|---|
| committer | Igor Fedorenko | 2011-03-08 18:48:06 +0000 |
| commit | cbb4454fbcf0f389b22a04ed0f7448146ad1dbdd (patch) | |
| tree | a76149cc541d7a67996810a3d664b0bca1a536c2 /org.eclipse.m2e.tests.common | |
| parent | 0b0636480c27b34860f44a1c6ba6d192b4832d39 (diff) | |
| download | m2e-core-cbb4454fbcf0f389b22a04ed0f7448146ad1dbdd.tar.gz m2e-core-cbb4454fbcf0f389b22a04ed0f7448146ad1dbdd.tar.xz m2e-core-cbb4454fbcf0f389b22a04ed0f7448146ad1dbdd.zip | |
Can't finish import wizard in some cases
On first page, Finish is enabled when page is complete and there
are no lifecycle mapping errors and no selected proposals.
On second page, Finish is enabled when there are no selected
proposals. Note it is possible to finish import even if there are
mapping problems.
Moved proposal autocomplete to a later moment (when mapping page
set visible), so if Finish is pressed on the first page the wizard
will not attempt to install anything.
Fixed number of issues with mapping proposals not showing on the
mapping page or showing with wrong icon and/or text.
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
Diffstat (limited to 'org.eclipse.m2e.tests.common')
| -rw-r--r-- | org.eclipse.m2e.tests.common/src/org/eclipse/m2e/tests/common/AbstractLifecycleMappingTest.java | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/org.eclipse.m2e.tests.common/src/org/eclipse/m2e/tests/common/AbstractLifecycleMappingTest.java b/org.eclipse.m2e.tests.common/src/org/eclipse/m2e/tests/common/AbstractLifecycleMappingTest.java index 0d4823de..52e36916 100644 --- a/org.eclipse.m2e.tests.common/src/org/eclipse/m2e/tests/common/AbstractLifecycleMappingTest.java +++ b/org.eclipse.m2e.tests.common/src/org/eclipse/m2e/tests/common/AbstractLifecycleMappingTest.java @@ -37,7 +37,6 @@ import org.eclipse.m2e.core.MavenPlugin; import org.eclipse.m2e.core.internal.lifecyclemapping.LifecycleMappingFactory; import org.eclipse.m2e.core.internal.lifecyclemapping.model.LifecycleMappingMetadataSource; import org.eclipse.m2e.core.internal.lifecyclemapping.model.PluginExecutionMetadata; -import org.eclipse.m2e.core.internal.lifecyclemapping.model.io.xpp3.LifecycleMappingMetadataSourceXpp3Reader; import org.eclipse.m2e.core.internal.project.registry.MavenProjectFacade; import org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager; import org.eclipse.m2e.core.project.IMavenProjectFacade; @@ -83,8 +82,8 @@ public abstract class AbstractLifecycleMappingTest extends AbstractMavenProjectT assertTrue("File does not exist:" + metadataFile.getAbsolutePath(), metadataFile.exists()); InputStream in = new FileInputStream(metadataFile); try { - LifecycleMappingMetadataSource lifecycleMappingMetadataSource = new LifecycleMappingMetadataSourceXpp3Reader() - .read(in); + LifecycleMappingMetadataSource lifecycleMappingMetadataSource = LifecycleMappingFactory + .createLifecycleMappingMetadataSource(in); return lifecycleMappingMetadataSource; } finally { IOUtil.close(in); |