Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFred Bricon2012-08-18 16:28:37 +0000
committerFred Bricon2012-08-18 16:32:54 +0000
commit5e6c73b911d29bef0abde89e49894020b935e0c5 (patch)
tree4b85a6f4cc46516404f94758af0f696a80a9a780
parentc025571c3c2fd2fb52ecbbea92cb3594272ec853 (diff)
downloadm2e-core-5e6c73b911d29bef0abde89e49894020b935e0c5.tar.gz
m2e-core-5e6c73b911d29bef0abde89e49894020b935e0c5.tar.xz
m2e-core-5e6c73b911d29bef0abde89e49894020b935e0c5.zip
387521 : proper way to prevent SWTException
instead of passing a null progress monitor, which prevents the user from cancelling archetype downloads, forking the process (getContainer().run(true, true, new IRunnableWithProgress() {}) does not produce the dreaded 'SWTException: Invalid thread access' error Signed-off-by: Fred Bricon <fbricon@gmail.com>
-rw-r--r--org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizardArchetypeParametersPage.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizardArchetypeParametersPage.java b/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizardArchetypeParametersPage.java
index f3eaeba5..1c612d77 100644
--- a/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizardArchetypeParametersPage.java
+++ b/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizardArchetypeParametersPage.java
@@ -383,7 +383,7 @@ public class MavenProjectWizardArchetypeParametersPage extends AbstractMavenWiza
final String archetypeName = groupId + ":" + artifactId + ":" + version; //$NON-NLS-1$ //$NON-NLS-2$
try {
- getContainer().run(false, true, new IRunnableWithProgress() {
+ getContainer().run(true, true, new IRunnableWithProgress() {
public void run(IProgressMonitor monitor) {
monitor.beginTask(NLS.bind(org.eclipse.m2e.core.ui.internal.Messages.MavenProjectWizardArchetypeParametersPage_task, archetypeName), IProgressMonitor.UNKNOWN);
@@ -393,7 +393,7 @@ public class MavenProjectWizardArchetypeParametersPage extends AbstractMavenWiza
ArtifactRepository remoteArchetypeRepository = archetypeManager.getArchetypeRepository(archetype);
- List<?> properties = archetypeManager.getRequiredProperties(archetype, remoteArchetypeRepository, null);
+ List<?> properties = archetypeManager.getRequiredProperties(archetype, remoteArchetypeRepository, monitor);
if(properties != null) {
for(Object o : properties) {

Back to the top