Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-03-18Bug 486446 - StandInException in DockerMachine.executev4.2.2stable-4.2Xavier Coulon3-2/+73
Checking that the 'docker-machine' command is found before attempting to run it, and validating the Docker Mahcine preference page by checking that the command is found there, too. Change-Id: I872008d5c49510624b23bf98e1944fb157163556 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/68663 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com> Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/68774
2016-03-18Bug 488976 - NullPointer in DockerConnection.hasImageXavier Coulon1-0/+8
Making sure that the returned list of images and the 'images' field in the DockerConnection class are not null after a call to DockerConnection#getImages(boolean) Change-Id: I51fef0c350a2d71c0abda108773eb5c070123b24 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/68654 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/68723
2016-03-17Prevent NPE when an image has no repoTags.Roland Grunberg1-0/+3
Change-Id: I79b6a1457a66b5c8d5f62d318f78cd06fed564cc Reviewed-on: https://git.eclipse.org/r/67368 Tested-by: Hudson CI Reviewed-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/68699 Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-03-17Bug 488712 - IndexOutOfBoundsException below DockerContainer.nameJeff Johnston1-1/+3
- add check for names list being null or empty Change-Id: I20f1396024bab4b260956b42dcc3e34f3640dda4 Reviewed-on: https://git.eclipse.org/r/67562 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/68701
2016-02-05Bug 486463 - SWTException below DockerImagesView$8.runXavier Coulon1-2/+10
Unregister the Docker Images View as an image listener when the view is disposed. Preventing refreshing the view when the table widget is disposed Preventing NPE when iterating on images and containers listeners Added SWTBot tests Change-Id: I45355965a236bddfb8720e7872391a4f50701fdc Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/65567 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/66040
2016-02-05Lookup for docker-machine and the VM driver should consult PATH first.Roland Grunberg1-7/+18
Don't wipe out the PATH set by the system when setting user-specified PATH entry preferences. Instead append additional entries to it. Change-Id: I48bb1b82a6f908e07da0ef85d61fe1e530c5ed63 Reviewed-on: https://git.eclipse.org/r/65843 Tested-by: Hudson CI Reviewed-by: Xavier Coulon <xcoulon@redhat.com> (cherry picked from commit 8e0c5a02c780f16b4708b9f2aff3c3d4fa2f20c7) Reviewed-on: https://git.eclipse.org/r/65887 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-01-22Bug 481218 - DockerImages view shows same repo name instead of all variantsXavier Coulon3-60/+134
Using the 'repo()' instead of 'repoTags()' method to retrieve the actual repo name for the Docker Images. Making sure that there's one DockerImage for all repo/tags in the Docker Images view, but one Docker Image *per repo/tags* in the Docker Explorer view Changing the equals/hashcode implementations in DockerImage to distinguish 2 images with the same id but with different names (otherwise, a single tree item was displayed in the Docker Explorer view). Also preventing exception if image id is less than 12 characters. Added SWTBot tests to verify the number of items in the Docker Images view and in the Docker Explorer view. Change-Id: I3c2df8d6b8e8620cc9c46a81e06a2c4d163ac527 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/65029 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-01-21Bug 483679 - [docker image search] make tag selection optionalXavier Coulon1-0/+2
Allow for search wizard completion when an image is selected in the search result list, in which case the 'latest' tag is assumed. Added SWTBot tests Added a constant in DockerImage (not the API) to handle the 'latest' tag value Change-Id: I74c63f3ee6e533f55c9b875dff24df9d60f73380 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/63540 Tested-by: Hudson CI (cherry picked from commit d115f02832c62128e003bbac29f8f5365531741e) Reviewed-on: https://git.eclipse.org/r/64690 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-01-20Bug 485734 - NullPointerException below DockerClientFactory.getClientXavier Coulon2-8/+13
Avoid building a client when params are null or empty Change-Id: Id967ecedd7a69e0816fcc4a6a2c27599cb9efa79 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/64284 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/64739
2016-01-19Bug 485350 - SWTException: Widget is disposed when DockerExplorer view is closedXavier Coulon1-0/+29
Renoving listeners when Docker Explorer view is disposed Added SWTBot test to verify that the listeners were actually removed Removed code duplication in test utility classes. Change-Id: Iba939073614d22dd2368a8d13fa13ff0537d9fd1 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/64215 Tested-by: Hudson CI Tested-by: Roland Grunberg <rgrunber@redhat.com> Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Reviewed-on: https://git.eclipse.org/r/64681
2016-01-19Bug 485733 - NullPointerException in ↵Xavier Coulon1-18/+22
DefaultDockerConnectionSettingsFinder.defaultsWithShellEnv Fixed the default value to 'false' instead of 'null' when there is no DOCKER_TLS_VERIFY variable available Added unit tests Change-Id: Ib1be00ca2ba87cd4e6d57efc363c75acdf94d7d2 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/64653 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 58caa912f554efd30455a3b76744591e88e3699d) Reviewed-on: https://git.eclipse.org/r/64676
2016-01-18Bug 475331 - NullPointerException in DockerConnection.getInfoXavier Coulon2-7/+16
Prevent NPE when DockerClient is null, and prevent NPE in callers that would retrieve a null value. Change-Id: I23fbdfd9f70cfdb0fc182f084377262a0eebd89d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/64358 Tested-by: Hudson CI Reviewed-on: https://git.eclipse.org/r/64600 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-01-18Bug 485910 - Add missing "Labels" from Container infoXavier Coulon2-0/+21
labels were already returned by the underlying Docker client but not collected in the DockerContainerInfo new labels() method is not exposed in the API yet (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=485936) Change-Id: I4f5eb68a5bdcfe49cbfc49f3e272dcb58ba1491d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/64451 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 640a4b1e557d05396950e50cf0029d2b1d834ed1) Reviewed-on: https://git.eclipse.org/r/64585
2016-01-14Bug 483680 - [docker image search] search results ignore repo whenXavier Coulon1-3/+7
searching for repo/imagename the searchImages method in the DockerConnection class filters the results returned by the client to only retain those that contain the exact term given by the user. So if the user input "jboss/wildfly", only this image will appear in the result list, but if the user input "wildfly", more results (25 at the time of writing this message) will be displayed in the list. Change-Id: Icfdb64814ed6800a10f546e0912ff081e7a84984 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/63552 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/64201
2016-01-04Bug 481300: Fix various refresh issues in Docker Views.Roland Grunberg1-0/+25
The get -> refresh -> set logic is not what's responsible for preserving a selection after refreshes occur. The UI already knows how to preserve a selection. As long as the objects given to the content provider override equals() and hasCode(), the selection will be preserved without any intervention. Change-Id: Ib1cd804080f7d44053b4d6806583f610fbdb166b Reviewed-on: https://git.eclipse.org/r/63219 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 7b6e6aa274be46e04f3adbc2cd5cb868e76f828a) Reviewed-on: https://git.eclipse.org/r/63511
2015-12-15Bug 484344: Cannot attach to any container after image build.Roland Grunberg1-3/+3
Workaround for 'Hijack is incompatible with use of CloseNotifier'. Simply ensure that the image build is done on a separate client copy. Change-Id: Ie744bf041932d3612105f15e85ff82377458c95f Reviewed-on: https://git.eclipse.org/r/62751 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2015-12-09Bug 483796 - Missing settings when re-using launch configurationXavier Coulon3-43/+49
Saving and restoring memory limit and CPU shares in the launch config Setting the UI widgets to the initial value from the model loaded from the launch config Actually using the memory limit and cpu shares in the DockerHostConfig when creating the container (was not implemented) Change-Id: I4d4f3ad09644f57decaf47276d32add2bbc2eb9a Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/62253 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 6f9fdd5a3003bdc92d0cadeb3c84869cc0e934d2) Reviewed-on: https://git.eclipse.org/r/62351
2015-12-08Bug 483928 - Unable to detect env variables on LinuxXavier Coulon2-22/+16
Using 2 scripts for Linux vs MacOSX, to be able to use the '-i' flag in the latter and not in the former. Change-Id: Ia77b7bb1fa31930be803469875ab9754bb5a4aa0 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/62239 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 22d8c7305421c6b1f0307de21ba7080ff7be6e65) Reviewed-on: https://git.eclipse.org/r/62261
2015-12-08Bug 483676 - Avoid logging multiple times when connection is downXavier Coulon1-8/+12
Added an 'active' flag to track if connection was previously known as 'active' and log the error, unless the flag was already set to 'false', indicating that the connection was known as inactive/failed. Change-Id: Ic52462596e242fb81014de0eb0e2202070c94a1d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/62093 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 46429f06524d3d6f2357b70c2afd3d524c197093) Reviewed-on: https://git.eclipse.org/r/62158
2015-12-07Bug 483769 - DockerExplorerView flickers when container info isXavier Coulon2-41/+126
displayed and refreshed Added a map to track containers by id and re-use the previous container info when creating a new instance of DockerContainer for a given container, so that associated containerInfo does not need to be initialized again. Making sure that containers are sorted by name. Refactored the listContainers() method based on https://git.eclipse.org/r/#/c/54209/3 Change-Id: I46aed8ca720041d5d019f80eb75d0c2f78c5e0ea Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/62082 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 87a3781d972e8c61056418d351745e9eb5616eae) Reviewed-on: https://git.eclipse.org/r/62155
2015-12-03Remove previously added methods in public APIXavier Coulon4-42/+32
Method implementations are kept but not exposed in the API which is a violation of the minor release contract. These methods will be added back in the API in the next major release. Change-Id: Icd0692bfc89ce48c515efacc75249c73b79d4274 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/61650 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit d23cf77228fd43b41f912c766b31623565ecd06c) Reviewed-on: https://git.eclipse.org/r/61836
2015-12-02Bug 482610 - Images and Containers View sometimes doesn't reflect connection ↵Xavier Coulon1-1/+0
state Setting the selection to the added connection (when adding a new one) or to the first remaining connection (or null) when removing one. Docker Images view and Docker Containers view react to selection change, including when new selection is empty. Change-Id: I0607db5cf244b42487739d06df02a254a8c35e92 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/61566 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 3e61fb1c4a21f7f9db6d5e50624752f57c02be17) Reviewed-on: https://git.eclipse.org/r/61822
2015-12-01Bug 480401 - Create a launch configuration when running an image from wizardXavier Coulon3-57/+83
Creating a LaunchConfiguration when the container starts, adding a creation_date attribute to be able to find the latest launch config for a given image name, when the user selects the image again to run another container. Protecting the domain class initialization by checking that retrieved info from the client are not null. Retrieving last launch configuration for the selected image name to prefill the wizard (some refactoring was required to pass the last launch configuration and fill the page models) Added SWTBot tests Change-Id: If24e0c1b7f7aea838f86a3c37fec42ae2bfe03f7 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/61494 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 6c859255f4bca47dfc8ace839ba28d07a9a2cc37) Reviewed-on: https://git.eclipse.org/r/61698
2015-11-27Bug 481217 - Tag Image command in Docker Explorer is unboundXavier Coulon1-0/+24
Fixed problems where Tag/Untag images would not be called from Docker Explorer view Refactored the "createControl(Composite)" methods in ImageRemoveTagPage and ImageTagPage classes to using GridLayoutFactory and GridDataFactory. As a result, the wizards consumes less vertical space. Change-Id: I9d525370b89f88f391f67a4f594ee33e997ff8c1 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/59468 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Hudson CI
2015-11-27Restored removed API methodsXavier Coulon1-0/+43
Change-Id: I637d175ff32950d3d0edfee4129b86b316132123 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/61308 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-11-27Bug 480885 - Docker-machine detection does not work on Mac OSXXavier Coulon1-34/+100
Added a preference page for Docker Machine with validation Default values are set based on the OS name Fixed missing validation support in main Docker page for refresh rate Refactored preference page ids in plugin.xml for consistency with class names Moved "Search" button on NewConnectionPage to top right, after the connection name field Change-Id: I7ac2768676dfdcbab8ad864b8f74c2c7fe4f4020 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/59283 Tested-by: Hudson CI
2015-11-25Bug 474196 - Add options to Image build launcherXavier Coulon7-9/+152
Added options to - quiet build - no cache - remove intermediate containers on successful build - always remove intermediate containers - repo/tag Build configuration name is generated after the image name (repo + tag) when available, or falls back to default "DockerFile[<projectName>]" pattern. Moved ImageNameValidator in a separate class to reuse across wizards Moved pattern to match image name in DockerImageName for reuse accross classes Change-Id: I9e14b74b33bfea37aacfbcae10bac2572ac04c55 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/59464 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2015-11-25Bug 481219 - Validate container name in "Image Run" wizardXavier Coulon4-58/+66
Raise an error message when a container with the same name exists. Also added checks to avoid NPE when initializing ContainerInfo and ImageInfo Refactored some SWT utility classes used to setup the mock connection and moved some reusable blocks in JUnit rules. Change-Id: Ie8363fb4af6e8e5d210734c7f9028b27ac70548a Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/61113 Tested-by: Hudson CI
2015-11-23Bug 471671: Start using com.spotify.docker.client 3.1.10.Roland Grunberg1-10/+1
- Remove workarounds for reconnecting when a SocketTimeout is hit. - Implement proper validation for container refresh preference option. Change-Id: I277d1cd6b2663d25b44de4ee42897592b8367605 Reviewed-on: https://git.eclipse.org/r/60948 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Tested-by: Hudson CI
2015-11-19Bug 479856 - Add "Show in>Web Browser" and "Show in>File Browser"Xavier Coulon4-19/+27
Added a menu entry in the popup for the "Show In" group Added 2 menu contributions, one for the Web browser when a DockerContainerPort is selected, and the other one when a DockerContainerVolume is selected Opening in the System Explorer reuses some code borrowed from org.elipse.ui.ide with some adaptations because the host directory for the container volume is not necessarily a file or a folder in the workspace, hence it cannot be adapted (as in IAdaptable) into an IResource Change-Id: Ief810a5b89072c0eed673363df93efb0800ed80d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/60815 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-11-19bug 471666 - Show nested elements with most relevant info in Explorer ViewXavier Coulon6-4/+73
Showing ports, links and volumes for each container Loading ContainerInfo in background if it was not already loaded (hence, a new method in IDockerContainer) Make sure the 'volumes', 'ports' and 'links' nodes remain expanded when the 'refresh' command is called Added UI tests Running SWTBot tests on MacOSX (until they can also run on Hudson at Eclipse) Change-Id: Id7b5f3982c660970824a8c8a564d49c9717fc0ce Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/60725 Tested-by: Hudson CI
2015-11-19Bug 471672: Use a TM Terminal for containers with openStdin and tty.Roland Grunberg1-137/+62
Change-Id: Ifee8ab5ed99ad2419e3e1346899b5939f5b7f2e6 Reviewed-on: https://git.eclipse.org/r/59955 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2015-11-19Bug 481562 - Docker Image label in Docker explorer badly displayed when ↵Xavier Coulon1-2/+2
contains registry Change-Id: Ie3ffacc942329d6e4ff54a03d0bc3201e6a4479a Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/60610 Tested-by: Hudson CI
2015-11-18Bug 475883 - Add "Refresh" commands in the containers and images categoriesXavier Coulon7-370/+206
Removed the 'Refresh' button in the Docker Explorer view toolbar as it was confusing and somehow misleading (it would reload the connections, that's all) Added a single 'Refresh' command handler on the 'Containers' and 'Images' The 'Refresh' command associated with this handler is the default Eclipse 'Refresh' command, so the user can invoke the command from the 'File>Refresh' menu. Refactored the IDockerConnectionManagerListener to specify the actual connection that was changed Remove IDockerConnectionManagerListener implementation in both DockerContainersView and DockerImagesView since those views already respond to selection changes in the Docker Explorer view. Changes above fix the problem where a connection with the same hash (eg: a connection was removed and then added back) would end up with the old DockerExplorerView$ContainerRefresher instance being registered instead of the new one. Added groups for commands and specified the order in which commands should appear in the context menus (some declarations in plugin.xml were moved to ease the reading of the chaining between commands) Added tests to verify that the list of containers and images changes in the Docker Explorer after calling the command. Change-Id: Ic3b2cf5466c818deb1645e563d8a394eb7c67d57 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/59609 Tested-by: Hudson CI
2015-11-03Bug 477912 - Mock the Docker daemon in unit testsXavier Coulon11-145/+827
- Refactoring the code to move the logic of discovering connection settings into a new interface/implementation. - Added a hierarchy of connection settings classes for Unix sockets vs TCP - New pluggable utility class to discover connection settings - Refactored the ConnectionManager by moving the storage logic (load/save connections) in an external class that implements the new IDockerConnectionStorageManager interface - In unit tests, the interfaces mentionned above are mocked to return anything needed (no connection, valid socket, etc.) - Added a bundle to wrap the org.hamcrest dependencies and expose a single exported package for Mockito. (See https://bugs.eclipse.org/bugs/show_bug.cgi?id=403676#c10) Change-Id: I3dcfcd674ab8c17eff63d037a7a1d6f2250e1677 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/56859 Tested-by: Hudson CI
2015-10-30Bug 480813 - Should provide a launch shortcut for Build Image LaunchJeff Johnston1-0/+5
- add a new launch shortcut: BuildDockerImageShortcut - fix the BuildImageJob to build the image with a default name so it can be tagged in the future and will show up even when Image filtering is on - fix BuildImageJob to use Dockerfile as the name to look for - add a config_id to IBuildDockerImageLaunchConstants so that it is centralized - add a getActiveWorkbenchShell method to Docker UI Activator plug-in - add a toString() method to DockerConnection which returns the connection name Change-Id: I89f59f0fb4fcf2bee2edc5f7856aee15cd2b254b Reviewed-on: https://git.eclipse.org/r/59057 Tested-by: Hudson CI Reviewed-by: Xavier Coulon <xcoulon@redhat.com>
2015-10-09Bug 479391 - Invalid command state when container is in "Created" statusXavier Coulon1-1/+3
Added a check for the "Created" status, in which case the container is assumed to be STOPPED. Change-Id: Icbe0068a6b483b03ffddbe5baedd6b2326afcdef Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/57769 Tested-by: Hudson CI
2015-09-30Fix NPE due to refresh occuring while a container is being removed.Roland Grunberg3-1/+5
container.names() seems to be null for a container whose state is 'Removal In Progress', so do not include these containers in any lists. Change-Id: I9f75536ad89e7c25b9fc905ffd802840b1e3132f Reviewed-on: https://git.eclipse.org/r/57123 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-29Continue to respect JavaSE-1.7 for core and ui bundles.Roland Grunberg1-2/+1
Change-Id: Ie4ea86e1731ac0bc360db8c9282fb003144e19a6 Reviewed-on: https://git.eclipse.org/r/56959 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-28Bug 471668: Support Docker Machine Connections.Roland Grunberg1-0/+74
Change-Id: I61bcf2a4134506361b62ec0a1c9bc5712d4787d8 Reviewed-on: https://git.eclipse.org/r/56262 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-15Bug 477485: Work around socket read timeout in docker-client for logs.Roland Grunberg1-1/+9
This is closely related to 67a20d (Bug 469717) but resolves the same issue for the stream returned by logs(). Change-Id: I5a4519d666238afe8584f7980bfc7a180a0569be Reviewed-on: https://git.eclipse.org/r/56004 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2015-09-09Bug 476870: Add support for Java 9 attaching to container under https.Roland Grunberg1-16/+32
The internal SSLSocketImpl field in sun.security.ssl.AppInputStream has changed from 'c' to 'socket' in Java 9. Also mark all strings as non-translatable. Change-Id: Ic371ba1ffa37e069f3d00e60d30190be01f7027a Reviewed-on: https://git.eclipse.org/r/55500 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-08Bug 475881 - Pull image workflow improvementXavier Coulon1-0/+1
Restored the PullImage wizard as the first step when pulling an image. The "Search..." buttons opens the SearchImage dialog with search term prefilled from the current image name. If no tag is specified, then 'latest' is assumed. The validation only raises warnings to avoid preventing the user to attempt to pull an image ( the Docker daemon may eventually raise an error). Added some JUnit tests to validate the image name patterns Change-Id: I7b7fef9e8ed9bbbc7701880af44a4e9f412a1543 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/55098 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-04Bug 475504 - Creating a connection with the same name resultsXavier Coulon1-4/+6
...in duplicate entries in combo boxes Added validation to prevent empty and duplicate connection name in the "New Connection" wizard. Reverted the order in which widgets are enabled to set focus on first enabled text field (when applicable) Change-Id: Ia8d6e3465048c8959832ba21c76a2b4a487659d8 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/55221 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-03Bug 468966 - New Connection Wizard fails when no settings are detectedXavier Coulon1-23/+45
Refactored the wizard page to use Databinding and to validate connection settings input: - the unix socket exists and is readable/writable - the TCP connection scheme is "tcp", "http" or "https" - the TCP connection host and port are valid - the path to certificates exists and is readable (those values are validated according to the connection mode) - automatically insert a "unix://" prefix (scheme) in the "Unix Socket" field when the user selects a file from the FileDialog Change-Id: I193461394f906119f00125ba982aedd942ebd1b8 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/49107 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-09-02docker: Unbreak build.Alexander Kurtakov3-2/+5
Rename some params and add TODO for fixing docs in other places. Enable even stricter compiler warnings to prevent breaking builds. Change-Id: I7c725fb75cd7e3a7092bcf7dd3c82442cd6d6f3d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/55057 Tested-by: Hudson CI
2015-09-01Bug 470577 - Docker Explorer does not show the latest image id after an ↵Xavier Coulon4-8/+20
image build DockerExplorerView is now properly registered as a listener. Change-Id: I4a8c5a597f5c13c861613c45a413f4d669bccabb Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/54882 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
2015-08-20Bug 475501 - Auto-update connection detection script in data directoryXavier Coulon1-1/+4
Comparing the script 'lastModified' with the bundle's lastModified when the script exists. Change-Id: I80e4c51ec67744f3dfed392fe280fdcdcb962d12 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/54241 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2015-08-20docker: Fix build.Alexander Kurtakov2-4/+3
Java 8 javadoc is really strict so malformed javadocs break the nightly builds. Make the javadoc problems error in the IDE too to make it obvious. Change-Id: Ie64f5ec2cfc564942b2fc02f0d115a82c597b7ea Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/54183 Tested-by: Hudson CI
2015-08-19Bug 474606 - Allow for search and pull images from the Docker Explorer viewXavier Coulon10-40/+282
Added a view in page in the SearchImage wizard to specify the image tag to pull: - the list of image tags is retrieved from a new class called DockerHubRegistry (in the core module) - the DockerHubRegistry#getTags(String) sends an HTTP request to list the tags for a given repository on Docker Hub, using a specific/known endpoint. This is not part of the docker-client because the Docker client deals with CLI commands on the Docker daemon/engine and this operation is out of scope. This might need to be refactored/opened in the future, when support for third-party registries will be implemented. - Pull image command is available at the connection level in the Docker Explorer view, too. Other bits in this commit: - refactored the DVMessages class to support varargs instead of an array of arguments, which makes the API more convenient to use - removed unused classes - reformatted blocks of code badly indented - removed author name in some classes/added copyright where found missing Change-Id: I83c086c4aa8a8e73c3364a885cefcdb2d36cb7f8 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/53481 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>

Back to the top