Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-09-14Bug 500969 - Duplicate registry info in combo after changing settingsv5.1.0stable-5.1Xavier Coulon3-3/+7
Using a ocal copy of the registry accounts instead of the same list to avoid adding the new registry account twice (once upon dialog completion, once upon preference page completion) Change-Id: I551354cd4c6416cad992a2e9d9bf047f2aff79b1 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80831 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit b821b51f9674b37ff3422c0fda8e524f45fe2d18) Reviewed-on: https://git.eclipse.org/r/81124
2016-09-13Remove SNAPSHOT from pom parent versions.Jeff Johnston155-159/+183
Change-Id: I70a983e9f0a4ff0dd004d3df973fec85a483bd8e Reviewed-on: https://git.eclipse.org/r/81039 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-13Update Docker docs to match wiki page for Neon.1 release.Jeff Johnston12-45/+160
Change-Id: I31f0aa168fddb442280c8e4bf0926328c9e6792b Reviewed-on: https://git.eclipse.org/r/81026 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 876d2373e8171777f5ef96f71f702ec1cbe83b37) Reviewed-on: https://git.eclipse.org/r/81030
2016-09-12Bug 501207 - SWTException below ImageSearchPage$IconColumnLabelProvider.measureXavier Coulon1-3/+5
Make sure ICON is not disposed. Change-Id: I95c523848a55b99f7c4f6b29660256abc1b57e48 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80893 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit f3a540aec115c87754dc03fce7676a43c2701ea8) Reviewed-on: https://git.eclipse.org/r/80935
2016-09-12Bug 489111 - NoStackTrace in DockerConnection$LogThread.executeXavier Coulon4-14/+40
Marked Activator#logErrorMessage(String) as deprecated and replaced all calls to Activator#logErrorMessage(String, Throwable) to log a proper stacktrace. Change-Id: I5722c96b5fa2657e560f016f42dba25c654729f2 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80896 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit f1b44a7d70e91d68618d7a58eff0026275e2da80) Reviewed-on: https://git.eclipse.org/r/80938
2016-09-09Bug 501175 - Build and Pull Image buttons enabled/disabled improperlyJeff Johnston4-6/+72
- fix DockerImagesView and DockerContainersView to set the connection for the DockerConnectionWatcher based on the DockerExplorerView selection - change the ConnectionPropertyTester to use the DockerConnectionWatcher when given an empty list (i.e. no selected object) - modify the DockerImagesViewSWTBotTest to verify the Build and Pull toolbar icons are enabled/disabled properly when no Image is selected and when no Connection is selected Change-Id: I858527f0340d42343dc53f88765bc1d8b425ed3d Reviewed-on: https://git.eclipse.org/r/80847 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 30dad6c59ffa2f7569f4f419291fc1723247ae07) Reviewed-on: https://git.eclipse.org/r/80854
2016-09-09Fix update mirrors for Neon.1 release.Jeff Johnston1-2/+2
Change-Id: I31f2bd098789a6f28817628d5f15a71c6855a0da Reviewed-on: https://git.eclipse.org/r/80742 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-08Change all p2.inf files to point to update and update-docker as appropriate.Jeff Johnston23-46/+46
Change-Id: Ib973da77cb1b810738e6fe9c3fefae95ee0d22c3 Reviewed-on: https://git.eclipse.org/r/80732 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-07Bug 501025 - Filter by label menu item has improper nameJeff Johnston1-4/+5
- fix menu label Change-Id: Iab662e62134d67497cf0832f88e339b362254876 Reviewed-on: https://git.eclipse.org/r/80628 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-07Bug 500973 - Push image to local registry failsXavier Coulon5-13/+91
The problem came from the concatenation of ':' with the port number which resulted in 'localhost5058' instead of 'localhost:5000' because the ':' was interpreted as a number and not a Character (':' is 58 in the ASCII table) Added a JUnit test and improved SWTBot tests. Change-Id: I466405fd172647e81ca64fb4a12df7bdac45046d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80572 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit b3c3184784192846d4864bd8c6b9da21c3d1665f) Reviewed-on: https://git.eclipse.org/r/80619
2016-09-07Bug 500446: fix gprof parsing of PPC64 LE objectsWainer dos Santos Moschetta2-1/+5
On PowerPC64 LE (Little Endian) platform, gprof was evoking PPC64ElfBinaryObjectWrapper to handle binary' symbols. However, PPC64ElfBinaryObjectWrapper is designed to handle BE (Big Endian) objects only. Change-Id: Idd7549b0ff4775497b45413b5be89d11088baf36 Signed-off-by: Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> Reviewed-on: https://git.eclipse.org/r/80529 Tested-by: Hudson CI (cherry picked from commit da3996e7af35e685a0c7f465b3b699fcfbb9d608) Reviewed-on: https://git.eclipse.org/r/80608 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-06Bug 500910 - Wrong message when adding duplicate TCP connectionJeff Johnston1-1/+1
- fix message in NewDockerConnection wizard Change-Id: Ic9f35f88ed20b97d85ff8d3dc45d6168110e8198 Reviewed-on: https://git.eclipse.org/r/80545 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-06Update Docker docs for Linux Tools 5.1.0 release.Jeff Johnston8-9/+55
Change-Id: I7e0374222953156e31e5fcde48b3ad17527e8748 Reviewed-on: https://git.eclipse.org/r/80538 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-06Bug 500737 - NullPointerException in DockerConnection.pullImageJeff Johnston3-3/+22
- fix DockerContainer and DockerImage to be IAdaptable to IDockerConnection - fix build image to also look for established connection Change-Id: Ifcbd5274ff1d0d5425648521205f8b26992ede74 Reviewed-on: https://git.eclipse.org/r/80531 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-06Bug 500638 - Properties do not show information about selected ↵Xavier Coulon11-28/+147
image/container in respective tab Fixed the value returned by 'getContributorId()' in DockerImagesView and DockerContainersView to re-enable linking selection with properties view (was a regression introduced in fix for bug 499750 (Add commands in Image Hierarchy view). Added tests to verify that the properties view displays the expected tab upon selection in DockerExplorerView, DockerContainersView, DockerImagesView and DockerImageHierarchyView. Change-Id: I61038304c86b2dda02c46728d69e5dd351d8dcf9 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80221 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 6123758e8fe9741f62edcf1734c3e8dad033be8f) Reviewed-on: https://git.eclipse.org/r/80524
2016-09-06Bug 500737 - NullPointerException in DockerConnection.pullImageXavier Coulon7-17/+190
Disable the 'Pull Image...' command handler when the connection is not established. Change-Id: I3e9a2d85000ebd865bf42f43a778418449308b1d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80315 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 3c0aec37ce80a0e7ca2790d6e8bd5510ae551000) Reviewed-on: https://git.eclipse.org/r/80512
2016-09-02Bug 499843 - Pull Image wizard pulls all images if tag is not specifiedXavier Coulon4-14/+61
Adding the ":latest" tag to the image name if it was missing. Refactored the ImageNameValidator class to provide a utility method that can be called out of the validation context Renamed the ImagePullPatternTest to ImageNameValidatorTest since the class under test is ImageNameValidator Change-Id: I5edced116cf6d03bc6ab761f1d89e3552eef61b3 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/80288 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit f3bf52148d6dcc5acf70b6c2e16605e7d4e365bd) Reviewed-on: https://git.eclipse.org/r/80342
2016-09-02Revert "Temporary patch to get gerrit working and not reference hudson"Jeff Johnston1-1/+1
This reverts commit f88e7ed7dc57124bf3131ee6c37147c159b51b2a. Change-Id: I0d6d2b9a82d0c5d33641bffee6d5fabef74e9b99 Reviewed-on: https://git.eclipse.org/r/80178 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-09-02Fix problem with GcovTestsJeff Johnston2-15/+26
- fix AbstractTest create and build method to wait until at least one binary appears - fix GcovTest to wait until gcda file is created Change-Id: Ia04f57f4a85175b8410c2ab85c8e8204b7a5dbd6 Reviewed-on: https://git.eclipse.org/r/80242 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 9e540f2ba0682cc0cbe0af272e89f9d8abf68cf9) Reviewed-on: https://git.eclipse.org/r/80274
2016-08-31Bug 499607 - Add restart option to container context menuJeff Johnston13-19/+306
- add new restartContainer method that accepts an output stream for logging purposes to DockerConnection - add new RestartContainersCommandHandler class to do a restart - add new restart wait time preference to Docker preference page - add restart to context menus for Docker Explorer view, Docker Containers view, and Docker Hierarchy view - add new tests to Docker Explorer and Docker Containers SWTBot tests Change-Id: I0409666f9cf7b126b97115c68eec938f41b33210 Reviewed-on: https://git.eclipse.org/r/79891 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-30Temporary patch to get gerrit working and not reference hudsonJeff Johnston1-1/+1
Change-Id: I04301f072e00741cc0342a0eea92902645b40e01 Reviewed-on: https://git.eclipse.org/r/80081 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-29Bug 383516 - --show-possibly-lost=no missing from memcheck command lineJeff Johnston16-76/+146
- change default value for --show-possibly-lost to be true - update memcheck documentation regarding this option plus other missing options Change-Id: I1b51e831c399cfdc085fe103575df74943f4d7b5 Reviewed-on: https://git.eclipse.org/r/79973 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit e695284dd704b8da45459270cf4bcaad9835872b) Reviewed-on: https://git.eclipse.org/r/79976
2016-08-26Bug 500158 - Add context menu to open Hierarchy view in Containers and ↵Xavier Coulon9-17/+143
Images views Added context menu when selecting an image or a container in the Docker Images and Docker Containers view Added tests to verify that the Docker Image Hierarchy view is opened when calling the command from the context menu Change-Id: I69238475af5a420357fcbcae0ad7a376b06260e6 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79723 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 2f5471f0d63eacff01143b927b76c1013ab4e562) Reviewed-on: https://git.eclipse.org/r/79880
2016-08-26Bug 499854 - Connection is not added(same parameters, different name)Xavier Coulon4-25/+170
Refactored the validators in the NewDockerConnectionPage by adding a search for connection with the same Unix/TCP settings when the name is changed. The page cannot complete if the user gives a new name for a connection with known Unix socket path or TCP host. Added SWTBot tests. Change-Id: I99a4987c8c2c4c80aeffc58085ac1e7c94df50c9 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79747 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit f107e191a5cbe83dccc25172d74676b325bfbcc7) Reviewed-on: https://git.eclipse.org/r/79872
2016-08-26Bug 500159 - Change or remove the message in the Hierarchy view when no ↵Xavier Coulon2-2/+2
element was selected Replaced the confusing message with a new one inspired from the Java Type Hierarchy view. Change-Id: I5576c098e3e4d7db94fac7a034d2decee42a5c03 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79699 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 8317f7bf77a6cda4a2ae1773d1adea05cc6a1ff7) Reviewed-on: https://git.eclipse.org/r/79868
2016-08-26Bug 499954 - Container with TTY doesn't display log or remove logsJeff Johnston1-11/+9
- for terminals, always wait for container to be running or else finished Change-Id: I26a46657bf635e318b1fa0a35275dd0b78ccfd8b Reviewed-on: https://git.eclipse.org/r/79670 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit b9acdde66cb6a6385264bb9392410f46851880fa) Reviewed-on: https://git.eclipse.org/r/79779
2016-08-26Bug 500298 - No property tester contributes a property ↵Xavier Coulon1-1/+4
o.e.l.docker.dockerComposePropertyTester Full error message was: "No property tester contributes a property org.eclipse.linuxtools.docker.dockerComposePropertyTester.isDockerComposeConsole to type class org.eclipse.debug.internal.ui.views.console.ProcessConsole" Changed the 'type' in the propertyTester definition to accept any kind of console. Then the type checking can be performed in the corresponding class, whatever the type of console that was given. Change-Id: I73182a531891ace823abccb20cfca413a7a93a0c Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79774 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit c6acd9b9ec0b25f190c0030310ffb43e46e892c5) Reviewed-on: https://git.eclipse.org/r/79842
2016-08-25Bug 499750 - Add commands in Image Hierarchy viewXavier Coulon38-467/+1407
Added commands on containers in Hierarchy view Introduced 2 new sub-interfaces to IDockerImageHierarchyNode to distinguish between IDockerImages and IDockerContainers NOTE: as a side effect to adding commands to the containers, some command (STOP, START) that would work on multiple containers now require that all containers be in a valid state to be enabled. Simplified the code of utility methods in LabelProviderUtils class that provide StyledString Splitted clipboard tests in NewDockerConnectionSWTBotTest to test separately DND.CLIPBOARD and DND.SELECTION_CLIPBOARD. The later only seems to be a valid case on Linux, so the test is disabled on other platforms. Change-Id: I3da20e4184918b09b73a5808b84cd541b5f7bdeb Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79650 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit c726c9fd1dfa2f92f36df1a799f7443add95a197) Reviewed-on: https://git.eclipse.org/r/79768
2016-08-25Fix update sites for stable-5.1 branch.Jeff Johnston4-7/+7
Change-Id: I0707d03986da1e31ffcb4524c1b6a62533a7799a Reviewed-on: https://git.eclipse.org/r/79769 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-25Fix vagrant pom filesJeff Johnston9-11/+11
- update vagrant feature to 2.1.0 - update vagrant parent id to 2.1.0 - update vagrant doc plugin to 2.0.0 (as was in stable-5.0) - also remove org.eclipse.tm.terminal.view.ui from Docker UI Change-Id: Ic59ef3c46e27d7468dcfde6be53a094044a774a6 Reviewed-on: https://git.eclipse.org/r/79756 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-25Bug 497027 - Man page plugin forces install of CDTAlexander Kurtakov5-13/+65
Code from LinuxtoolsProcessFactory class copied and simplified as some features are not needed to remove the dep. Practically this is pure JSch implementation. Change-Id: Ie25d5bd5243c0ca571ce51a83eafd25d85884178 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/79720 Reviewed-by: Mat Booth <mat.booth@redhat.com> Tested-by: Hudson CI (cherry picked from commit b4b9c1eeebda569580a4dcc470a2f3ebbfe0285d) Reviewed-on: https://git.eclipse.org/r/79726
2016-08-23Bug 499954 - Container with TTY doesn't display log or remove logsJeff Johnston5-11/+43
- add [shell] to title for exec shells for a Container - add code to RemoveContainerLogHandler to handle terminals using closeTerminal - add org.eclipse.tm.terminal.view.core as Docker ui dependency - fix RunConsole.attachTerminal and RunConsole.attachConsole so that the wait for running loop doesn't run infinitely if the Container is already finished - add LOG_PTY as data for openTerminal properties - fix a regression in the Command column in Docker Containers view Change-Id: Ia1bbce9e88e87903a3c9eb1c4d6f200f3f42e70d Change-Id: Ia1bbce9e88e87903a3c9eb1c4d6f200f3f42e70d Reviewed-on: https://git.eclipse.org/r/79309 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-23docker: Cleanups.Alexander Kurtakov7-27/+14
* Remove useless throws. * Remove useless suppress warnings. Change-Id: I4f8715764f55a2246d5cfaf566a2e39235930d35 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/79559 Tested-by: Hudson CI
2016-08-23Bug 499749 - Include Docker containers in Hierarchy viewXavier Coulon25-462/+995
The Image hierarchy view now displays the containers based on an image. From a selected image or container, the hierarchy view shows the path to the root image and all descending images and containers (but for the parent images, only the path to the selected element will be shown) Moved the logic to build the hierarchy view in a utility class (DockerImageHierarchyNodeUtils) Added a MenuAssertion class to the SWTBot tests Change-Id: Icceb228f7947166bf6a6dec864bfbeaf68dc8d26 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79490 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-23Bug 479592 - Support for Docker ComposeXavier Coulon101-732/+3866
Also added a 'DockerConnectionManager#getAllConnections()' method that returns a list (can be empty) to use Java 8 Streams API Also added a 'DockerConnectionManager#hasConnections()' to verify if there's any connection (avoids checking for null and size > 0) Refactored the BuildDockerImageJob by extracting common methods in a superclass. Change-Id: I2517c8db139f91ac08ee1db9fbc0a47de7a08d74 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79345 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-22Bug 499839 - Enable multiple image deletion in Docker ExplorerXavier Coulon2-25/+77
Added SWTBot test to verify that the remove command is enabled/visible when multiple images are selected. Added a custom MenuAssertion utility class. Change-Id: I2ed23e4e27f73613b063d191c79f1a834f577dcb Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79412 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-21releng: Tycho and target updates.Alexander Kurtakov2-6/+6
* Move to Tycho 0.26. * Move away from Neon milestone sites to release. Change-Id: Ic0d0e9d5b06f732aef4e919db0043d74789f931b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/79405 Tested-by: Hudson CI
2016-08-20Bug 471673: Support populating connection wizard with clipboard data.Roland Grunberg2-1/+105
Change-Id: I15a06eee1e1673cd0f1f193b96b1772b41660819 Reviewed-on: https://git.eclipse.org/r/79296 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-08-19docker: Call static methods directly.Alexander Kurtakov1-4/+5
Fixes few warnings in the workspace. Change-Id: I71c06021cee4c13a4aea9ee603e9cb23e3d43ead Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/79342 Tested-by: Hudson CI
2016-08-18Bug 499839: Enable multiple image removal from Docker Explorer View.Roland Grunberg1-3/+0
Change-Id: Iee3583333a26d730f55be26091003e332b0bf9ff Reviewed-on: https://git.eclipse.org/r/79264 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-08-17Bug 499745 - Docker Explorer broken on WindowsXavier Coulon1-6/+6
Prevent IOOBE when there was no connection settings available. Change-Id: Ib9567222b2801fa6d7e0084ecbc26b0b2cfe0f2d Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79186 Tested-by: Hudson CI
2016-08-16Bug 499744 - New connection created with wizard does not appear in the ↵Xavier Coulon4-30/+62
Docker Explorer view Change-Id: Id0d7f4ed36ee1b78d9e3782e4a4292a70de7060f Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/79147 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Hudson CI
2016-08-16Bug 499745: Guard against bad return values in connection framework.Roland Grunberg7-24/+33
The connection settings framework expects a null return value when no connection settings could be provided. However it is possible to return a list of values with some potentially being null. We should ensure our providers don't do this and guard against this happening from extensions we don't control. Change-Id: Ib9473f8af075b1a811ed9a48b1bb63337b29ac21 Reviewed-on: https://git.eclipse.org/r/79130 Tested-by: Hudson CI Reviewed-by: Xavier Coulon <xcoulon@redhat.com>
2016-08-13Bug 496922 - Improvements on the 'push image' dialogXavier Coulon47-483/+1678
Refactored the ImagePushPage to use JFace databinding Replaced button with link to open Registry account prefs Added options to tag with 'force' flag and to keep the tagged image upon completion. Refactored ImagePushPage and ImagePullPage to use the same base WizardPage to share the UI part that provides the registry selection and addition. Added SWTBot tests, refactored RegistryAccountManager by introducing a RegistryAccountStorageManager that can be replaced during tests. Changed the validation in the RegistryDialog to allow for null username/password since this should not be a requirement for pulling images (eg: DockerHub or other public registries) Checks the name of the image before tagging. Checks if the selected registry provides auth before pushing. Display push progress handlers in the Progress view only. Change-Id: I682b2cdace11c7124be691186ed31ea41741e2ba Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/76610 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-12Bug 495251 - Expose the ImagePushProgressHandler in the API packagesJeff Johnston12-71/+184
- move ImageBuildProgressHandler, ImagePullProgressHandler, ImagePushProgressHandler, and ProgressJob from docker ui to internal docker core package - add 3 new methods to IDockerConnection - getDefaultBuildImageProgressHandler - getDefaultPullImageProgressHandler - getDefaultPushImageProgressHandler - implement said methods in DockerConnection - move messages to core as needed Change-Id: Iefc4743358e0ab47c9aa687d84beef8dcc501eed Reviewed-on: https://git.eclipse.org/r/78903 Tested-by: Hudson CI Reviewed-by: Xavier Coulon <xcoulon@redhat.com>
2016-08-10Bug 499462 - Oxygen M1 is failingJeff Johnston1-0/+9
- add missing dependencies javax.xml, org.apache.xml.resolver, and org.apache.xml.serializer uis Change-Id: I53f906e0eb0e39069cbf5dd602bfe6a93310ae1c Reviewed-on: https://git.eclipse.org/r/78788 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-10Bug 487035 - Docker host ip cannot be copied to clipboard from anywhereJeff Johnston13-14/+334
- add Connection Settings tab to Connection properties - enhance IDockerConnectionSettings with getProperties() method - update TCPConnectionSettings and UnixSocketConnectionSettings classes to provide their properties - add ConnectionSettingsPropertySection - add ConnectionSettingsContentProvider class which queries a connections settings for its property values - add a CopyValueAction class to copy a property value from Docker property views (BasePropertySection) - add to existing tests to verify that properties are returned from IDockerConnectionSettings and that Copy is available in the Properties view context menu Change-Id: Ia3bd1198bb178c531e759d020240db2d05dc9e17 Reviewed-on: https://git.eclipse.org/r/78653 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-05Bug 499121 - Docker Containers and Images View empty at startupJeff Johnston5-4/+59
- add check at end of createControl to see if there is a selection in the Docker Explorer view and use it to set the connection for the Containers and Images view - add SWTBot testing for Images view and Containers view being filled in by default Change-Id: Id66dcc81893db83e5bf53fad9c6f579a903fd5dd Reviewed-on: https://git.eclipse.org/r/78505 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-04Bug 496308 - Docker Hierarchy viewXavier Coulon28-102/+921
Initial proposal for the hierarchy view Further commits may include context menu and even containers based on the selected image. Change-Id: Ic9ca000ea5b5969b5527e4bf4128a6c55df305e8 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/78177 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-08-03Bug 499131 - NullPointerException below ManParser.getRawManPageJeff Johnston1-5/+8
- add check for getManPage() returning null in getRawManPage() try statement Change-Id: I75e63b628d10a7f1f05bd70ec99e52ae437aa66e Reviewed-on: https://git.eclipse.org/r/78414 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>

Back to the top