Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-06-21Bug 496432: static ICON reference should not be disposed.stable-5.0Roland Grunberg1-1/+0
The static ICON reference in IconColumnLabelProvider is used for all icon measurement and rendering. If it's disposed by any specific instance, it will be unusable going forward. Since only one instance should exist for the entire runtime, it should be safe to leave it. Change-Id: Id3d947138bb3de737d33b0af46fef8524f92570a Reviewed-on: https://git.eclipse.org/r/75587 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 05d5e4706558aa3a408621023b26cef601c01578) Reviewed-on: https://git.eclipse.org/r/75646 Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-06-10Bug 495840 - Memory leak if Docker Views left open for long periodv5.0.0bJeff Johnston7-23/+101
- additional fixes where images are not being disposed of properly in Docker Change-Id: I06ae37c7ebd21217ca70cc8d1b1b081b55b9df95 Reviewed-on: https://git.eclipse.org/r/75088 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-06-10Bug 495840 - Memory leak occurs if Docker Views left open for long periodJeff Johnston1-6/+13
- fix memory leak in Containers View regarding status images - reuse Images for states and dispose in Containers View dispose method Change-Id: I82bb32063d3a8a693f19962a6e7ec0eef2fa3974 Reviewed-on: https://git.eclipse.org/r/75033 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/75077
2016-06-07Update Docker docs for Neon release.v5.0.0Jeff Johnston16-37/+91
Change-Id: Ibc5f339eaad1c803179bf5e85bd56879d4d44bbf Reviewed-on: https://git.eclipse.org/r/74815 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-06-07Update the p2.inf files for Neon release.Jeff Johnston23-46/+46
Change-Id: Iac73ea80918e66fb07f7bd6a39276c653c458541 Reviewed-on: https://git.eclipse.org/r/74730 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-06-06Update poms to remove SNAPSHOT from parent poms.Jeff Johnston154-158/+183
Change-Id: Ib06604bb382320f61a283e82053dda6a9a34fc27 Reviewed-on: https://git.eclipse.org/r/74727 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-06-06Bug 495517 - NullPointerException in ↵Xavier Coulon1-1/+5
ContainerDataVolumeDialog.setOkButtonEnabled Testing against 'null' for the OK button. This could happen when the dialog is not fully initialized (?) Change-Id: I4bda14fecbc2fc2f7591a9a961a78e744d984aff Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74626 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit d020f7984934947fb7f7c4a84b5651af7c86d533) Reviewed-on: https://git.eclipse.org/r/74708
2016-06-06Bug 495546 - Improve error messages in DockerMachineXavier Coulon3-38/+60
Improve the error messages for better diagnostic in case of failure. Also closing the input/error streams in the try-with-resources statements Change-Id: I22de99c01ae529c4bf0323ec5a7c6ae885ce1edb Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74684 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 63def0904ea5e058ae3c1331db815b3908c50f05) Reviewed-on: https://git.eclipse.org/r/74694
2016-06-06Bug 495518 - SWTException below ContainerDataVolumeDialog$7$1.runXavier Coulon1-2/+3
Checking if the dialog's shell was disposed before validating and updating the controls Change-Id: I225183148bfae7e2289f99bdac835d2f4111d7f1 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74631 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 9e9872d3fdcbc8e0ee3f2544ef687d5b7eef597b) Reviewed-on: https://git.eclipse.org/r/74686
2016-06-03Bug 495070: Use a better key value for password mappings.Roland Grunberg2-10/+12
None of the combined fields that form the key can contain a ',' so it should be safe to use as a delimeter without resorting to hashing the full set of values. Change-Id: I9e5209658e69fc7fdf3e074108a3787dd5af5bdb Reviewed-on: https://git.eclipse.org/r/74253 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> (cherry picked from commit 146087222ac3db744ca9537e5e72fc7c2a3d8add) Reviewed-on: https://git.eclipse.org/r/74468
2016-06-02Bug 495075: Don't force re-typing password on registry account changes.Roland Grunberg2-6/+9
Attempting to modify the registry account brought up the old values (server name, user name, email), but set the password empty so that users would have to re-type it to confirm identity. Since the secure storage framework authenticates the user anyways, the password should be populated like everything else. Change-Id: I748b349b28f988356759b85d2052dde61369841c Reviewed-on: https://git.eclipse.org/r/74265 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit e5cc77960c4dd16b56ce767d6b2a2d154c945985) Reviewed-on: https://git.eclipse.org/r/74473
2016-06-02Bug 495293: Fix IOOBE occuring due to empty list of raw image repoTags.Roland Grunberg1-8/+8
Even if rawImage.repoTags() is not null, it may still be empty, triggering the IOOBE later on at repoTags.get(0). Images with no repoTags were showing up in views because only images with repoTags of ["<none>:<none>"] were being recognized as untagged. Fix this by moving boolean definitions for taggedImage, intermediateImage and danglingImage so that they may be evaluated after we've adjusted repoTags. Change-Id: Iec5f8dfcf3252bffdcb0eec7789dbf4a5950b3d7 Reviewed-on: https://git.eclipse.org/r/74399 Reviewed-by: Fred Bricon <fbricon@gmail.com> Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> (cherry picked from commit 6e3da56d6cfa0fd73f07344139322b1d6f3a1417) Reviewed-on: https://git.eclipse.org/r/74465
2016-06-01Bug 495074: Set the title for dialog that adds/edits registry accounts.Roland Grunberg1-1/+8
The parent shell (Preferences dialog) was having its title overriden with the registry account dialog's expected title. Change the actual dialog title by overriding configureShell. Change-Id: I95cea1391658999809f3f2a68dd1750b10289818 Reviewed-on: https://git.eclipse.org/r/74259 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit e8f64be12b7fa7a2e5bd03290054726c172bae24) Reviewed-on: https://git.eclipse.org/r/74276 Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-06-01Bug 495198 - NPE after enabling disabled connectionJeff Johnston1-1/+2
- initialize containersById to empty collection Change-Id: I33aa9836f586ec91f14bce3f733ba883aabcb4d4 Reviewed-on: https://git.eclipse.org/r/74270 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-06-01Bug 494555: Quote command arguments when entrypoint is not defined.Roland Grunberg3-8/+15
By default the entrypoint should be '/bin/sh -c' so the arguments to this should be quoted to work correctly. If this is done in the setCommand method of the Image Run model, then we just need to ensure that entrypoints are set before setCommand is called. Change-Id: Iacec3a8557cec5dc1118244328ddac1003e6a801 Reviewed-on: https://git.eclipse.org/r/74098 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 3ae78b60e4481422318546a2bd5f832d86726c4b) Reviewed-on: https://git.eclipse.org/r/74154
2016-06-01Bug 495073: Image name validator doesn't accept repos with multiple /Jeff Johnston3-9/+9
- change regex rule in DockerImage Change-Id: Icf930c7170c42399884bbdfa080f17fd42e5521f Reviewed-on: https://git.eclipse.org/r/74125 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 2c14d05584442b5cd00108276287dfc2c74f251d) Reviewed-on: https://git.eclipse.org/r/74153
2016-06-01Bug 494871 - DockerException in DockerConnection.listContainersXavier Coulon3-1/+17
Closing the connection when a DockerTimeoutException occurs when retrieving the list of images of the list of containers. Change-Id: Icfd736739a161ea7d851a84a1e04db98dc379acd Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74124 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-31Bug 493752 - Docker Machine preferences page causes all other Docker ↵Xavier Coulon1-15/+26
preference pages to be invalid Preference page is now valid if path to Docker Machine and VM driver are empty. If the Docker Machine directory is valid but does not contain the expected 'docker-machine' executable, a warning is displayed. If the directory paths are invalid, an error is displayed. Change-Id: I489fe188540f47328e030e0b228e48ef938bc9f6 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74121 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 0eb102607073159b42c36893b9df80266af59c5b) Reviewed-on: https://git.eclipse.org/r/74136
2016-05-31Bug 471670 - better support cases where the Docker connection is lostXavier Coulon31-623/+813
Refactoring the DockerConnection to handle 3 states: - unknown (connection was not opened) - established (connection was opened and Docker responded to ping) - closed Connections are in UNKNOWN state by default, and opened when node is expanded in Explorer view or list of containers or images is loaded. Connection is set back to UNKNOWN state when the settings are changed. Change-Id: I469fbe9df711a1539d5407bcae02ad1e1cde6340 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74102 Tested-by: Hudson CI
2016-05-31Bug 494770: [compatibility] docker 1.10.x image IDs have digest prefixJeff Johnston3-3/+7
- fixed DockerImagesView to remove any sha256: prefix - fixed Image property providers to not truncate any image id Change-Id: Id5b46d819f9c583a37f5c5c26a301fe29900d2e9 Reviewed-on: https://git.eclipse.org/r/74112 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-31Bug 494872 - NullPointerException in DockerImagesContentProvider.getElementsXavier Coulon1-1/+8
PRevent NPE when IDockerConnection#getImages() returns null Change-Id: Ice13e5f47d56f9bfc57b8831b59917c87e19f3fe Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/74107 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/74113
2016-05-31Bug 494926: ArrayIndexOutOfBoundsException in RunImageMainTabJeff Johnston11-27/+83
- change CommandUtils.getCurrentConnection to fall back to first active connection (not just first connection) - have DockerImagesView and DockerContainersView use CommandUtils to get the default connection (i.e. first active connection) - add checks in RunImageMainTab to look for no active connection and set an error message if that is the case - add similar checks in RunImageVolumesTab, RunImageResourceTab, and RunImageEnvironmentTab - use CommandUtils for default connection in RunImageLaunchConfigurationTabGroup - add new Wizard message for inactive connection Change-Id: I38d9bf506aa253ab5b9eb87a48975ed49d04a410 Reviewed-on: https://git.eclipse.org/r/74101 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-30Update CDT source in Linux Tools Neon target.Jeff Johnston1-1/+1
Change-Id: I55bb986555e85cd2f46a8de3c3d2ee3b22843af0 Reviewed-on: https://git.eclipse.org/r/73990 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-30Bug 494305 - Docker Machine lookup does not work on Windows machinesXavier Coulon1-3/+14
Using 'docker-machine.exe' on Windows, 'docker-machine' on other OSes. Moved the SystemUtils class into the 'core' bundle to reuse the `SystemUtils#isWindows()` method. Change-Id: I5b9a112567f707fc45754ab56b9258571c977195 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/73567 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 4b098069ef20b17d8a63c94e6e5abbe74d48b9fc) Reviewed-on: https://git.eclipse.org/r/73960
2016-05-27Bug 494513 - Build image function of Docker Tooling shows no message on consoleXavier Coulon3-21/+13
Using the BuildImageJob to build the image. This job already takes care of sending the output logs into the Console View. Change-Id: I4cead2763790dcaf32848cd514eacef466787233 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/73822 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-27Refresh images view after removing temporary image.Roland Grunberg1-0/+1
When pushing some image 'baz' to registry 'foo.bar:5000', we tag an image temporarily as 'foo.bar:5000/baz' to facilitate the push. At the very end this tag is removed, so the images view should be refreshed so the image doesn't incorrectly show up until a manual refresh. Related: Bug 471661 Change-Id: Ied3474a9810af0641d53b6b23911d5d08916733e Reviewed-on: https://git.eclipse.org/r/73751 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit a17a0c6bc2d6d1405a1aa66d56491201e30eb9a4) Reviewed-on: https://git.eclipse.org/r/73848
2016-05-27Bug 494776: Don't set auth credentials for daemon's default registry.Roland Grunberg1-6/+0
When no registry account has been set, commands are expected to run against the Docker daemon's default registry in an unauthenticated manner. This removes support for matching the daemon's default registry with the first auth entry in any 'config.json' file that's discovered. Change-Id: I85cd97b5855bab9938ed85a139c118836dfee56b Reviewed-on: https://git.eclipse.org/r/73836 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 90190677e4cc4377ed2e8d3b0cf086c971a49a66) Reviewed-on: https://git.eclipse.org/r/73847
2016-05-27Bug 494521 - NPE when New Docker Connection dialog is open on WindowsXavier Coulon4-8/+36
Prevent returning connection settings when the DOCKER_HOST environment variable was not found. On environments where Docker Toolbox was installed, there might not be any DOCKER_HOST, etc. env variables set, but there is a 'DOCKER_TOOLBOX_INSTALL_PATH' env var, which means that the exit code of the script is '0' and from there, the 'createDockerConnectionSettings' is called. This method noew returns 'null' if the DOCKER_HOST property is missing. Change-Id: Ia19b31782fcd714b9c6549b01801129f5295936f Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/73588 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 3c33ab2331bc382026c80162e95195931e16bfb8) Reviewed-on: https://git.eclipse.org/r/73845
2016-05-27Fix logic for CommandUtils getCurrentConnectionJeff Johnston1-41/+7
- previous fix missed the fall back of using the first connection that DockerImagesView and DockerContainersView uses Change-Id: Ie6ce2ad837823f8f6a9e0f49d97b962525ed67c6 Reviewed-on: https://git.eclipse.org/r/73826 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-26Bug 494585: Don't query an inactive connection for property information.Roland Grunberg2-26/+22
The connection information query for the properties view will wait as much as 2 seconds to retrieve a value. Make this entire process asynchronous to avoid UI hangups. In the case of a disabled connection there is no need to even query for connection info. Change-Id: Icb13c800584bfcb02fe4ba47867d5821b019b6ed Reviewed-on: https://git.eclipse.org/r/73658 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 37e900045ed0102187d63255986a82b380febfc1) Reviewed-on: https://git.eclipse.org/r/73762
2016-05-26Bug 471661: Support Searching Docker Registries.Roland Grunberg14-162/+566
Change-Id: I9d4157fe7fe58351d76600e163f1dc599ad535a8 Reviewed-on: https://git.eclipse.org/r/73327 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> (cherry picked from commit 932aac27403255298d521f37c09e741d6c3913ea) Reviewed-on: https://git.eclipse.org/r/73750 Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-05-26Bug 491999 - Docker build fails when called via Quick Access menuJeff Johnston2-7/+29
- make connection detection more robust to handle case where Docker Explorer View isn't up yet and a connection selected - add some logic back into CommandUtils and use it instead of calling DockerConnectionWatcher directly Change-Id: I7653fdd80114485db6299f485dbb96d58299d5d0 Reviewed-on: https://git.eclipse.org/r/73752 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-25Bug 494574: Prevent refresh from running when connection disabledRoland Grunberg2-1/+3
- by setting imagesLoaded, containersLoaded to true on an innactive connection, we prevent any logic from triggering further refreshes when we know they'll fail - the refresh job in the docker explorer content provider should run asynchronously Change-Id: I74b2f2dc24006b5c7d5711e2ff57930f7d911166 Reviewed-on: https://git.eclipse.org/r/73645 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Reviewed-on: https://git.eclipse.org/r/73661 Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-05-25Update mirror urls for 5.0.0 release.Jeff Johnston1-2/+2
Change-Id: I550b457bed138a84e46ab3bce3f19155e8f5cc86 Reviewed-on: https://git.eclipse.org/r/73657 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-25Update stable-5.0 branch build locations.Jeff Johnston5-10/+10
Change-Id: I0ba540ac0f9d1b623458a025451e23becb3d68ed Reviewed-on: https://git.eclipse.org/r/73552 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-24Bug 493953 - Trying to run image says image needs pullingJeff Johnston1-5/+5
- change ImageRunSelectionPage to use repoTags() instead of tags() method and don't assume one repo when creating list of image names - sort final list of image names Change-Id: I34309b64ce1ade54eddc6fc0c2bbe477e3768f97 Reviewed-on: https://git.eclipse.org/r/73222 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-24Bug 494256 - Fix Docker docs versioning and ui tests to be 2.0.0 in masterJeff Johnston4-4/+4
- update MANIFEST.MF files and pom.xml files. Change-Id: I8a20c158a6f9f341fe7663359852da04e619a608 Reviewed-on: https://git.eclipse.org/r/73365 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-24Bug 476387 - Allow for connection settings editionXavier Coulon60-703/+3247
Added new EditConnection wizard , page and model to allow for changes of name and connection settings with the same validation rules as in the NewConnection wizard. Changes in a connection name are progragated to all related launch configurations (run and build images). Refactored the code to hold the connection settings, using implementations of IDockerConnectionSettings for Unix Socket and TCP connections. Removed equals/hashcode methods in DockerConnection because we need to be able to look-up a connection as the key in a map even after the name changed (otherwise, the Map#containsKey(Object) would returns false) Added listener interface in Containers and Images views to update the title when the connection changes. Added SWTBot tests to verify the behaviour of the new wizard Change-Id: Idfa1c82fdecdbcbe8a471a35c544aa813efd3d58 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/73256 Tested-by: Hudson CI
2016-05-24Bug 491999 - Docker build fails when called via Quick Access menuJeff Johnston5-62/+159
- add code to BuildImageCommandHandler to find a DockerExplorerView if the active part isn't the Docker Images View - from the DockerExplorerView, extract the current selected connection - display an error dialog if no connection can be located Change-Id: Ic5ccd010b30ef7e9ebede73ce82a89a381fb8c78 Reviewed-on: https://git.eclipse.org/r/72666 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-20Bug 493443 - Add context menu to remove a connectionXavier Coulon2-11/+43
Added command to the popup menu for the connection Update the command label to 'Remove' and used a tooltip for the toolbar command to keep the 'Remove connection'. Change-Id: If266e7265c05dcde62689a632783869e669c8461 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> Reviewed-on: https://git.eclipse.org/r/72563 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
2016-05-19Eliminate need for bundle activators in man page bundles.Mat Booth14-153/+64
They were doing nothing that couldn't be done by directly interrogating the Framework and Platform APIs directly. Eliminating pointless activators helps to improve the start up performance of the platform. Change-Id: I6eb15686a10ee894ee2c70ca8b0b5d4b4c62f714 Signed-off-by: Mat Booth <mat.booth@redhat.com> Reviewed-on: https://git.eclipse.org/r/73202 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Hudson CI
2016-05-19Formatting changes only.Mat Booth9-441/+440
Re-format code in man.core plugin to comply with the project's code style configuration. Change-Id: I561926a87b68597e46ef14cd8c2ba9eb9f348f9f Signed-off-by: Mat Booth <mat.booth@redhat.com> Reviewed-on: https://git.eclipse.org/r/73177 Tested-by: Hudson CI
2016-05-19Formatting changes only.Mat Booth6-337/+337
Re-format code in man.help plugin to comply with the project's code style configuration. Change-Id: I5ad02f53f1081929f891fbda5ac02d86ba788163 Signed-off-by: Mat Booth <mat.booth@redhat.com> Reviewed-on: https://git.eclipse.org/r/73176 Tested-by: Hudson CI
2016-05-19Bug 485936 - Expose DockerContainerConfig#labels() in APIJeff Johnston1-2/+2
Change-Id: I1646effb05ee3b9db10fdfe4476f322a81d27937 Reviewed-on: https://git.eclipse.org/r/73102 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-17Bug 491880 - NullPointerException in BuildDockerImageShortcut.getPathJeff Johnston1-2/+6
- fix BuildDockerImageShortcut.getPath to test for result of findMember before trying to call getLocation - if there is an error finding a relative location, return an empty path Change-Id: I25fca6e32bb3f3a67b2e2a74353cc0ce19755c23 Reviewed-on: https://git.eclipse.org/r/72850 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-17Bug 485737 - StandInException in DockerConnection$LogThread.executeJeff Johnston1-0/+3
- add catch for InterruptedException and then interrupt the current thread to stop execution cleanly Change-Id: I7bf1536626ec1236cd6b3a4bc5064265da63d806 Reviewed-on: https://git.eclipse.org/r/72948 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
2016-05-17Reduce Activators content.Alexander Kurtakov9-88/+64
Change-Id: I799bf05be8b0e407398043f1e67481e6cf9b7e44 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/72868 Tested-by: Hudson CI
2016-05-16profiling: Simplify boolean returns.Alexander Kurtakov1-18/+5
Change-Id: I07094125abd670c91f6d080857925664d07c3e48 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/72811 Tested-by: Hudson CI
2016-05-16docker: Use indexOf(char) where feasible.Alexander Kurtakov3-20/+9
Changed Listener to Adapter where there were empty methods too. Change-Id: I15a90ece2e99c5a32af92e60cab34426ef6209ad Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/72810 Tested-by: Hudson CI
2016-05-16systemtap: Remove useless instanceof checks.Alexander Kurtakov3-15/+4
Change-Id: I56d0b902c6bdb456784d8acf53003f6de098b2ab Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/72808 Tested-by: Hudson CI

Back to the top