Systemtap: Improvements to remote operations.

-Resolve EBZ #433422.
-Apply environment variables passed to remote runs.
-Restore option to specify port number for remote operations.
-Improve some error dialogs relating to failed remote connections/runs.
-Cleanup, syntax standardization, and removal of unused modules/preferences.

Change-Id: I6f18afaa97efb3f4196261dff51b55454b6e3ee1
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/26406
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>

2 files changed, 5 insertions, 5 deletions

diff --git a/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java b/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java
index ecc0e65900..a553bae600 100644
--- a/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java
+++ b/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java
@@ -21,7 +21,7 @@ import org.eclipse.linuxtools.profiling.launch.RemoteEnvProxyManager;
 import org.eclipse.linuxtools.tools.launch.core.properties.LinuxtoolsPathProperty;
 
 /*
- * Abstract class with usefull functions for ProcessFactory classes.
+ * Abstract class with useful functions for ProcessFactory classes.
  */
 public abstract class LinuxtoolsProcessFactory {
     private static final String PATH = "PATH"; //$NON-NLS-1$
diff --git a/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java b/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java
index 0f8c3a8289..a1f42cb73e 100644
--- a/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java
+++ b/profiling/org.eclipse.linuxtools.tools.launch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/RuntimeProcessFactory.java
@@ -220,7 +220,7 @@ public class RuntimeProcessFactory extends LinuxtoolsProcessFactory {
      *
      * @since 1.1
      */
-    public Process exec(String cmdarray[], String[] envp, IFileStore dir, IProject project)
+    public Process exec(String[] cmdarray, String[] envp, IFileStore dir, IProject project)
             throws IOException {
         return exec(cmdarray, envp, dir, project, null);
     }
@@ -239,7 +239,7 @@ public class RuntimeProcessFactory extends LinuxtoolsProcessFactory {
      *
      * @since 3.0
      */
-    public Process exec(String cmdarray[], String[] envp, IFileStore dir, IProject project, PTY pty)
+    public Process exec(String[] cmdarray, String[] envp, IFileStore dir, IProject project, PTY pty)
             throws IOException {
 
         Process p = null;
@@ -276,9 +276,9 @@ public class RuntimeProcessFactory extends LinuxtoolsProcessFactory {
             cmdarray = cmdlist.toArray(new String[0]);
 
             if (pty == null) {
-                p = launcher.execute(path, cmdarray, envp, changeToDir , new NullProgressMonitor());
+                p = launcher.execute(path, cmdarray, envp, changeToDir, new NullProgressMonitor());
             } else {
-                p = launcher.execute(path, cmdarray, envp, changeToDir , new NullProgressMonitor(), pty);
+                p = launcher.execute(path, cmdarray, envp, changeToDir, new NullProgressMonitor(), pty);
             }
         } catch (CoreException e) {
             e.printStackTrace();