diff options
author | Alexander Kurtakov | 2014-04-07 09:55:05 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2014-04-07 10:35:38 +0000 |
commit | a474fd01f0f9450a83e223277085f5c530bb273d (patch) | |
tree | d609b665731d686facb719c2acd91d8fbd41ce41 /perf | |
parent | f9efc19ba33d3aaa6f0cf799c2f22ce4ecff0078 (diff) | |
download | org.eclipse.linuxtools-a474fd01f0f9450a83e223277085f5c530bb273d.tar.gz org.eclipse.linuxtools-a474fd01f0f9450a83e223277085f5c530bb273d.tar.xz org.eclipse.linuxtools-a474fd01f0f9450a83e223277085f5c530bb273d.zip |
tests: Use more appropriate junit assert methods.
Improves readability:
* assertTrue(!condition) -> assertFalse(condition)
* assertTrue(a == b) -> assertEquals(a, b) and other similar
Change-Id: Iea7478cac9eb0278b7dcfa5702c115004ba7b5ae
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24530
Tested-by: Hudson CI
Diffstat (limited to 'perf')
-rw-r--r-- | perf/org.eclipse.linuxtools.perf.tests/src/org/eclipse/linuxtools/internal/perf/tests/ModelTest.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/perf/org.eclipse.linuxtools.perf.tests/src/org/eclipse/linuxtools/internal/perf/tests/ModelTest.java b/perf/org.eclipse.linuxtools.perf.tests/src/org/eclipse/linuxtools/internal/perf/tests/ModelTest.java index 651a648d0c..045e88a784 100644 --- a/perf/org.eclipse.linuxtools.perf.tests/src/org/eclipse/linuxtools/internal/perf/tests/ModelTest.java +++ b/perf/org.eclipse.linuxtools.perf.tests/src/org/eclipse/linuxtools/internal/perf/tests/ModelTest.java @@ -285,7 +285,7 @@ public class ModelTest extends AbstractTest { String expectedFilePath = "/home/user/workspace/fibonacci/Debug/../src/fibonacci.cpp"; assertTrue(expectedDsoPath.equals(dso.getPath())); - assertTrue(dso.getChildren().length == 2); + assertEquals(dso.getChildren().length, 2); for (TreeParent dsoChild : dso.getChildren()) { String filePath = ((PMFile) dsoChild).getPath(); @@ -295,18 +295,18 @@ public class ModelTest extends AbstractTest { } else { assertTrue(expectedFilePath.equals(filePath)); assertTrue(dsoChild.hasChildren()); - assertTrue(dsoChild.getChildren().length == 1); + assertEquals(dsoChild.getChildren().length, 1); TreeParent curSym = dsoChild.getChildren()[0]; assertTrue(curSym.hasChildren()); - assertTrue(curSym.getChildren().length == 5); + assertEquals(curSym.getChildren().length, 5); float percentCount = 0; for (TreeParent symChild : curSym.getChildren()) { percentCount += symChild.getPercent(); } - assertTrue(Math.ceil(percentCount) == 100.0); + assertEquals(Math.ceil(percentCount), 100.0, 0.0); } } |