diff options
author | Alexander Kurtakov | 2012-04-20 22:31:20 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2012-04-20 22:31:20 +0000 |
commit | 2de4e31e479b384bf6c11bd1a61cdec7b2933c77 (patch) | |
tree | e36a3f1b52c052f89b1001af8c93c69ac47edfa5 /oprofile | |
parent | fabecfd6c2e67c1511f07f0d8ade8cf826b63595 (diff) | |
download | org.eclipse.linuxtools-2de4e31e479b384bf6c11bd1a61cdec7b2933c77.tar.gz org.eclipse.linuxtools-2de4e31e479b384bf6c11bd1a61cdec7b2933c77.tar.xz org.eclipse.linuxtools-2de4e31e479b384bf6c11bd1a61cdec7b2933c77.zip |
Enable more warnings and fix them.
Diffstat (limited to 'oprofile')
27 files changed, 312 insertions, 21 deletions
diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/.settings/org.eclipse.jdt.core.prefs b/oprofile/org.eclipse.linuxtools.oprofile.core/.settings/org.eclipse.jdt.core.prefs index fdf3224780..9faeba18c0 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/.settings/org.eclipse.jdt.core.prefs +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/.settings/org.eclipse.jdt.core.prefs @@ -1,5 +1,9 @@ -#Thu Jan 15 14:14:30 EST 2009 eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore +org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull +org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault +org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable +org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve @@ -7,6 +11,83 @@ org.eclipse.jdt.core.compiler.compliance=1.5 org.eclipse.jdt.core.compiler.debug.lineNumber=generate org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore +org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning +org.eclipse.jdt.core.compiler.problem.deadCode=warning +org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled +org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled +org.eclipse.jdt.core.compiler.problem.discouragedReference=warning +org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore +org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fatalOptionalError=disabled +org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore +org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning +org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=error +org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning +org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled +org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning +org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning +org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning +org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore +org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning +org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled +org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning +org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=warning +org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning +org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error +org.eclipse.jdt.core.compiler.problem.nullReference=warning +org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error +org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning +org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning +org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore +org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore +org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore +org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning +org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning +org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore +org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore +org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=warning +org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore +org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore +org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled +org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning +org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled +org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore +org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning +org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning +org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning +org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled +org.eclipse.jdt.core.compiler.problem.unusedImport=warning +org.eclipse.jdt.core.compiler.problem.unusedLabel=warning +org.eclipse.jdt.core.compiler.problem.unusedLocal=warning +org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.5 diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/OprofileCorePlugin.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/OprofileCorePlugin.java index 137c58df1e..705a0baeb1 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/OprofileCorePlugin.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/OprofileCorePlugin.java @@ -51,6 +51,7 @@ public class OprofileCorePlugin extends Plugin { /** * This method is called upon plug-in activation */ + @Override public void start(BundleContext context) throws Exception { super.start(context); } @@ -58,6 +59,7 @@ public class OprofileCorePlugin extends Plugin { /** * This method is called when the plug-in is stopped */ + @Override public void stop(BundleContext context) throws Exception { super.stop(context); plugin = null; @@ -171,7 +173,7 @@ public class OprofileCorePlugin extends Plugin { * @param msg */ public static void log(int severity, String msg) { - plugin.getLog().log(new Status(severity, PLUGIN_ID, Status.OK, msg, null)); + plugin.getLog().log(new Status(severity, PLUGIN_ID, IStatus.OK, msg, null)); } /** @@ -182,7 +184,7 @@ public class OprofileCorePlugin extends Plugin { * @param cause */ public static void log(int severity, String msg, Throwable cause) { - plugin.getLog().log(new Status(severity, PLUGIN_ID, Status.OK, msg, cause)); + plugin.getLog().log(new Status(severity, PLUGIN_ID, IStatus.OK, msg, cause)); } /** diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpInfo.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpInfo.java index 05f0b4704e..b2ed8087c2 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpInfo.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpInfo.java @@ -18,7 +18,6 @@ import java.util.Comparator; import java.util.HashMap; import org.eclipse.linuxtools.internal.oprofile.core.OprofileCorePlugin; -import org.eclipse.linuxtools.internal.oprofile.core.OpxmlException; import org.eclipse.linuxtools.internal.oprofile.core.linux.LinuxOpxmlProvider.OpInfoRunner; import org.eclipse.linuxtools.internal.oprofile.core.opxml.info.DefaultsProcessor; @@ -171,7 +170,7 @@ public class OpInfo { * @return the requested default or <code>null</code> if not known */ public String getDefault(String what) { - return (String) defaults.get(what); + return defaults.get(what); } /** diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpUnitMask.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpUnitMask.java index e012ef08fe..22740cd0fd 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpUnitMask.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/daemon/OpUnitMask.java @@ -33,7 +33,7 @@ public class OpUnitMask { * A description of the mask. */ public String description; - }; + } public static final int SET_DEFAULT_MASK = -1; diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/LinuxOpcontrolProvider.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/LinuxOpcontrolProvider.java index d14aae5435..8556d7b199 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/LinuxOpcontrolProvider.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/LinuxOpcontrolProvider.java @@ -264,7 +264,7 @@ public class LinuxOpcontrolProvider implements IOpcontrolProvider { } // Verbosity hack. If --start or --start-daemon, add verbosity, if set - String cmd = (String) args.get(1); + String cmd = args.get(1); if (verbosity.length() > 0 && (cmd.equals (OPD_START_COLLECTION) || cmd.equals(OPD_START_DAEMON))) { args.add(verbosity); } diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpControlErrorHandler.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpControlErrorHandler.java index 7ca27413ba..1eebd1a839 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpControlErrorHandler.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpControlErrorHandler.java @@ -17,7 +17,7 @@ import java.io.FileReader; import java.io.IOException; import java.util.HashMap; -import org.eclipse.core.runtime.Status; +import org.eclipse.core.runtime.IStatus; import org.eclipse.linuxtools.internal.oprofile.core.OpcontrolException; import org.eclipse.linuxtools.internal.oprofile.core.OprofileCorePlugin; import org.eclipse.linuxtools.internal.oprofile.core.OprofileProperties; @@ -99,7 +99,7 @@ public class OpControlErrorHandler { } // We have something to log - OprofileCorePlugin.log(Status.ERROR, NLS.bind( + OprofileCorePlugin.log(IStatus.ERROR, NLS.bind( OprofileProperties.getString(type), "opcontrol", fullErr)); //$NON-NLS-1$ if (error != null) { diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpxmlRunner.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpxmlRunner.java index 3b1ae09188..5ceb4121b2 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpxmlRunner.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/linux/OpxmlRunner.java @@ -28,7 +28,7 @@ import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; import javax.xml.parsers.SAXParserFactory; -import org.eclipse.core.runtime.Status; +import org.eclipse.core.runtime.IStatus; import org.eclipse.linuxtools.internal.oprofile.core.Oprofile; import org.eclipse.linuxtools.internal.oprofile.core.OprofileCorePlugin; import org.eclipse.linuxtools.internal.oprofile.core.OprofileProperties; @@ -220,7 +220,7 @@ public class OpxmlRunner { } if (!errorOutput.toString().trim().equals("")) { //$NON-NLS-1$ OprofileCorePlugin - .log(Status.ERROR, + .log(IStatus.ERROR, NLS.bind( OprofileProperties .getString("process.log.stderr"), "opreport", errorOutput.toString().trim())); //$NON-NLS-1$ //$NON-NLS-2$ @@ -304,7 +304,7 @@ public class OpxmlRunner { } if (!errorOutput.toString().trim().equals("")) { //$NON-NLS-1$ OprofileCorePlugin - .log(Status.ERROR, + .log(IStatus.ERROR, NLS.bind( OprofileProperties .getString("process.log.stderr"), "opreport", errorOutput.toString().trim())); //$NON-NLS-1$ //$NON-NLS-2$ diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/AbstractDataAdapter.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/AbstractDataAdapter.java index 35f01761de..432fba024c 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/AbstractDataAdapter.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/AbstractDataAdapter.java @@ -64,6 +64,7 @@ public abstract class AbstractDataAdapter { return inp; } + @Override public String toString (){ String ret = null; Source source = new DOMSource(getDocument()); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/OprofileSAXHandler.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/OprofileSAXHandler.java index 62ecb7052e..70ee73beca 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/OprofileSAXHandler.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/OprofileSAXHandler.java @@ -100,7 +100,7 @@ public class OprofileSAXHandler extends DefaultHandler { public static XMLProcessor getProcessor(String type) { XMLProcessor processor = null; - Class<?> handlerClass = (Class<?>) processors.get(type); + Class<?> handlerClass = processors.get(type); if (handlerClass != null) { try { processor = (XMLProcessor) handlerClass.newInstance(); @@ -115,6 +115,7 @@ public class OprofileSAXHandler extends DefaultHandler { /** * @see org.xml.sax.ContentHandler#startDocument() */ + @Override public void startDocument() { // Reset processor processor = null; @@ -123,12 +124,14 @@ public class OprofileSAXHandler extends DefaultHandler { /** * @see org.xml.sax.ContentHandler#endDocument() */ + @Override public void endDocument() { } /** * @see org.xml.sax.ContentHandler#startElement(String, String, String, Attributes) */ + @Override public void startElement(String uri, String lName, String qName, Attributes attrs) { if (processor == null) { // Get processor for this event type @@ -148,6 +151,7 @@ public class OprofileSAXHandler extends DefaultHandler { /** * @see org.xml.sax.ContentHandler#endElement(String, String, String) */ + @Override public void endElement(String uri, String name, String qName) { // Set the accumulated characters processor.characters(charactersBuffer.toString(), callData); @@ -157,6 +161,7 @@ public class OprofileSAXHandler extends DefaultHandler { /** * @see org.xml.sax.ContentHandler#characters(char[], int, int) */ + @Override public void characters(char ch[], int start, int length) { // Ignore characters which are only whitespace String str = new String(ch, start, length).trim(); @@ -191,7 +196,7 @@ public class OprofileSAXHandler extends DefaultHandler { * @param tag the XML tag to pass to the parent processor */ public void pop(String tag) { - processor = (XMLProcessor) processorStack.pop(); + processor = processorStack.pop(); processor.endElement(tag, callData); } } diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/XMLProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/XMLProcessor.java index fda588a339..8ac2fe18f0 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/XMLProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/XMLProcessor.java @@ -28,7 +28,7 @@ public class XMLProcessor { * @param callData call data for the processor (usually the result is stored here) */ public void reset(Object callData) { - }; + } /** * This method is called whenever a new tag is seen in the document. By default, diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventAdapter.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventAdapter.java index 41c34b668e..58b775717e 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventAdapter.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventAdapter.java @@ -60,6 +60,7 @@ public class CheckEventAdapter extends AbstractDataAdapter { } } + @Override public void process() { setReturnCode(); createXML(); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventsProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventsProcessor.java index 6cf6ed43f2..c624572d85 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventsProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/checkevent/CheckEventsProcessor.java @@ -35,6 +35,7 @@ public class CheckEventsProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#reset() */ + @Override public void reset(Object callData) { result = INVALID_UNKNOWN; } @@ -42,6 +43,7 @@ public class CheckEventsProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(RESULT_TAG)) { if (characters.equals(EVENT_OK_STR)) { diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/DefaultsProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/DefaultsProcessor.java index 44bdce671f..141f4c22dc 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/DefaultsProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/DefaultsProcessor.java @@ -31,6 +31,7 @@ public class DefaultsProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#reset() */ + @Override public void reset(Object callData) { map.clear(); } @@ -38,6 +39,7 @@ public class DefaultsProcessor extends XMLProcessor { /* (non-Javadoc) * @see org.eclipse.linuxtools.internal.oprofile.core.opxml.XMLProcessor#endElement(java.lang.String, java.lang.Object) */ + @Override public void endElement(String name, Object callData) { if (name.equals(OpInfoProcessor.DEFAULTS_TAG)) { OpInfo info = (OpInfo) callData; diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/EventListProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/EventListProcessor.java index aab2649c99..713eb004ad 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/EventListProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/EventListProcessor.java @@ -50,6 +50,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#reset() */ + @Override public void reset(Object callData) { info = new OpUnitMask.MaskInfo(); } @@ -57,6 +58,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(VALUE_TAG)) { // Set mask's value @@ -108,6 +110,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#reset() */ + @Override public void reset(Object callData) { unitMask = new OpUnitMask(); masks.clear(); @@ -116,6 +119,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#startElement(String, Attributes) */ + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(MASK_TAG)) { // Tell SAX handler to use the mask processor @@ -128,6 +132,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(MASK_TYPE_TAG)) { // Set the mask type @@ -169,7 +174,7 @@ public class EventListProcessor extends XMLProcessor { return -1; } - }; + } /** * Constructor for EventListProcessor. Initializes internal state. @@ -187,6 +192,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#startElement(String, Attributes) */ + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(EVENT_TAG)) { // new event @@ -205,6 +211,7 @@ public class EventListProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(EVENT_TAG)) { // Finished constructing an event. Add it to the list. diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/OpInfoProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/OpInfoProcessor.java index d7abb6404e..f3a35bbdd4 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/OpInfoProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/info/OpInfoProcessor.java @@ -41,6 +41,7 @@ public class OpInfoProcessor extends XMLProcessor { /* (non-Javadoc) * @see org.eclipse.linuxtools.internal.oprofile.core.opxml.XMLProcessor#startElement(java.lang.String, org.xml.sax.Attributes, java.lang.Object) */ + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(DEFAULTS_TAG)) { OprofileSAXHandler.getInstance(callData).push(defaultsProc); @@ -55,6 +56,7 @@ public class OpInfoProcessor extends XMLProcessor { /* (non-Javadoc) * @see org.eclipse.linuxtools.internal.oprofile.core.opxml.XMLProcessor#endElement(java.lang.String, java.lang.Object) */ + @Override public void endElement(String name, Object callData) { if (name.equals(CPU_FREQUENCY_TAG)) { double speed = Double.parseDouble(characters); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/DependentProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/DependentProcessor.java index f1c2e9e874..f566e5520d 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/DependentProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/DependentProcessor.java @@ -39,11 +39,13 @@ public class DependentProcessor extends XMLProcessor { //processor used for symbols of an image private SymbolsProcessor _symbolsProcessor = new SymbolsProcessor(); + @Override public void reset(Object callData) { image = new OpModelImage(); imageList = new ArrayList<OpModelImage>(); } + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(IMAGE_TAG)) { image.setName(valid_string(attrs.getValue(ATTR_IMAGENAME))); @@ -55,6 +57,7 @@ public class DependentProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(IMAGE_TAG)) { imageList.add(image); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/ModelDataProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/ModelDataProcessor.java index 973d4bab49..2087234940 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/ModelDataProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/ModelDataProcessor.java @@ -47,11 +47,13 @@ public class ModelDataProcessor extends XMLProcessor { private DependentProcessor _dependentProcessor = new DependentProcessor(); + @Override public void reset(Object callData) { image = ((CallData) callData).opModelImage; imgSeen = 0; } + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(IMAGE_TAG)) { if (imgSeen == 0) { @@ -70,6 +72,7 @@ public class ModelDataProcessor extends XMLProcessor { } } + @Override public void endElement(String name, Object callData) { if (name.equals(IMAGE_TAG)) { if (imgSeen > 1) { diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SamplesProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SamplesProcessor.java index 91f31cc14e..7419dde6b6 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SamplesProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SamplesProcessor.java @@ -35,6 +35,7 @@ public class SamplesProcessor extends XMLProcessor { //a list of all samples (for this symbol) private ArrayList<OpModelSample> sampleList; + @Override public void reset(Object callData) { sample = new OpModelSample(); sampleList = new ArrayList<OpModelSample>(); @@ -43,6 +44,7 @@ public class SamplesProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(COUNT_TAG)) { sample.setCount(Integer.parseInt(characters)); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SymbolsProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SymbolsProcessor.java index 95299df442..347597bb74 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SymbolsProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/modeldata/SymbolsProcessor.java @@ -41,6 +41,7 @@ public class SymbolsProcessor extends XMLProcessor { private SamplesProcessor samplesProcessor = new SamplesProcessor(); + @Override public void reset(Object callData) { symbol = new OpModelSymbol(); symbols = new ArrayList<OpModelSymbol>(); @@ -49,6 +50,7 @@ public class SymbolsProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#startElement(String, Attributes) */ + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(SYMBOL_TAG)) { symbol.setName(valid_string(attrs.getValue(ATTR_NAME))); @@ -63,6 +65,7 @@ public class SymbolsProcessor extends XMLProcessor { /** * @see org.eclipse.linuxtools.internal.oprofile.core.XMLProcessor#endElement(String) */ + @Override public void endElement(String name, Object callData) { if (name.equals(SYMBOL_TAG)) { symbol.setSamples(samplesProcessor.getSamples()); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/sessions/SessionsProcessor.java b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/sessions/SessionsProcessor.java index 649c51d773..1c9a4f4e43 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/sessions/SessionsProcessor.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.core/src/org/eclipse/linuxtools/internal/oprofile/core/opxml/sessions/SessionsProcessor.java @@ -30,7 +30,7 @@ public class SessionsProcessor extends XMLProcessor { public SessionInfo(ArrayList<OpModelEvent> list){ this.list = list; } - }; + } // XML tags recognized by this processor public static final String SESSION_TAG = "session"; //$NON-NLS-1$ @@ -51,6 +51,7 @@ public class SessionsProcessor extends XMLProcessor { /* (non-Javadoc) * @see org.eclipse.linuxtools.internal.oprofile.core.opxml.XMLProcessor#startElement(java.lang.String, org.xml.sax.Attributes, java.lang.Object) */ + @Override public void startElement(String name, Attributes attrs, Object callData) { if (name.equals(SESSION_TAG)) { String sessionName = valid_string(attrs.getValue(SESSION_NAME_ATTR)); @@ -67,6 +68,7 @@ public class SessionsProcessor extends XMLProcessor { /* (non-Javadoc) * @see org.eclipse.linuxtools.internal.oprofile.core.opxml.XMLProcessor#endElement(java.lang.String, java.lang.Object) */ + @Override public void endElement(String name, Object callData) { if (name.equals(SESSION_TAG)) { // Got end of session -- save in session list diff --git a/oprofile/org.eclipse.linuxtools.oprofile.launch/.settings/org.eclipse.jdt.core.prefs b/oprofile/org.eclipse.linuxtools.oprofile.launch/.settings/org.eclipse.jdt.core.prefs index df0870d86a..a0bb9f57ad 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.launch/.settings/org.eclipse.jdt.core.prefs +++ b/oprofile/org.eclipse.linuxtools.oprofile.launch/.settings/org.eclipse.jdt.core.prefs @@ -1,5 +1,9 @@ -#Wed Aug 06 11:12:12 EDT 2008 eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore +org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull +org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault +org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable +org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve @@ -7,6 +11,83 @@ org.eclipse.jdt.core.compiler.compliance=1.5 org.eclipse.jdt.core.compiler.debug.lineNumber=generate org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore +org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning +org.eclipse.jdt.core.compiler.problem.deadCode=warning +org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled +org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled +org.eclipse.jdt.core.compiler.problem.discouragedReference=warning +org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore +org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fatalOptionalError=disabled +org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore +org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning +org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=error +org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning +org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled +org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning +org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning +org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning +org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore +org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning +org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled +org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning +org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore +org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning +org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error +org.eclipse.jdt.core.compiler.problem.nullReference=warning +org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error +org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning +org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning +org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore +org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore +org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore +org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning +org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning +org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore +org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore +org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=warning +org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore +org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore +org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled +org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning +org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled +org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore +org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning +org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning +org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning +org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled +org.eclipse.jdt.core.compiler.problem.unusedImport=warning +org.eclipse.jdt.core.compiler.problem.unusedLabel=warning +org.eclipse.jdt.core.compiler.problem.unusedLocal=warning +org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.5 diff --git a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/OprofileLaunchPlugin.java b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/OprofileLaunchPlugin.java index a5f3d78f28..07066e2edb 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/OprofileLaunchPlugin.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/OprofileLaunchPlugin.java @@ -67,11 +67,13 @@ public class OprofileLaunchPlugin extends AbstractUIPlugin { public OprofileLaunchPlugin() { } + @Override public void start(BundleContext context) throws Exception { super.start(context); plugin = this; } + @Override public void stop(BundleContext context) throws Exception { super.stop(context); plugin = null; diff --git a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileEventConfigTab.java b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileEventConfigTab.java index 5153c41500..7581ebcadf 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileEventConfigTab.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileEventConfigTab.java @@ -89,6 +89,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { defaultEventCheck.setText(OprofileLaunchMessages.getString("tab.event.defaultevent.button.text")); //$NON-NLS-1$ defaultEventCheck.setLayoutData(new GridData()); defaultEventCheck.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { handleEnabledToggle(); } @@ -145,6 +146,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { /** * @see ILaunchConfigurationTab#isValid(ILaunchConfiguration) */ + @Override public boolean isValid(ILaunchConfiguration config) { if (getTimerMode()) { return true; //no options to check for validity @@ -407,6 +409,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { enabledCheck.setText(OprofileLaunchMessages.getString("tab.event.counterSettings.enabled.button.text")); //$NON-NLS-1$ enabledCheck.setLayoutData(new GridData(SWT.LEFT, SWT.CENTER, false, false, 2, 1)); enabledCheck.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { counter.setEnabled(enabledCheck.getSelection()); internalSetEnabledState(counter.getEnabled()); @@ -448,7 +451,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { eventList.setContentProvider(new IStructuredContentProvider() { public Object[] getElements(Object inputElement) { OprofileCounter ctr = (OprofileCounter) inputElement; - return (OpEvent[]) ctr.getValidEvents(); + return ctr.getValidEvents(); } public void dispose() { } public void inputChanged(Viewer arg0, Object arg1, Object arg2) { } @@ -473,6 +476,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { profileKernelCheck = new Button(parent, SWT.CHECK); profileKernelCheck.setText(OprofileLaunchMessages.getString("tab.event.counterSettings.profileKernel.check.text")); //$NON-NLS-1$ profileKernelCheck.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { handleProfileKernelToggle(); } @@ -482,6 +486,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { profileUserCheck = new Button(parent, SWT.CHECK); profileUserCheck.setText(OprofileLaunchMessages.getString("tab.event.counterSettings.profileUser.check.text")); //$NON-NLS-1$ profileUserCheck.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { handleProfileUserToggle(); } @@ -771,6 +776,7 @@ public class OprofileEventConfigTab extends AbstractLaunchConfigurationTab { maskButton.setText(mask.getText(i)); maskButton.setSelection(selected); maskButton.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { handleToggle((Button)se.getSource(), maskButtonIndex); } diff --git a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileSetupTab.java b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileSetupTab.java index 916d61516a..0528fe907c 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileSetupTab.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/configuration/OprofileSetupTab.java @@ -55,6 +55,7 @@ public class OprofileSetupTab extends AbstractLaunchConfigurationTab { return OprofileLaunchMessages.getString("tab.global.name"); //$NON-NLS-1$ } + @Override public boolean isValid(ILaunchConfiguration config) { boolean b = options.isValid(); // System.out.println("SetupTab isValid = " + b); @@ -147,6 +148,7 @@ public class OprofileSetupTab extends AbstractLaunchConfigurationTab { Button button = createPushButton(p, OprofileLaunchMessages.getString("tab.global.kernelImage.browse.button.text"), null); //$NON-NLS-1$ final Shell shell = top.getShell(); button.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent sev) { showFileDialog(shell); } @@ -176,6 +178,7 @@ public class OprofileSetupTab extends AbstractLaunchConfigurationTab { final Button b = new Button(parent, SWT.CHECK); b.setText(label); b.addSelectionListener(new SelectionAdapter() { + @Override public void widgetSelected(SelectionEvent se) { handleCheckSelected(b); } diff --git a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/launching/AbstractOprofileLaunchConfigurationDelegate.java b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/launching/AbstractOprofileLaunchConfigurationDelegate.java index 1916f9bafd..133afba979 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/launching/AbstractOprofileLaunchConfigurationDelegate.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.launch/src/org/eclipse/linuxtools/internal/oprofile/launch/launching/AbstractOprofileLaunchConfigurationDelegate.java @@ -45,6 +45,7 @@ public abstract class AbstractOprofileLaunchConfigurationDelegate extends Profil protected ILaunchConfiguration config; + @Override public void launch(ILaunchConfiguration config, String mode, ILaunch launch, IProgressMonitor monitor) throws CoreException { this.config = config; LaunchOptions options = new LaunchOptions(); //default options created in the constructor @@ -84,7 +85,7 @@ public abstract class AbstractOprofileLaunchConfigurationDelegate extends Profil ArrayList<String> command = new ArrayList<String>( 1 + arguments.length ); command.add( exePath.toOSString() ); command.addAll( Arrays.asList( arguments ) ); - String[] commandArray = (String[])command.toArray( new String[command.size()] ); + String[] commandArray = command.toArray( new String[command.size()] ); boolean usePty = config.getAttribute(ICDTLaunchConfigurationConstants.ATTR_USE_TERMINAL, ICDTLaunchConfigurationConstants.USE_TERMINAL_DEFAULT); Process process; process = execute( commandArray, getEnvironment( config ), wd, usePty ); diff --git a/oprofile/org.eclipse.linuxtools.oprofile.ui/.settings/org.eclipse.jdt.core.prefs b/oprofile/org.eclipse.linuxtools.oprofile.ui/.settings/org.eclipse.jdt.core.prefs index 5f0bb8a0f9..a0bb9f57ad 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.ui/.settings/org.eclipse.jdt.core.prefs +++ b/oprofile/org.eclipse.linuxtools.oprofile.ui/.settings/org.eclipse.jdt.core.prefs @@ -1,5 +1,9 @@ -#Mon Dec 01 14:59:31 EST 2008 eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore +org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull +org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault +org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable +org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve @@ -7,6 +11,83 @@ org.eclipse.jdt.core.compiler.compliance=1.5 org.eclipse.jdt.core.compiler.debug.lineNumber=generate org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore +org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning +org.eclipse.jdt.core.compiler.problem.deadCode=warning +org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled +org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled +org.eclipse.jdt.core.compiler.problem.discouragedReference=warning +org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore +org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fatalOptionalError=disabled +org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore +org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning +org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=error +org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning +org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled +org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning +org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning +org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning +org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore +org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning +org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled +org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning +org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore +org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning +org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error +org.eclipse.jdt.core.compiler.problem.nullReference=warning +org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error +org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning +org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning +org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore +org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore +org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore +org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning +org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning +org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore +org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore +org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=warning +org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore +org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore +org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled +org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning +org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled +org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore +org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning +org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning +org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning +org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled +org.eclipse.jdt.core.compiler.problem.unusedImport=warning +org.eclipse.jdt.core.compiler.problem.unusedLabel=warning +org.eclipse.jdt.core.compiler.problem.unusedLocal=warning +org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.5 diff --git a/oprofile/org.eclipse.linuxtools.oprofile.ui/src/org/eclipse/linuxtools/internal/oprofile/ui/OprofileUiPlugin.java b/oprofile/org.eclipse.linuxtools.oprofile.ui/src/org/eclipse/linuxtools/internal/oprofile/ui/OprofileUiPlugin.java index 246857b0b1..5d68485572 100644 --- a/oprofile/org.eclipse.linuxtools.oprofile.ui/src/org/eclipse/linuxtools/internal/oprofile/ui/OprofileUiPlugin.java +++ b/oprofile/org.eclipse.linuxtools.oprofile.ui/src/org/eclipse/linuxtools/internal/oprofile/ui/OprofileUiPlugin.java @@ -66,6 +66,7 @@ public class OprofileUiPlugin extends AbstractUIPlugin { /** * This method is called upon plug-in activation */ + @Override public void start(BundleContext context) throws Exception { super.start(context); plugin = this; @@ -74,6 +75,7 @@ public class OprofileUiPlugin extends AbstractUIPlugin { /** * This method is called when the plug-in is stopped */ + @Override public void stop(BundleContext context) throws Exception { super.stop(context); plugin = null; |