Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/gcov
diff options
context:
space:
mode:
authorAlexander Kurtakov2014-04-14 06:57:07 +0000
committerAlexander Kurtakov2014-04-14 07:50:41 +0000
commit0c767e21b14c87985f1bae59c33dbaf7ac6b5152 (patch)
treef1f6ffa760765c777b6443ef45a0dd3a60aab25a /gcov
parent370878b5b01d9133144394db7e8d3956442d6086 (diff)
downloadorg.eclipse.linuxtools-0c767e21b14c87985f1bae59c33dbaf7ac6b5152.tar.gz
org.eclipse.linuxtools-0c767e21b14c87985f1bae59c33dbaf7ac6b5152.tar.xz
org.eclipse.linuxtools-0c767e21b14c87985f1bae59c33dbaf7ac6b5152.zip
dataviewers: Cleanup.
Reduce visibility wherever possible - if new methods will be exposed they have to have proper javadoc (both at class/method level). At version 3.0 it's high time to take API seriously. Also fix a number of inconsistencies as spotted by sonar. Change-Id: I8640827f3c16cc89688ba93abe553e7665d2bc56 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/24936 Tested-by: Hudson CI
Diffstat (limited to 'gcov')
-rw-r--r--gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/internal/gcov/view/CovView.java22
1 files changed, 3 insertions, 19 deletions
diff --git a/gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/internal/gcov/view/CovView.java b/gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/internal/gcov/view/CovView.java
index 1af7e4f6a0..d4fc496ccc 100644
--- a/gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/internal/gcov/view/CovView.java
+++ b/gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/internal/gcov/view/CovView.java
@@ -153,7 +153,7 @@ public class CovView extends AbstractSTDataView {
});
}
- public static void setCovViewTitle(CovView view, String title, String binaryPath, String timestamp) {
+ private static void setCovViewTitle(CovView view, String title, String binaryPath, String timestamp) {
String viewText = NLS.bind(Messages.CovView_view_title, new Object[] { title, binaryPath, timestamp });
view.label.setText(viewText);
view.label.getParent().layout(true);
@@ -233,7 +233,7 @@ public class CovView extends AbstractSTDataView {
* Used by Test engine and OpenSerAction
* @param cvrgeMnger
*/
- public static CovView displayCovResults(CovManager cvrgeMnger, String timestamp) throws PartInitException {
+ private static CovView displayCovResults(CovManager cvrgeMnger, String timestamp) throws PartInitException {
// load an Eclipse view
IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
IWorkbenchPage page = window.getActivePage();
@@ -261,27 +261,11 @@ public class CovView extends AbstractSTDataView {
public void run() {
Object o = getSTViewer().getInput();
if (o instanceof CovManager) {
- getExporter().setFilePath(getDefaultCSVPath());
+ getExporter().setFilePath(defaultCSVPath);
}
super.run();
}
};
return action;
}
-
- /**
- * @return the defaultCSVPath
- */
- public String getDefaultCSVPath() {
- return defaultCSVPath;
- }
-
- /**
- * @param defaultCSVPath
- * the defaultCSVPath to set
- */
- public void setDefaultCSVPath(String defaultCSVPath) {
- this.defaultCSVPath = defaultCSVPath;
- }
-
}

Back to the top