Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland Grunberg2013-05-30 14:49:42 +0000
committerCamilo Bernal2013-05-30 19:37:16 +0000
commit7c2881d408e8b734b677c69908ad95838e3aef23 (patch)
tree542cf42d3ed26fd1e299a0786b1715a6499e218b
parent6301767a47674f1935c3b91f117b721779f8c41f (diff)
downloadorg.eclipse.linuxtools-7c2881d408e8b734b677c69908ad95838e3aef23.tar.gz
org.eclipse.linuxtools-7c2881d408e8b734b677c69908ad95838e3aef23.tar.xz
org.eclipse.linuxtools-7c2881d408e8b734b677c69908ad95838e3aef23.zip
Resolve API problems detected with @since tags in profiling framework.
In preparation for our 2.0 release, some API additions were made to components of the profiling framework (mainly dataviewers) which required only a minor version bump (eg. 4.x). Later on, API breaking changes were made so all @since tags referencing 4.x would need to be changed to 5.0. Change-Id: I5e3d5c4d6f4aeb1cb13378cbbb84fd536482256a Reviewed-on: https://git.eclipse.org/r/13406 Tested-by: Hudson CI Reviewed-by: Camilo Bernal <cabernal@redhat.com> IP-Clean: Camilo Bernal <cabernal@redhat.com> Tested-by: Camilo Bernal <cabernal@redhat.com>
-rw-r--r--profiling/org.eclipse.linuxtools.binutils/src/org/eclipse/linuxtools/binutils/utils/STSymbolManager.java3
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/AnnotationColumnToggle.java2
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/IAnnotationProvider.java3
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/PropertyEventDispatcher.java3
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/STAnnotatedSourceEditorActivator.java3
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTDataViewersField.java3
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTableViewer.java4
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTreeViewer.java4
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/STDataViewersHideShowManager.java1
-rw-r--r--profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/TreeColumnViewerFilter.java2
-rw-r--r--profiling/org.eclipse.linuxtools.profiling.ui/src/org/eclipse/linuxtools/profiling/ui/ProfileUIUtils.java3
11 files changed, 25 insertions, 6 deletions
diff --git a/profiling/org.eclipse.linuxtools.binutils/src/org/eclipse/linuxtools/binutils/utils/STSymbolManager.java b/profiling/org.eclipse.linuxtools.binutils/src/org/eclipse/linuxtools/binutils/utils/STSymbolManager.java
index 55a04d7d4f..71c364374f 100644
--- a/profiling/org.eclipse.linuxtools.binutils/src/org/eclipse/linuxtools/binutils/utils/STSymbolManager.java
+++ b/profiling/org.eclipse.linuxtools.binutils/src/org/eclipse/linuxtools/binutils/utils/STSymbolManager.java
@@ -107,6 +107,9 @@ public class STSymbolManager {
// used ?
}
+ /**
+ * @since 4.1
+ */
public synchronized void reset() {
Iterator<Entry<IBinaryObject, AutoDisposeAddr2line>> iter = addr2lines.entrySet().iterator();
while (iter.hasNext()) {
diff --git a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/AnnotationColumnToggle.java b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/AnnotationColumnToggle.java
index b84c5be26e..f6ad6889e5 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/AnnotationColumnToggle.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/AnnotationColumnToggle.java
@@ -23,7 +23,7 @@ import org.eclipse.ui.texteditor.ITextEditor;
/**
* Ruler action to toglle showing the annotation column.
*
- * @since 4.2
+ * @since 5.0
*
*/
public class AnnotationColumnToggle extends AbstractRulerActionDelegate {
diff --git a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/IAnnotationProvider.java b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/IAnnotationProvider.java
index efa270eb9d..d8d4830b54 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/IAnnotationProvider.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/IAnnotationProvider.java
@@ -12,6 +12,9 @@ package org.eclipse.linuxtools.dataviewers.annotatedsourceeditor;
import org.eclipse.swt.graphics.Color;
+/**
+ * @since 5.0
+ */
public interface IAnnotationProvider {
/**
* gets the background column of a editor line
diff --git a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/PropertyEventDispatcher.java b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/PropertyEventDispatcher.java
index 23611beb30..d29f3bffef 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/PropertyEventDispatcher.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/PropertyEventDispatcher.java
@@ -22,6 +22,9 @@ import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.util.IPropertyChangeListener;
import org.eclipse.jface.util.PropertyChangeEvent;
+/**
+ * @since 5.0
+ */
@SuppressWarnings({ "rawtypes", "unchecked" })
public final class PropertyEventDispatcher {
private final Map fHandlerMap = new HashMap();
diff --git a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/STAnnotatedSourceEditorActivator.java b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/STAnnotatedSourceEditorActivator.java
index cc57ddea10..abd3faa06e 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/STAnnotatedSourceEditorActivator.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers.annotatedsourceeditor/src/org/eclipse/linuxtools/dataviewers/annotatedsourceeditor/STAnnotatedSourceEditorActivator.java
@@ -24,6 +24,9 @@ public class STAnnotatedSourceEditorActivator extends AbstractUIPlugin {
// The plug-in ID
public static final String PLUGIN_ID = "org.eclipse.linuxtools.dataviewers.annotatedsourceeditor"; //$NON-NLS-1$
+ /**
+ * @since 5.0
+ */
public static final String ANNOTATION_TYPE = PLUGIN_ID+".coloredLines"; //$NON-NLS-1$
// The shared instance
diff --git a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTDataViewersField.java b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTDataViewersField.java
index 08ebff7491..ad4cce487b 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTDataViewersField.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTDataViewersField.java
@@ -78,6 +78,9 @@ public abstract class AbstractSTDataViewersField implements ISTDataViewersField
* (non-Javadoc)
* @see org.eclipse.linuxtools.dataviewers.abstractviewers.ISTDataViewersField#isShowingByDefault()
*/
+ /**
+ * @since 5.0
+ */
@Override
public boolean isShowingByDefault() {
return true;
diff --git a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTableViewer.java b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTableViewer.java
index af49210990..e8a195ca26 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTableViewer.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTableViewer.java
@@ -55,7 +55,7 @@ public abstract class AbstractSTTableViewer extends AbstractSTViewer {
* @param parent - the parent Composite
* @param style - the table style
* @return a TableViewer
- * @since 4.1
+ * @since 5.0
*/
@Override
protected TableViewer createViewer(Composite parent, int style) {
@@ -161,7 +161,7 @@ public abstract class AbstractSTTableViewer extends AbstractSTViewer {
/**
* (non-Javadoc)
* @see org.eclipse.linuxtools.dataviewers.abstractviewers.AbstractSTViewer#getColumns()
- * @since 4.1
+ * @since 5.0
*/
@Override
public TableColumn[] getColumns() {
diff --git a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTreeViewer.java b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTreeViewer.java
index 39ca9b5012..2eba236242 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTreeViewer.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/AbstractSTTreeViewer.java
@@ -57,7 +57,7 @@ public abstract class AbstractSTTreeViewer extends AbstractSTViewer {
* @param style
* - the table style
* @return a TreeViewer
- * @since 4.1
+ * @since 5.0
*/
@Override
protected TreeViewer createViewer(Composite parent, int style) {
@@ -162,7 +162,7 @@ public abstract class AbstractSTTreeViewer extends AbstractSTViewer {
* (non-Javadoc)
*
* @see org.eclipse.linuxtools.dataviewers.abstractviewers.AbstractSTViewer# getColumns()
- * @since 4.1
+ * @since 5.0
*/
@Override
public TreeColumn[] getColumns() {
diff --git a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/STDataViewersHideShowManager.java b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/STDataViewersHideShowManager.java
index 67eae11073..5bc4fa9da1 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/STDataViewersHideShowManager.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/STDataViewersHideShowManager.java
@@ -188,6 +188,7 @@ public class STDataViewersHideShowManager {
/**
* Updates the columns width and status
+ * @since 5.0
*/
public void updateColumns() {
Item[] columns = stViewer.getColumns();
diff --git a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/TreeColumnViewerFilter.java b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/TreeColumnViewerFilter.java
index 4f45f844bd..ff528b7a09 100644
--- a/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/TreeColumnViewerFilter.java
+++ b/profiling/org.eclipse.linuxtools.dataviewers/src/org/eclipse/linuxtools/dataviewers/abstractviewers/TreeColumnViewerFilter.java
@@ -26,7 +26,7 @@ import org.eclipse.jface.viewers.ViewerFilter;
* Note: content provider of the given TreeViewer must be a ITreeContentProvider
*
* @author Xavier Raynaud <xavier.raynaud@kalray.eu>
- * @since 4.1
+ * @since 5.0
*/
public class TreeColumnViewerFilter extends ViewerFilter {
diff --git a/profiling/org.eclipse.linuxtools.profiling.ui/src/org/eclipse/linuxtools/profiling/ui/ProfileUIUtils.java b/profiling/org.eclipse.linuxtools.profiling.ui/src/org/eclipse/linuxtools/profiling/ui/ProfileUIUtils.java
index f0395b2adb..bf29fd7806 100644
--- a/profiling/org.eclipse.linuxtools.profiling.ui/src/org/eclipse/linuxtools/profiling/ui/ProfileUIUtils.java
+++ b/profiling/org.eclipse.linuxtools.profiling.ui/src/org/eclipse/linuxtools/profiling/ui/ProfileUIUtils.java
@@ -86,6 +86,9 @@ public class ProfileUIUtils {
}
}
+ /**
+ * @since 2.0
+ */
public static void openEditorAndSelect(IFile file, int line) throws PartInitException, BadLocationException {
if (file.exists()) {
IWorkbenchPage activePage = ProfileUIPlugin.getDefault().getWorkbench().getActiveWorkbenchWindow().getActivePage();

Back to the top