Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2015-09-02 06:32:11 +0000
committerRoland Grunberg2015-09-02 19:44:12 +0000
commitaf91d18400ef26190258bc1365b60697aa9e6012 (patch)
tree16f06148c4b4a9a2f6569ddc4eb1cd581559f341
parent95ff625aa416273053462ba96d6721cd06be3774 (diff)
downloadorg.eclipse.linuxtools-af91d18400ef26190258bc1365b60697aa9e6012.tar.gz
org.eclipse.linuxtools-af91d18400ef26190258bc1365b60697aa9e6012.tar.xz
org.eclipse.linuxtools-af91d18400ef26190258bc1365b60697aa9e6012.zip
docker: Unbreak build.
Rename some params and add TODO for fixing docs in other places. Enable even stricter compiler warnings to prevent breaking builds. Change-Id: I7c725fb75cd7e3a7092bcf7dd3c82442cd6d6f3d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/55131 Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Tested-by: Roland Grunberg <rgrunber@redhat.com>
-rw-r--r--containers/org.eclipse.linuxtools.docker.core/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerContainerListener.java2
-rw-r--r--containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerImageListener.java2
-rw-r--r--containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerRegistry.java3
4 files changed, 6 insertions, 3 deletions
diff --git a/containers/org.eclipse.linuxtools.docker.core/.settings/org.eclipse.jdt.core.prefs b/containers/org.eclipse.linuxtools.docker.core/.settings/org.eclipse.jdt.core.prefs
index 37711dbf75..74edc4bc0e 100644
--- a/containers/org.eclipse.linuxtools.docker.core/.settings/org.eclipse.jdt.core.prefs
+++ b/containers/org.eclipse.linuxtools.docker.core/.settings/org.eclipse.jdt.core.prefs
@@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=disabled
-org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=public
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=default
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
diff --git a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerContainerListener.java b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerContainerListener.java
index d92b310044..dd3acf88c9 100644
--- a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerContainerListener.java
+++ b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerContainerListener.java
@@ -20,7 +20,7 @@ public interface IDockerContainerListener {
*
* @param connection
* - the Docker connection
- * @param containers
+ * @param list
* - the new list of {@link IDockerContainer}
*/
void listChanged(IDockerConnection connection, List<IDockerContainer> list);
diff --git a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerImageListener.java b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerImageListener.java
index 1b63e526d4..f01bd7951d 100644
--- a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerImageListener.java
+++ b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerImageListener.java
@@ -18,7 +18,7 @@ public interface IDockerImageListener {
* Called when the list of {@link IDockerImage} for the given
* {@link IDockerConnection} changed
*
- * @param connection
+ * @param manager
* - the Docker connection
* @param images
* - the new list of {@link IDockerImage}
diff --git a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerRegistry.java b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerRegistry.java
index a054a907a6..b3e64a6554 100644
--- a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerRegistry.java
+++ b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/docker/core/IDockerRegistry.java
@@ -25,8 +25,11 @@ public interface IDockerRegistry {
* @param repository
* the image repository
* @throws InterruptedException
+ * TODO add proper docs
* @throws DockerException
+ * TODO add proper docs
* @throws ExecutionException
+ * TODO add proper docs
*/
List<IRepositoryTag> getTags(String repository)
throws InterruptedException, ExecutionException, DockerException;

Back to the top