Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2015-03-09 18:49:39 +0000
committerAlexander Kurtakov2015-03-09 19:05:06 +0000
commitfb59b1eebb6e2bcb784f63e6507d64a92705dfac (patch)
tree5cdc2616ccd35bfaf96507bd497a9d7a23ce542e
parentfc66359d65bdc4cb032ad9ffa2eb52459dc98024 (diff)
downloadorg.eclipse.linuxtools-fb59b1eebb6e2bcb784f63e6507d64a92705dfac.tar.gz
org.eclipse.linuxtools-fb59b1eebb6e2bcb784f63e6507d64a92705dfac.tar.xz
org.eclipse.linuxtools-fb59b1eebb6e2bcb784f63e6507d64a92705dfac.zip
valgrind: Fix javadoc.
Please Java 8 javadoc tool. Enable warnings to yell about such issues in the future. Change-Id: I39ac1db0dbad248fae90bdb03bfe94dd26dcca75 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/43463 Tested-by: Hudson CI
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.core/.settings/org.eclipse.jdt.core.prefs14
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/ValgrindParserUtils.java8
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/.settings/org.eclipse.jdt.core.prefs14
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindExportWizard.java1
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindLaunchPlugin.java6
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java1
6 files changed, 34 insertions, 10 deletions
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.core/.settings/org.eclipse.jdt.core.prefs b/valgrind/org.eclipse.linuxtools.valgrind.core/.settings/org.eclipse.jdt.core.prefs
index 03aba13458..2e799b63f2 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.core/.settings/org.eclipse.jdt.core.prefs
+++ b/valgrind/org.eclipse.linuxtools.valgrind.core/.settings/org.eclipse.jdt.core.prefs
@@ -12,6 +12,7 @@ org.eclipse.jdt.core.compiler.compliance=1.7
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.doc.comment.support=enabled
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -35,12 +36,25 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=default
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=all_standard_tags
+org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=default
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/ValgrindParserUtils.java b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/ValgrindParserUtils.java
index 7e435780dd..cd1dafad98 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/ValgrindParserUtils.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/ValgrindParserUtils.java
@@ -29,7 +29,7 @@ public final class ValgrindParserUtils {
* @param line - the line to parse
* @param delim - the DELIMITER to separate on
* @return Long value of ARGUMENT
- * @throws IOException
+ * @throws IOException If parsing failed.
*/
public static Long parseLongValue(String line, String delim)
throws IOException {
@@ -49,7 +49,7 @@ public final class ValgrindParserUtils {
* @param line - the line to parse
* @param delim - the DELIMITER to separate fields
* @return String value of ARGUMENT
- * @throws IOException
+ * @throws IOException If parsing failed.
*/
public static String parseStrValue(String line, String delim)
throws IOException {
@@ -68,7 +68,7 @@ public final class ValgrindParserUtils {
* @param filename - the file name to parse
* @param prefix - the prefix of the filename up to the PID
* @return - the PID portion of the filename as an Integer
- * @throws IOException
+ * @throws IOException If PID can not be parsed.
*/
public static Integer parsePID(String filename, String prefix) throws IOException {
String pidstr = filename.substring(prefix.length(), filename.lastIndexOf(DOT));
@@ -82,7 +82,7 @@ public final class ValgrindParserUtils {
/**
* Throws an IOException indicating parsing failed on a given line
* @param line - line that parsing failed
- * @throws IOException
+ * @throws IOException If parsing failed.
*/
public static void fail(String line) throws IOException {
throw new IOException(NLS.bind(Messages.getString("AbstractValgrindTextParser.Parsing_output_failed"), line)); //$NON-NLS-1$
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/.settings/org.eclipse.jdt.core.prefs b/valgrind/org.eclipse.linuxtools.valgrind.launch/.settings/org.eclipse.jdt.core.prefs
index 6976c94ea6..fdedaa46ad 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/.settings/org.eclipse.jdt.core.prefs
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/.settings/org.eclipse.jdt.core.prefs
@@ -8,6 +8,7 @@ org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.7
org.eclipse.jdt.core.compiler.compliance=1.7
+org.eclipse.jdt.core.compiler.doc.comment.support=enabled
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -31,12 +32,25 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=disabled
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=default
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=all_standard_tags
+org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=default
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindExportWizard.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindExportWizard.java
index 928f560e97..a0edcb25db 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindExportWizard.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindExportWizard.java
@@ -79,6 +79,7 @@ public class ValgrindExportWizard extends Wizard implements IExportWizard {
e.printStackTrace();
return false;
} catch (InterruptedException e) {
+ //ignore
}
return true;
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindLaunchPlugin.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindLaunchPlugin.java
index 9b3836305b..6743b69384 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindLaunchPlugin.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindLaunchPlugin.java
@@ -104,9 +104,6 @@ public class ValgrindLaunchPlugin extends AbstractUIPlugin {
return plugin;
}
- /**
- * @since 0.10
- */
public Version getValgrindVersion(IProject project) throws CoreException {
Version valgrindVersion;
try {
@@ -136,9 +133,6 @@ public class ValgrindLaunchPlugin extends AbstractUIPlugin {
valgrindCommand = command;
}
- /**
- * @since 0.10
- */
protected ValgrindCommand getValgrindCommand() {
if (valgrindCommand == null) {
valgrindCommand = new ValgrindCommand();
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
index 6b87d40522..19e3bc3690 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
@@ -23,6 +23,7 @@ public interface IValgrindOutputDirectoryProvider {
/**
* Obtains a directory to store Valgrind output files.
* @return the absolute path to this directory
+ * @throws IOException If problem occured trying to retrieve the path.
*/
public IPath getOutputPath() throws IOException;

Back to the top