Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Tiede2012-02-27 08:04:03 +0000
committerMarkus Tiede2012-02-27 08:04:03 +0000
commit2f86e0d0c5ade922157bbb157060ecaeb5ddaa1f (patch)
treec7996c03a1f9b8ab1d5c7ba1e1e1c46283a0f32d
parent1554d7cf19c7b472fe61ae74135047304f54107a (diff)
downloadorg.eclipse.jubula.core-2f86e0d0c5ade922157bbb157060ecaeb5ddaa1f.tar.gz
org.eclipse.jubula.core-2f86e0d0c5ade922157bbb157060ecaeb5ddaa1f.tar.xz
org.eclipse.jubula.core-2f86e0d0c5ade922157bbb157060ecaeb5ddaa1f.zip
Sprint task - migrate initial checks from ProblemsBP to new teststyle framework.
-rw-r--r--org.eclipse.jubula.client.core/src/org/eclipse/jubula/client/core/businessprocess/problems/ProblemType.java3
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/.checkstyle10
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/.classpath7
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/.gitignore2
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/.project34
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/.settings/org.eclipse.jdt.core.prefs8
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/META-INF/MANIFEST.MF13
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/about.html28
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/build.properties5
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/plugin.xml39
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/pom.xml22
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/Activator.java41
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteHasAUT.java43
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteNotEmpty.java36
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/Messages.java36
-rw-r--r--org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/messages.properties9
-rw-r--r--org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/businessprocess/ProblemsBP.java55
-rw-r--r--org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/Messages.java3
-rw-r--r--org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/messages.properties3
-rw-r--r--org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/problemview/JBMarkerResolutionGenerator.java1
20 files changed, 333 insertions, 65 deletions
diff --git a/org.eclipse.jubula.client.core/src/org/eclipse/jubula/client/core/businessprocess/problems/ProblemType.java b/org.eclipse.jubula.client.core/src/org/eclipse/jubula/client/core/businessprocess/problems/ProblemType.java
index 3c72943cd..cbd12e65c 100644
--- a/org.eclipse.jubula.client.core/src/org/eclipse/jubula/client/core/businessprocess/problems/ProblemType.java
+++ b/org.eclipse.jubula.client.core/src/org/eclipse/jubula/client/core/businessprocess/problems/ProblemType.java
@@ -52,9 +52,6 @@ public enum ProblemType {
/** no AUT exists - repair : OPEN PROJECT PROPERTIES EDITOR */
REASON_NO_AUT_FOR_PROJECT_EXISTS,
- /** TS has no Aut selected - repair : OPEN TESTSUITE EDITOR */
- REASON_NO_AUT_FOR_TESTSUITE_SELECTED,
-
/** AUT has no AutConfig for current server - repair : OPEN AUTEDITOR */
REASON_NO_AUTCONFIG_FOR_SERVER_EXIST,
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/.checkstyle b/org.eclipse.jubula.client.teststyle.impl.standard/.checkstyle
new file mode 100644
index 000000000..57af6cc26
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/.checkstyle
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
+ <fileset name="all" enabled="true" check-config-name="Jubula" local="false">
+ <file-match-pattern match-pattern="." include-pattern="true"/>
+ </fileset>
+ <filter name="FilesFromPackage" enabled="true">
+ <filter-data value="src/org/eclipse/jubula/client/teststyle/impl/standard/i18n"/>
+ </filter>
+</fileset-config>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/.classpath b/org.eclipse.jubula.client.teststyle.impl.standard/.classpath
new file mode 100644
index 000000000..64c5e31b7
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/.classpath
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+ <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.5"/>
+ <classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
+ <classpathentry kind="src" path="src"/>
+ <classpathentry kind="output" path="bin"/>
+</classpath>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/.gitignore b/org.eclipse.jubula.client.teststyle.impl.standard/.gitignore
new file mode 100644
index 000000000..934e0e06f
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/.gitignore
@@ -0,0 +1,2 @@
+/bin
+/target
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/.project b/org.eclipse.jubula.client.teststyle.impl.standard/.project
new file mode 100644
index 000000000..be690a87e
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/.project
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+ <name>org.eclipse.jubula.client.teststyle.impl.standard</name>
+ <comment></comment>
+ <projects>
+ </projects>
+ <buildSpec>
+ <buildCommand>
+ <name>org.eclipse.jdt.core.javabuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>org.eclipse.pde.ManifestBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>org.eclipse.pde.SchemaBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ </buildSpec>
+ <natures>
+ <nature>org.eclipse.pde.PluginNature</nature>
+ <nature>org.eclipse.jdt.core.javanature</nature>
+ <nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
+ </natures>
+</projectDescription>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.jubula.client.teststyle.impl.standard/.settings/org.eclipse.jdt.core.prefs
new file mode 100644
index 000000000..b8a8e0fd2
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/.settings/org.eclipse.jdt.core.prefs
@@ -0,0 +1,8 @@
+#Wed Feb 01 13:14:29 CET 2012
+eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
+org.eclipse.jdt.core.compiler.compliance=1.5
+org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+org.eclipse.jdt.core.compiler.source=1.5
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/META-INF/MANIFEST.MF b/org.eclipse.jubula.client.teststyle.impl.standard/META-INF/MANIFEST.MF
new file mode 100644
index 000000000..f44a3e329
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/META-INF/MANIFEST.MF
@@ -0,0 +1,13 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: Jubula Teststyle Rules - Standard
+Bundle-SymbolicName: org.eclipse.jubula.client.teststyle.impl.standard;singleton:=true
+Bundle-Version: 1.2.0.qualifier
+Bundle-Activator: org.eclipse.jubula.client.teststyle.impl.standard.Activator
+Bundle-Vendor: Eclipse Jubula
+Require-Bundle: org.eclipse.core.runtime,
+ org.eclipse.jubula.client.teststyle;bundle-version="[1.2.0,1.3.0)",
+ org.eclipse.jubula.client.core;bundle-version="[1.2.0,1.3.0)",
+ org.eclipse.jubula.client.ui.rcp;bundle-version="[1.2.0,1.3.0)"
+Bundle-RequiredExecutionEnvironment: J2SE-1.5
+Bundle-ActivationPolicy: lazy
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/about.html b/org.eclipse.jubula.client.teststyle.impl.standard/about.html
new file mode 100644
index 000000000..f1be81099
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/about.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
+ "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml">
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
+<title>About</title>
+</head>
+<body lang="EN-US">
+<h2>About This Content</h2>
+
+<p>June 22, 2011</p>
+<h3>License</h3>
+
+<p>The Eclipse Foundation makes available all content in this plug-in (&quot;Content&quot;). Unless otherwise
+indicated below, the Content is provided to you under the terms and conditions of the
+Eclipse Public License Version 1.0 (&quot;EPL&quot;). A copy of the EPL is available
+at <a href="http://www.eclipse.org/legal/epl-v10.html">http://www.eclipse.org/legal/epl-v10.html</a>.
+For purposes of the EPL, &quot;Program&quot; will mean the Content.</p>
+
+<p>If you did not receive this Content directly from the Eclipse Foundation, the Content is
+being redistributed by another party (&quot;Redistributor&quot;) and different terms and conditions may
+apply to your use of any object code in the Content. Check the Redistributor's license that was
+provided with the Content. If no such license exists, contact the Redistributor. Unless otherwise
+indicated below, the terms and conditions of the EPL still apply to any source code in the Content
+and such source code may be obtained at <a href="http://www.eclipse.org">http://www.eclipse.org</a>.</p>
+
+</body>
+</html>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/build.properties b/org.eclipse.jubula.client.teststyle.impl.standard/build.properties
new file mode 100644
index 000000000..e9863e281
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/build.properties
@@ -0,0 +1,5 @@
+source.. = src/
+output.. = bin/
+bin.includes = META-INF/,\
+ .,\
+ plugin.xml
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/plugin.xml b/org.eclipse.jubula.client.teststyle.impl.standard/plugin.xml
new file mode 100644
index 000000000..0cb81a5ce
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/plugin.xml
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.4"?>
+<!--
+ Copyright (c) 2004, 2012 BREDEX GmbH.
+ All rights reserved. This program and the accompanying materials
+ are made available under the terms of the Eclipse Public License v1.0
+ which accompanies this distribution, and is available at
+ http://www.eclipse.org/legal/epl-v10.html
+ -->
+<plugin>
+ <extension
+ point="org.eclipse.jubula.client.teststyle.definition">
+ <category
+ description="Standard Rules"
+ name="Standard Rules">
+ <check
+ activeByDefault="true"
+ class="org.eclipse.jubula.client.teststyle.impl.standard.checks.TestSuiteHasAUT"
+ defaultSeverity="ERROR"
+ description="Each Testsuite should be assigned to an AUT"
+ id="org.eclipse.jubula.client.teststyle.impl.standard.checks.testSuiteHasAUT"
+ name="Testsuite has AUT defined">
+ <contexts><TestSuites id="TestSuiteContext" /></contexts>
+ <attributes></attributes>
+ </check>
+ <check
+ activeByDefault="true"
+ class="org.eclipse.jubula.client.teststyle.impl.standard.checks.TestSuiteNotEmpty"
+ defaultSeverity="ERROR"
+ description="Each Testsuite should reference at least one Test Case"
+ id="org.eclipse.jubula.client.teststyle.impl.standard.checks.testSuiteNotEmpty"
+ name="Testsuite references at least one Test Case">
+ <contexts><TestSuites id="TestSuiteContext" /></contexts>
+ <attributes></attributes>
+ </check>
+ </category>
+ </extension>
+
+</plugin>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/pom.xml b/org.eclipse.jubula.client.teststyle.impl.standard/pom.xml
new file mode 100644
index 000000000..9a6c086c5
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/pom.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Copyright (c) 2004, 2012 BREDEX GmbH.
+ All rights reserved. This program and the accompanying materials
+ are made available under the terms of the Eclipse Public License v1.0
+ which accompanies this distribution, and is available at
+ http://www.eclipse.org/legal/epl-v10.html
+ -->
+<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>org.eclipse.jubula.releng.client</artifactId>
+ <groupId>org.eclipse.jubula</groupId>
+ <version>1.2.0-SNAPSHOT</version>
+ <relativePath>../org.eclipse.jubula.releng.client</relativePath>
+ </parent>
+ <groupId>org.eclipse.jubula</groupId>
+ <artifactId>org.eclipse.jubula.client.teststyle.impl.standard</artifactId>
+ <version>1.2.0-SNAPSHOT</version>
+ <packaging>eclipse-plugin</packaging>
+</project>
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/Activator.java b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/Activator.java
new file mode 100644
index 000000000..43fe1a0a4
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/Activator.java
@@ -0,0 +1,41 @@
+/*******************************************************************************
+ * Copyright (c) 2004, 2012 BREDEX GmbH.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * BREDEX GmbH - initial API and implementation and/or initial documentation
+ *******************************************************************************/
+package org.eclipse.jubula.client.teststyle.impl.standard;
+
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
+
+/**
+ * Default Activator
+ */
+public class Activator implements BundleActivator {
+ /**
+ * the context
+ */
+ private static BundleContext context;
+
+ /**
+ * @return the context
+ */
+ static BundleContext getContext() {
+ return context;
+ }
+
+ /** {@inheritDoc} */
+ public void start(BundleContext bundleContext) throws Exception {
+ Activator.context = bundleContext;
+ }
+
+ /** {@inheritDoc} */
+ public void stop(BundleContext bundleContext) throws Exception {
+ Activator.context = null;
+ }
+}
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteHasAUT.java b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteHasAUT.java
new file mode 100644
index 000000000..28420985b
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteHasAUT.java
@@ -0,0 +1,43 @@
+/*******************************************************************************
+ * Copyright (c) 2004, 2012 BREDEX GmbH.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * BREDEX GmbH - initial API and implementation and/or initial documentation
+ *******************************************************************************/
+package org.eclipse.jubula.client.teststyle.impl.standard.checks;
+
+import java.util.Locale;
+
+import org.eclipse.jubula.client.core.model.ITestSuitePO;
+import org.eclipse.jubula.client.teststyle.checks.BaseCheck;
+import org.eclipse.jubula.client.teststyle.impl.standard.i18n.Messages;
+import org.eclipse.jubula.client.ui.rcp.businessprocess.WorkingLanguageBP;
+
+/**
+ * Check whether each Testsuite has an AUT defined
+ */
+public class TestSuiteHasAUT extends BaseCheck {
+
+ @Override
+ public String getDescription() {
+ return Messages.TestSuiteHasAUTProblemDescription;
+ }
+
+ @Override
+ public boolean hasError(Object obj) {
+ if (obj instanceof ITestSuitePO) {
+ ITestSuitePO ts = (ITestSuitePO) obj;
+ WorkingLanguageBP wl = WorkingLanguageBP.getInstance();
+ Locale workLang = wl.getWorkingLanguage();
+ if (ts.getAut() != null && wl.isTestSuiteLanguage(workLang, ts)) {
+ return false;
+ }
+ }
+ return true;
+ }
+
+}
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteNotEmpty.java b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteNotEmpty.java
new file mode 100644
index 000000000..12d46af06
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/checks/TestSuiteNotEmpty.java
@@ -0,0 +1,36 @@
+/*******************************************************************************
+ * Copyright (c) 2004, 2012 BREDEX GmbH.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * BREDEX GmbH - initial API and implementation and/or initial documentation
+ *******************************************************************************/
+package org.eclipse.jubula.client.teststyle.impl.standard.checks;
+
+import org.eclipse.jubula.client.core.model.ITestSuitePO;
+import org.eclipse.jubula.client.teststyle.checks.BaseCheck;
+import org.eclipse.jubula.client.teststyle.impl.standard.i18n.Messages;
+
+/**
+ * Testsuites should at least reference one test case
+ */
+public class TestSuiteNotEmpty extends BaseCheck {
+ @Override
+ public String getDescription() {
+ return Messages.NoEmptyTestSuitesProblemDescription;
+ }
+
+ @Override
+ public boolean hasError(Object obj) {
+ if (obj instanceof ITestSuitePO) {
+ ITestSuitePO ts = (ITestSuitePO) obj;
+ if (ts.getNodeListSize() == 0) {
+ return true;
+ }
+ }
+ return false;
+ }
+}
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/Messages.java b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/Messages.java
new file mode 100644
index 000000000..85292749c
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/Messages.java
@@ -0,0 +1,36 @@
+/*******************************************************************************
+ * Copyright (c) 2004, 2012 BREDEX GmbH.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * BREDEX GmbH - initial API and implementation and/or initial documentation
+ *******************************************************************************/
+package org.eclipse.jubula.client.teststyle.impl.standard.i18n;
+
+import org.eclipse.osgi.util.NLS;
+
+/**
+ * @author BREDEX GmbH
+ * @created 10.12.2010
+ */
+public class Messages extends NLS {
+ private static final String BUNDLE_NAME = "org.eclipse.jubula.client.teststyle.impl.standard.i18n.messages"; //$NON-NLS-1$
+
+ public static String NoEmptyTestSuitesProblemDescription;
+ public static String TestSuiteHasAUTProblemDescription;
+
+ static {
+ // initialize resource bundle
+ NLS.initializeMessages(BUNDLE_NAME, Messages.class);
+ }
+
+ /**
+ * Constructor
+ */
+ private Messages() {
+ // hide
+ }
+}
diff --git a/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/messages.properties b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/messages.properties
new file mode 100644
index 000000000..a18afec88
--- /dev/null
+++ b/org.eclipse.jubula.client.teststyle.impl.standard/src/org/eclipse/jubula/client/teststyle/impl/standard/i18n/messages.properties
@@ -0,0 +1,9 @@
+###############################################################################
+# Copyright (c) 2004, 2012 BREDEX GmbH.
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Eclipse Public License v1.0
+# which accompanies this distribution, and is available at
+# http://www.eclipse.org/legal/epl-v10.html
+##############################################################################
+TestSuiteHasAUTProblemDescription=Each Test Suite requires an AUT setting for Execution.
+NoEmptyTestSuitesProblemDescription=Add specified Test Cases to Test Suite. \ No newline at end of file
diff --git a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/businessprocess/ProblemsBP.java b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/businessprocess/ProblemsBP.java
index 2be5bfb09..6134f5aea 100644
--- a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/businessprocess/ProblemsBP.java
+++ b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/businessprocess/ProblemsBP.java
@@ -56,7 +56,6 @@ import org.eclipse.jubula.client.core.model.IRefTestSuitePO;
import org.eclipse.jubula.client.core.model.IReusedProjectPO;
import org.eclipse.jubula.client.core.model.ITestCasePO;
import org.eclipse.jubula.client.core.model.ITestJobPO;
-import org.eclipse.jubula.client.core.model.ITestSuitePO;
import org.eclipse.jubula.client.core.persistence.GeneralStorage;
import org.eclipse.jubula.client.core.persistence.ProjectPM;
import org.eclipse.jubula.client.core.utils.AbstractNonPostOperatingTreeNodeOperation;
@@ -395,17 +394,6 @@ public class ProblemsBP implements ICompletenessCheckListener,
} else {
checkAutConfigs();
}
- List<ITestSuitePO> testSuites = TestSuiteBP.getListOfTestSuites();
-
- for (ITestSuitePO testSuite : testSuites) {
- if (testSuite.getAut() == null) {
- problemNoAutForTestSuiteSelected(testSuite);
- }
-
- if (testSuite.getNodeListSize() == 0) {
- problemNoEmptyTestSuiteAllowed(testSuite);
- }
- }
}
/**
@@ -745,19 +733,6 @@ public class ProblemsBP implements ICompletenessCheckListener,
}
/**
- * called when a Test Suites lacks an Aut
- * @param testSuite TestSuite where problem occurs
- */
- private void problemNoAutForTestSuiteSelected(ITestSuitePO testSuite) {
- m_localProblemsToShow.add(ProblemFactory.createProblemWithMarker(
- new Status(
- IStatus.ERROR, Activator.PLUGIN_ID,
- Messages.TestDataDecoratorTestSuiteWithoutAUT), NLS.bind(
- Messages.ProblemCheckerNoAutSelected, testSuite.getName()),
- testSuite, ProblemType.REASON_NO_AUT_FOR_TESTSUITE_SELECTED));
- }
-
- /**
* called when an Aut lacks an AutConfig
* @param config AutConfig where problem occurs
* @param aut corresponding aut
@@ -802,21 +777,6 @@ public class ProblemsBP implements ICompletenessCheckListener,
}
/**
- * called when a Test Suites contains no Test Cases
- * @param testSuite TestSuite where problem occurs
- */
- private void problemNoEmptyTestSuiteAllowed(ITestSuitePO testSuite) {
- if (!checkTS(testSuite)) {
- return;
- }
- String message = NLS.bind(Messages.ProblemCheckerEmptyTestSuite,
- testSuite.getName());
- m_localProblemsToShow.add(ProblemFactory.createProblemWithMarker(
- new Status(IStatus.WARNING, Activator.PLUGIN_ID, message),
- message, testSuite, ProblemType.REASON_EMPTY_TESTSUITE));
- }
-
- /**
* Checks, if an execTC has compNames without compTypes
*/
@SuppressWarnings("synthetic-access")
@@ -989,21 +949,6 @@ public class ProblemsBP implements ICompletenessCheckListener,
}
/**
- * @param testSuite the actual testSuite
- * @return true, if the testSuite is editable, false otherwise.
- */
- private boolean checkTS(ITestSuitePO testSuite) {
- Locale workLang = WorkingLanguageBP.getInstance().getWorkingLanguage();
- if (testSuite.getAut() != null
- && WorkingLanguageBP.getInstance().isTestSuiteLanguage(
- workLang, testSuite)) {
- return true;
- }
-
- return false;
- }
-
- /**
* @author BREDEX GmbH
*/
private final class CollectProblemsOperation
diff --git a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/Messages.java b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/Messages.java
index 4102daa47..efe9871e4 100644
--- a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/Messages.java
+++ b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/Messages.java
@@ -627,10 +627,8 @@ public class Messages extends NLS {
public static String ProblemCheckerConnectToGDServer;
public static String ProblemCheckerDeprecatedAction;
public static String ProblemCheckerDeprecatedComp;
- public static String ProblemCheckerEmptyTestSuite;
public static String ProblemCheckerMissingSpecTc;
public static String ProblemCheckerNoAutExists;
- public static String ProblemCheckerNoAutSelected;
public static String ProblemCheckerNoCompType;
public static String ProblemCheckerNoServer;
public static String ProblemCheckerNoTestSuite;
@@ -861,7 +859,6 @@ public class Messages extends NLS {
public static String TestDataDecoratorTDInStepIncompl;
public static String TestDataDecoratorTdInTestCaseIncompl;
public static String TestDataDecoratorTestJobIncompl;
- public static String TestDataDecoratorTestSuiteWithoutAUT;
public static String TestDataDecoratorUnsupportedAUTLanguage;
public static String TestDataPreferencePageCharForEsc;
public static String TestDataPreferencePageCharForRef;
diff --git a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/messages.properties b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/messages.properties
index fef0db0cc..ac30d61a2 100644
--- a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/messages.properties
+++ b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/i18n/messages.properties
@@ -613,10 +613,8 @@ ProblemCheckerCompDoesNotExist=Test Step "{0}" in Test Case "{1}" uses a compone
ProblemCheckerConnectToGDServer=You have to connect to the AUT Agent.
ProblemCheckerDeprecatedAction=Test Step "{0}" in Test Case "{1}" uses a deprecated action.
ProblemCheckerDeprecatedComp=Test Step "{0}" in Test Case "{1}" uses a deprecated component type.
-ProblemCheckerEmptyTestSuite=Add specified Test Cases to Test Suite "{0}".
ProblemCheckerMissingSpecTc="{0}" contains a reference to a Test Case that does not exist.
ProblemCheckerNoAutExists=There is currently no AUT defined for the Project.
-ProblemCheckerNoAutSelected=Select an AUT for Test Suite "{0}" for Execution.
ProblemCheckerNoCompType=There is at least one Component Name without a Component Type in Test Case "{0}".
ProblemCheckerNoServer=You have to define at least one AUT Agent in workspace preferences.
ProblemCheckerNoTestSuite=You have to create at least one Test Suite.
@@ -847,7 +845,6 @@ TestDataDecoratorTDEvIncompl=In at least one Event Handler Test Data is incomple
TestDataDecoratorTDInStepIncompl=Test Data in this Test Step is incomplete.
TestDataDecoratorTdInTestCaseIncompl=Test Data in this Test Case is incomplete.
TestDataDecoratorTestJobIncompl=The Test Job is incomplete.
-TestDataDecoratorTestSuiteWithoutAUT=No AUT has been chosen for this Test Suite.
TestDataDecoratorUnsupportedAUTLanguage=The AUT for this Test Suite does not support the currently chosen working language.
TestDataPreferencePageCharForEsc=Escape character\:
TestDataPreferencePageCharForRef=Reference symbol\:
diff --git a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/problemview/JBMarkerResolutionGenerator.java b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/problemview/JBMarkerResolutionGenerator.java
index 73f7cb76c..8a3ff1eab 100644
--- a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/problemview/JBMarkerResolutionGenerator.java
+++ b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/problemview/JBMarkerResolutionGenerator.java
@@ -199,7 +199,6 @@ public class JBMarkerResolutionGenerator implements IMarkerResolutionGenerator {
case REASON_CONNECTED_TO_NO_SERVER:
return getNoServerConnectionResolutions();
case REASON_EMPTY_TESTSUITE:
- case REASON_NO_AUT_FOR_TESTSUITE_SELECTED:
case REASON_NO_COMPTYPE:
case REASON_TD_INCOMPLETE:
case REASON_DEPRECATED_ACTION:

Back to the top