Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2017-03-21Add remaining parts of the bazel buildDavid Ostrovsky1-0/+22
Add bazel build for ui and junit.http, and the test packages. A number of different test labels are supported: api attributes dfs diff http lfs lfs-server nls notes pack patch pgm reftree revplot revwalk storage submodule symlinks transport treewalk util To run all tests: bazel test //... To run specific tests, using labels: bazel test --test_tag_filters=api,dfs,revplot,treewalk //... Change-Id: Ic41b05a79d855212e67b1b4707e9c6b4dc9ea70d Signed-off-by: David Ostrovsky <> Signed-off-by: Jonathan Nieder <>
2017-02-26Update Jetty to 9.4.1.v20170120 in buck buildJonathan Nieder1-0/+1
5e8e2179b218ede7d14b69dc5149b0691b5859cf (Update Jetty to 9.4.1.v201470120, 2017-01-26) updated Jetty in the maven build. Update the buck build to match so buck builds work again. The buck build will go away soon, but in the meantime (until the bazel build gets the same level of support) it is convenient as a faster way of running tests than using maven. The bazel build doesn't need this change since it doesn't build or run http tests yet. Change-Id: Ibbdaf2880e76b32fc9f6b5605a2ff29e3deffda2
2017-02-20Enable and fix warnings about redundant specification of type argumentsDavid Pursehouse7-12/+12
Since the introduction of generic type parameter inference in Java 7, it's not necessary to explicitly specify the type of generic parameters. Enable the warning in Eclipse, and fix all occurrences. Change-Id: I9158caf1beca5e4980b6240ac401f3868520aad0 Signed-off-by: David Pursehouse <>
2017-02-19Enable and fix 'Should be tagged with @Override' warningDavid Pursehouse7-2/+25
Set missingOverrideAnnotation=warning in Eclipse compiler preferences which enables the warning: The method <method> of type <type> should be tagged with @Override since it actually overrides a superclass method Justification for this warning is described in: Enabling this causes in excess of 1000 warnings across the entire code-base. They are very easy to fix automatically with Eclipse's "Quick Fix" tool. Fix all of them except 2 which cause compilation failure when the project is built with mvn; add TODO comments on those for further investigation. Change-Id: I5772061041fd361fe93137fd8b0ad356e748a29c Signed-off-by: David Pursehouse <>
2017-02-19Update Jetty to 9.4.1.v20170120Matthias Sohn4-21/+23
MappedLoginService is no longer available in Jetty 9.4 therefore base TestLoginService on AbstractLoginService. Apparently Jetty now uses slf4j hence adapt RecordingLogger accordingly so we can log error messages containing slf4j style formatting anchors "{}". Change-Id: Ibb36aba8782882936849b6102001a88b699bb65c Signed-off-by: Matthias Sohn <>
2016-12-26Prepare 4.7.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I20754d13007e6591d36aae5766f3a9a82b24e120 Signed-off-by: Matthias Sohn <>
2016-12-24Prepare 4.6.1-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I6b05a6f6c3f92365c272e1bdaf76093ca01f2d58 Signed-off-by: Matthias Sohn <>
2016-12-23JGit v4.6.0.201612231935-rv4.6.0.201612231935-rMatthias Sohn2-2/+2
Change-Id: Iaa88fe1b195dfe6be99a7b4cb064684e75563715 Signed-off-by: Matthias Sohn <>
2016-09-22AppServer: Remove unnecessary 'unused' suppressionsDavid Pursehouse1-4/+2
Change-Id: Ic27106f38af14833147f739179c3ef8ec6b6ee31 Signed-off-by: David Pursehouse <>
2016-09-20Change JGit minimum execution environment to JavaSE-1.8Matthias Sohn3-5/+5
Bug: 500059 Change-Id: I47f3f6749a67da52029f84e002d9b155ed56d2b7 Signed-off-by: Matthias Sohn <>
2016-09-19Prepare 4.6.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: Id2eafc331ee32c332c2a9b867b05c260beb0d10f Signed-off-by: Matthias Sohn <>
2016-08-08Fix non-parameterized generic type warningMatthias Sohn1-1/+3
Change-Id: Ib857166f64420aebf7c31d72825cac44bd770dbd Signed-off-by: Matthias Sohn <>
2016-07-25Ignore 'The value of exception parameter is not used' warningDavid Pursehouse1-0/+1
Change-Id: I50407e4a33e35b718ca40503fdd436f1f9f70fba Signed-off-by: David Pursehouse <>
2016-07-14Fix AppServer build errors in Eclipse with <4.6 target platformsMatthias Sohn1-18/+27
9aa3748 added dummy implementations for loadRoleInfo() and loadUserInfo() to class MappedLoginService to fix compile errors in Eclipse when using 4.6 target platform which brings Jetty 9.3 adding these two methods. Unfortunately this causes errors when using non 4.6 target platform coming with an older Jetty version. Fix this by extracting the anonymous subclass of MappedLoginService which allows to suppress the unused private method errors in Eclipse. Change-Id: I75baeea7ff4502ce9ef2b541b3c0555da5535d79 Signed-off-by: Matthias Sohn <>
2016-07-10Implement new abstract MappedLoginService methods added in Jetty 9.3Matthias Sohn1-0/+8
Eclipse Neon comes with Jetty 9.3 which is causing unimplemented abstract method errors in test class AppServer when using the JGit or EGit Neon target platform. Fix this by adding dummy implementations. Change-Id: Ie49107d814a846997de95f149e91fe1ec2fbe4d8 Signed-off-by: Matthias Sohn <>
2016-06-01Prepare 4.5.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I572fe9fea0e5ca0bec4648c916ae95a5b1ccf125 Signed-off-by: Matthias Sohn <>
2016-04-08Prepare 4.4.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: If3162f4cc4ae6319b9f1e3293549485b039cfe7f Signed-off-by: Matthias Sohn <>
2016-04-07Prepare 4.3.1-SNAPSHOT versionsMatthias Sohn2-11/+11
Change-Id: I52c98ba8fb3a303269a1f9380af114b6dd8c5009 Signed-off-by: Matthias Sohn <>
2016-04-07JGit v4.3.0.201604071810-rv4.3.0.201604071810-rMatthias Sohn2-2/+2
Change-Id: I902cdf1ff92ce8c6e9d80c4965d8d5bd8b9ac6c1 Signed-off-by: Matthias Sohn <>
2016-04-07JGit v4.3.0.201604071045-rMatthias Sohn2-2/+2
Change-Id: Iafab78d6be34d31a13f979b7be67611135c0f8bd Signed-off-by: Matthias Sohn <>
2016-04-05Prepare 4.3-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: Ib831f8870938113bd5338763f90a07d5c108b1de Signed-off-by: Matthias Sohn <>
2016-03-23JGit v4.3.0.201603230630-rc1v4.3.0.201603230630-rc1Matthias Sohn2-2/+2
Change-Id: I10835e5aa3618e5033424595942cc1649152cb24 Signed-off-by: Matthias Sohn <>
2016-02-15Merge branch 'stable-4.2'Matthias Sohn1-1/+1
* stable-4.2: Don't use deprecated LockFile constructor Fix warnings about unchecked conversion of MergeResult MockServletConfig: Fix warning about unchecked conversion of Enumeration HugeFileTest: Make Git a class member and open in try-with-resource Suppress "unchecked cast" warnings related to UploadPackFactory.DISABLED DiffAlgorithms: Fix warnings about variable hiding DirCacheBasicTest: Open ObjectInserter.Formatter in try-with-resource DirCacheBuilderIteratorTest: Open TreeWalk in try-with-resource DirCacheCGitCompatabilityTest: Open TreeWalk in try-with-resource DirCacheCheckoutMaliciousPathTest: Open Git and RevWalk in t-w-r DirCacheIteratorTest: Open TreeWalk instances in try-with-resource ForPathTest: Open TreeWalk in try-with-resource GitConstructionTest: Open Git instance in try-with-resource IndexDiffTest: Open Git instances in try-with-resources ManifestParserTest: Don't use deprecated StringBufferInputStream InMemoryRepository: Remove unused RevWalk from batch method signature IndexModificationTimesTest: Open Git instances in try-with-resource InterIndexDiffFilterTest: Open TreeWalk in try-with-resource LockFileTest: Open Git instance in try-with-resource JGit v4.1.2.201602141800-r MergeCommandTest: Use JUnit's assume to check preconditions MergeCommandTest: Open Git instances in try-with-resource Change-Id: Ie5dba6b9132a29e86958a04fa2b76465bcd2c6b5 Signed-off-by: Matthias Sohn <>
2016-02-15MockServletConfig: Fix warning about unchecked conversion of EnumerationDavid Pursehouse1-1/+1
Change-Id: Ic5ce6d220e3b644032819ce4b2f31c669be1cdb9 Signed-off-by: David Pursehouse <>
2016-02-04Support LFS protocol and a file system based LFS storageMatthias Sohn1-1/+10
Implement LfsProtocolServlet handling the "Git LFS v1 Batch API" protocol [1]. Add a simple file system based LFS content store and the debug-lfs-store command to simplify testing. Introduce a LargeFileRepository interface to enable additional storage implementation while reusing the same protocol implementation. At the client side we have to configure the lfs.url, specify that we use the batch API and we don't use authentication: [lfs] url = http://host:port/lfs batch = true [lfs "http://host:port/lfs"] access = none the git-lfs client appends the "objects/batch" to the lfs.url. Hard code an Authorization header in the FileLfsRepository.getAction because then git-lfs client will skip asking for credentials. It will just forward the Authorization header from the response to the download/upload request. The FileLfsServlet supports file content storage for "Large File Storage" (LFS) server as defined by the Github LFS API [2]. - upload and download of large files is probably network bound hence use an asynchronous servlet for good scalability - simple object storage in file system with 2 level fan-out - use LockFile to protect writing large objects against multiple concurrent uploads of the same object - to prevent corrupt uploads the uploaded file is rejected if its hash doesn't match id given in URL The debug-lfs-store command is used to run the LfsProtocolServlet and, optionally, the FileLfsServlet which makes it easier to setup a local test server. [1] [2] Bug: 472961 Change-Id: I7378da5575159d2195138d799704880c5c82d5f3 Signed-off-by: Matthias Sohn <> Signed-off-by: Sasa Zivkov <>
2016-01-21Prepare 4.2.1-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: Ic9eac53b10ac97b2038b334d388ae3d21393f993 Signed-off-by: Matthias Sohn <>
2016-01-21JGit v4.2.0.201601211800-rv4.2.0.201601211800-rMatthias Sohn2-2/+2
Change-Id: I89f33b0da81ff499315baa5311f95f31724fa510 Signed-off-by: Matthias Sohn <>
2016-01-21Prepare 4.3.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: Idcf0479529693b023042becd96698f9afd344bd4 Signed-off-by: Matthias Sohn <>
2016-01-01buck: run http testsMatthias Sohn1-0/+18
Running tests using buck reveals that HttpClientTests are broken and weren't executed by Maven since these test classes don't match the maven-surefire-plugin's default for test classes **/* Will be fixed in a follow-up change. Change-Id: I82a01b5fd3f0a930bec2423a29a256601dadc248 Signed-off-by: Matthias Sohn <>
2015-09-28Prepare 4.2.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: If559d3565b1f84c93a533e1ce18d5293605d1950 Signed-off-by: Matthias Sohn <>
2015-09-28Prepare 4.1.1-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I035f3a8d0f0de86e8b8f00e668be5ce008402e82 Signed-off-by: Matthias Sohn <>
2015-09-28JGit v4.1.0.201509280440-rv4.1.0.201509280440-rMatthias Sohn2-2/+2
Change-Id: I9a536870b9f5c1247c52d6c976a954115982fa1c Signed-off-by: Matthias Sohn <>
2015-08-31Restore lazy Bundle-ActivationPolicy removed in 3a4a5a4eMatthias Sohn1-0/+1
This header was removed unintentionally from some bundles in 3a4a5a4e57f41c595ba950ea6f6680260669bf34. Restore it to ensure lazy activation of bundles. Change-Id: I1f841f978fb93278e3ec0533a01f1363510dd976 Signed-off-by: Matthias Sohn <>
2015-08-31Update uses-clauses in OSGi manifestsMatthias Sohn1-2/+11
In Bug 476164 it was reported that EGit doesn't start when the platform comes with jsch 0.1.51 while this version of EGit/JGit brings jsch 0.1.53. This could be caused by outdated uses-clauses. Hence recompute them using PDE tooling. Bug: 476164 Change-Id: I185ba097884ead9cd034eba842bd3bf34181a99b Signed-off-by: Matthias Sohn <>
2015-06-02Prepare 4.1.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I03d08b8e2d3400d4b5cdb4ab541b312870776843 Signed-off-by: Matthias Sohn <>
2015-05-10Update to Jetty 9.2.10Matthias Sohn4-17/+30
Change-Id: Iace29e6e99836019bb603ce06a08b91bada7c627 Signed-off-by: Matthias Sohn <>
2015-05-10Update javax.servlet to 3.1Matthias Sohn1-2/+2
Change-Id: Ifad154ed2f52f0102d297ac7fd4943ff1f309b9e Signed-off-by: Matthias Sohn <>
2015-02-09Set minimum required Java version to Java 7Matthias Sohn3-5/+5
Bug: 458475 Change-Id: Iea8f2236d4e6a94a8d14bb8cc685006ea3fd1bb7 Signed-off-by: Matthias Sohn <>
2015-01-27Prepare 4.0.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I414ba8ccc82866d3107ba7083a567ea70c879bdf Signed-off-by: Matthias Sohn <>
2014-12-23Prepare 3.7.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: Ib3e7b5f46ee1e27b9cf25b3b2d01d681a5c4904c Signed-off-by: Matthias Sohn <>
2014-12-23Prepare 3.6.1-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: Ie620c90ffafbffc6755b4e1ed55a61a15b118a2a Signed-off-by: Matthias Sohn <>
2014-12-23JGit v3.6.0.201412230720-rv3.6.0.201412230720-rMatthias Sohn2-2/+2
Change-Id: Ic28e2bbbdb1099e948c64a005c39f6b8d8ac69a8 Signed-off-by: Matthias Sohn <>
2014-11-12Prepare post 3.6.0-m1 buildsMatthias Sohn2-2/+2
Change-Id: Ie9927de64fa6b7d517f96b8cd12e57541f284ff2 Signed-off-by: Matthias Sohn <>
2014-11-12JGit v3.6.0.201411121045-m1v3.6.0.201411121045-m1Matthias Sohn2-2/+2
Change-Id: I9d789113d88cbbbdbabb8919f80c805aa4ba86fe Signed-off-by: Matthias Sohn <>
2014-09-05Prepare 3.6.0-SNAPSHOT buildsMatthias Sohn2-11/+11
Change-Id: I2d8c3768998c0cfc8d02d11009bc5b7ed1d75778 Signed-off-by: Matthias Sohn <>
2014-07-01Don't warn for methods that can be staticRobin Rosenberg1-1/+1
Making the methods static would gain little in performance, make the code harder to change. Removing unncessary warnings is more important. Change-Id: If3e6aa9c1d92e58b4e7a8e246cf4aace237d7a7b
2014-07-01Add new default settings from Eclipse 4.4Robin Rosenberg1-0/+5
These settings were added by Eclipse simply by touching the project settings. Adding these makes it simpler to see what local changes have been made. Change-Id: Iab0aa62530312eb0c78b03b5c6a632742bcc4978
2014-06-04Prepare 3.5.0-SNAPSHOT buildsRobin Rosenberg2-11/+11
Change-Id: I53bd500188e09ae2e007a58b3cd89aa0805d6f2a Signed-off-by: Robin Rosenberg <>
2014-05-21Prepare post 3.4.0 RC1 buildsMatthias Sohn2-2/+2
Change-Id: Ia8d29046439bc9134acdf7c88ab85ea49c4ddf47 Signed-off-by: Matthias Sohn <>
2014-05-21JGit v3.4.0.201405211411-rc1v3.4.0.201405211411-rc1Matthias Sohn2-2/+2
Change-Id: Ia3834770b9719f64cbdfd0338034c392fa3ae5db Signed-off-by: Matthias Sohn <>

Back to the top