Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-09-07Prepare 6.8.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: Ifc81f0a96c2ced0b25926b9daa539d9cfc951925
2023-09-07Prepare 6.7.1-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I96097ef8c6f198220f513bbc6d5f8881834a1491
2023-09-05JGit v6.7.0.202309050840-rv6.7.0.202309050840-rMatthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Ibe952d97bc178adb909cdd40f48957f5b68af699
2023-08-30Prepare 6.7.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I49751232464e70b7d1dc3292a9f36b7a7015e44f
2023-08-30JGit v6.7.0.202308301100-rc1v6.7.0.202308301100-rc1Matthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: I712a9f6830364ed404d03f3a145c055906273544
2023-08-30Update Orbit to orbit-aggregation/release/4.29.0Matthias Sohn1-2/+2
Switch to bundle dependencies for hamcrest 1.3 to avoid issues with split packages in that version. Don't allow hamcrest 2.x yet since junit 4.13.2 still requires hamcrest 1.3. See Orbit restructuring in https://github.com/orgs/eclipse-orbit/discussions/49 Change-Id: I8faf519b8f2c4e4a6bd255d694d1aa28017acd85
2023-06-15Fix all Javadoc warnings and fail on themAntoine Musso2-7/+0
This fixes all the javadoc warnings, stops ignoring doclint 'missing' category and fails the build on javadoc warnings for public and protected classes and class members. Since javadoc doesn't allow access specifiers when specifying doclint configuration we cannot set `-Xdoclint:all,-missing/private` hence there is no simple way to skip private elements from doclint. Therefore we check javadoc using the Eclipse Java compiler (which is used by default) and javadoc configuration in `.settings/org.eclipse.jdt.core.prefs` files. This allows more fine grained configuration. We can reconsider this when javadoc starts supporting access specifiers in the doclint configuration. Below are detailled explanations for most modifications. @inheritDoc =========== doclint complains about explicits `{@inheritDoc}` when the parent does not have any documentation. As far as I can tell, javadoc defaults to inherit comments and should only be used when one wants to append extra documentation from the parent. Given the parent has no documentation, remove those usages which doclint complains about. In some case I have moved up the documentation from the concrete class up to the abstract class. Remove `{@inheritDoc}` on overriden methods which don't add additional documentation since javadoc defaults to inherit javadoc of overridden methods. @value to @link =============== In PackConfig, DEFAULT_SEARCH_FOR_REUSE_TIMEOUT and similar are forged from Integer.MAX_VALUE and are thus not considered constants (I guess cause the value would depends on the platform). Replace it with a link to `Integer.MAX_VALUE`. In `StringUtils.toBoolean`, @value was used to refer to the `stringValue` parameter. I have replaced it with `{@code stringValue}`. {@link <url>} to <a> ==================== @link does not support being given an external URL. Replaces them with HTML `<a>`. @since: being invalid ===================== org.eclipse.jgit/src/org/eclipse/jgit/util/Equality.java has an invalid tag `@since: ` due to the extra `:`. Javadoc does not complain about it with version 11.0.18+10 but does with 11.0.19.7. It is invalid regardless. invalid HTML syntax =================== - javadoc doesn't allow <br/>, <p/> and </p> anymore, use <br> and <p> instead - replace <tt>code</tt> by {@code code} - <table> tags don't allow summary attribute, specify caption as <caption>caption</caption> to fix this doclint visibility issue ======================== In the private abstract classes `BaseDirCacheEditor` and `BasePackConnection` links to other methods in the abstract class are inherited in the public subclasses but doclint gets confused and considers them unreachable. The HTML documentation for the sub classes shows the relative links in the sub classes, so it is all correct. It must be a bug somewhere in javadoc. Mute those warnings with: @SuppressWarnings("doclint:missing") Misc ==== Replace `<` and `>` with HTML encoded entities (`&lt; and `&gt;`). In `SshConstants` I went enclosing a serie of -> arrows in @literal. Additional tags =============== Configure maven-javad0c-plugin to allow the following additional tags defined in https://openjdk.org/jeps/8068562: - apiNote - implSpec - implNote Missing javadoc =============== Add missing @params and descriptions Change-Id: I840056389aa59135cfb360da0d5e40463ce35bd0 Also-By: Matthias Sohn <matthias.sohn@sap.com>
2023-05-24Prepare 6.7.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I50ff7ee31046cfc29a087c8963be3deae24b1c9c
2023-05-03Add TransportHttp#getAdditionalHeadersMatthias Sohn1-1/+9
to enable inspecting which additional HTTP headers have been set on the transport. Change-Id: I0771be9cb7c837de7c203b7f044109b9b2a7d7ad
2023-05-02Update slf4j to 1.7.36 and consume it directly from Maven CentralMatthias Sohn1-1/+1
BundleSymbolicNames changed to the names used upstream: - slf4j.api - slf4j.simple Change-Id: Ibcaafae282d3a6fa013bc39d879def1b66073bca
2023-03-01Prepare 6.6.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I17893f9db12bcb208866f40a06cd4f1ccbb4fe30
2022-11-23Prepare 6.5.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I4238b6181e96e22e540cf34802a332f868cb6dfb
2022-11-16Merge branch 'stable-6.3'Matthias Sohn1-6/+6
* stable-6.3: [benchmarks] Remove profiler configuration Add SHA1 benchmark [benchmarks] Set version of maven-compiler-plugin to 3.8.1 Fix running JMH benchmarks Add option to allow using JDK's SHA1 implementation Fix API breakage caused by extracting WorkTreeUpdater Extract Exception -> HTTP status code mapping for reuse Don't handle internal git errors as an HTTP error Ignore IllegalStateException if JVM is already shutting down Allow to perform PackedBatchRefUpdate without locking loose refs Change-Id: Ib58879be292c54a2a7f4936ac0986997985c822b
2022-11-16Merge branch 'stable-6.2' into stable-6.3Matthias Sohn1-6/+6
* stable-6.2: Extract Exception -> HTTP status code mapping for reuse Don't handle internal git errors as an HTTP error Allow to perform PackedBatchRefUpdate without locking loose refs Change-Id: I562be0802efa231023c5f10e6461339b2d7fbacf
2022-11-16Merge branch 'stable-6.1' into stable-6.2Matthias Sohn1-6/+6
* stable-6.1: Extract Exception -> HTTP status code mapping for reuse Don't handle internal git errors as an HTTP error Allow to perform PackedBatchRefUpdate without locking loose refs Change-Id: Icb321779184d20f3871e236fda1a3acba605a6da
2022-11-10Don't handle internal git errors as an HTTP errorSven Selberg1-6/+6
The fix that fixed the propagation of error-codes: 8984e1f66 HTTP Smart: set correct HTTP status on error [1] made some faulty assumptions. "Wants not valid", can be an intermittent git error and the HTTP response should be 200 and not 400 since the request isn't necessary faulty. [1] https://git.eclipse.org/r/c/jgit/jgit/+/192677 Bug: 579676 Change-Id: I461bc78ff6e450636811ece50d21c57a2a7f2ae3
2022-09-14Prepare 6.4.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I47ca5f1d0263caa0bfc7c303042360c6c5ac4dec
2022-09-12Prepare 6.3.1-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I44e159eca4131880d74d3078060e7e20f9b5ce76
2022-09-07JGit v6.3.0.202209071007-rv6.3.0.202209071007-rMatthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Iea3fae9f6f6c5fb0a79f7684334a3e0059738c4f
2022-09-07JGit v6.3.0.2022009070944-rMatthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: I3cc78dbcf8c7970e80bf1499751611110ec2b30b
2022-08-17Prepare 6.3.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: Ie398b651c5308ec86812bf01fcc563d3e679c828
2022-08-16JGit v6.3.0.202208161710-m3v6.3.0.202208161710-m3Matthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: I0954d11a1f35eff196b157df3aa8386476c48a7e
2022-07-31Fetch: add support for shallowRobin Müller1-0/+109
This adds support for shallow cloning. The CloneCommand and the FetchCommand now have the new methods setDepth, setShallowSince and addShallowExclude to tell the server that the client doesn't want to download the complete history. Bug: 475615 Change-Id: Ic80fb6efb5474543ae59be590ebe385bec21cc0d
2022-06-07Prepare 6.2.1-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I4a0f3919ff43a3b9fafa85b8ecec2d760b7eb161
2022-06-07JGit v6.2.0.202206071550-rv6.2.0.202206071550-rMatthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Ib4ae85a0cabcc9cb867f2c85034d72fb676a500a
2022-06-06Prepare 6.3.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: I092fdd2c35d85bf35e3ef700aa7078e6d304d977
2022-06-06Prepare 6.2.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: Id2ad8d5b561620723b2c52c86909321d628de12f
2022-06-01JGit v6.2.0.202206011217-rc1v6.2.0.202206011217-rc1Matthias Sohn2-2/+2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Id9639b466583d8c373ef700402cb685ce4a8ee15
2022-05-26Prepare 6.2.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I9d6afd80cc024d6e03aa46bbaaaeec10b60fb485
2022-05-25JGit v6.2.0.202205251150-m3v6.2.0.202205251150-m3Matthias Sohn2-2/+2
Change-Id: I48492aef02c2ea39cec171d84e92643859e064a6 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2022-05-09Merge branch 'stable-6.1' into stable-6.2Matthias Sohn2-9/+24
* stable-6.1: HTTP Smart: set correct HTTP status on error Change-Id: I792d6cdfe9e76a3d2e6d1e01ec1dc96805ed2900
2022-05-09HTTP Smart: set correct HTTP status on errorSven Selberg2-9/+24
Previous behavior was that status code was automatically set to 200 regardless of reported status and according to HTTP Smart protocol[1]: If there is no repository at $GIT_URL, or the resource pointed to by a location matching $GIT_URL does not exist, the server MUST NOT respond with 200 OK response. A server SHOULD respond with 404 Not Found, 410 Gone, or any other suitable HTTP status code which does not imply the resource exists as requested. Since the jgit HTTP client isn't able to handle reading content from a response reporting an error (calling HttpURLConnection#getInputStream on a "failed" connection throws an exception and the internal interface HttpConnection does not expose HttpURLConnection#getErrorStream) the SmartClientSmartServerTest needed to be rewritten to expect the generic response messages. [1] https://git-scm.com/docs/http-protocol#_general_request_processing Bug: 579676 Change-Id: Ibb942d02124a0bc279df09600b091354019ce064
2022-05-05Prepare 6.2.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: Ic3788b38d6408e83729caa718c128a5632798a60
2022-05-04JGit v6.2.0.202205041315-m2v6.2.0.202205041315-m2Matthias Sohn2-2/+2
Change-Id: Ie13beac020e79182a4058ba67550bb78b2008833 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2022-03-08Prepare 6.1.1-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: Ifc80355025d8459245843be1c24dc5a286913e77
2022-03-08JGit v6.1.0.202203080745-rv6.1.0.202203080745-rMatthias Sohn2-2/+2
Change-Id: I8766ed400020c9571f321bbbfe34b0688af0107d Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2022-03-03Prepare 6.2.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: Ic2dde88bee3242169d6fa50956f8938f3fc4ba8e
2022-03-02Prepare 6.1.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I525fc1258a729c36d63fdb3c8170e9f04ad55cec
2022-03-02JGit v6.1.0.202203021511-rc1v6.1.0.202203021511-rc1Matthias Sohn2-2/+2
Change-Id: I4c75a58fd76102e773af4f1f8a1487d5e7ffc7cf Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2022-03-01Prepare 6.1.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I30a89277373ad62c857151532942e135e34d1d0c
2022-02-22JGit v6.1.0.202202221755-m3v6.1.0.202202221755-m3Matthias Sohn2-2/+2
Change-Id: Idcd46e05ca3eec376f8ac83209dba0978e004f9a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2022-01-30[test] Fix closing of test repositoriesNail Samatov2-0/+2
Fix tests failing on Windows because Repository instance is created but not closed on tear down. Fix repositories closed twice, except in tests that test this behavior explicitly. Name the temporary directories the tests run in after the test method; that makes it easier to figure out in which tests repositories are closed twice if it should occur again in the future. Bug: 550111 Change-Id: I9398b58f0f36d2c29236d2a9a8599117d9083980 Signed-off-by: Nail Samatov <sanail@yandex.ru> Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2022-01-05Merge branch 'stable-6.0'Thomas Wolf1-2/+1
* stable-6.0: Use slf4j-simple instead of log4j for logging Update orbit to R20211213173813 Change-Id: I746b7fb71571020ce49f7b50fd675c9864327719 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2022-01-05Merge branch 'stable-5.13' into stable-6.0Thomas Wolf1-2/+1
* stable-5.13: Use slf4j-simple instead of log4j for logging Update orbit to R20211213173813 Change-Id: I219ef3901c1d908b91bf9c8f00431b22686ff7a5 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2021-12-31Use slf4j-simple instead of log4j for loggingMatthias Sohn1-2/+1
JGit uses slf4j-api as logging API. The libraries - org.eclipse.jgit.http.test - org.eclipse.jgit.pgm - org.eclipse.jgit.ssh.apache.test - org.eclipse.jgit.test used the outdated log4j 1.2.15 which is EOL since years. Since both jgit command line and also the tests don't need sophisticated logging features replace log4j with the much simpler slf4j-simple log implementation. The org.slf4j.binding.simple 1.7.30 archive has only 25kB instead of 429kB for log4j 1.2.15 Applications using jgit are free to choose any other log implementation supporting slf4j API. Change-Id: I89e85cd3c76e954c3434622510975ce65dc227d4
2021-11-29Prepare 6.0.1-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: Iddb67ed9578293b83b8147aa18dd8319426f83d1
2021-11-29JGit v6.0.0.202111291000-rv6.0.0.202111291000-rMatthias Sohn2-2/+2
Change-Id: I6441d9226e8131552bfafe1fb2c353f2e07e42ac Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2021-11-24Prepare 6.1.0-SNAPSHOT buildsMatthias Sohn2-22/+22
Change-Id: Ied07b1298bd32672a5025cec5079440ab9b9a100
2021-11-24Prepare 6.0.0-SNAPSHOT buildsMatthias Sohn2-2/+2
Change-Id: I4e06186cf62681767962e391331cc65bafddc205
2021-11-24JGit v6.0.0.202111241155-rc1v6.0.0.202111241155-rc1Matthias Sohn2-2/+2
Change-Id: I35dc089a00ee12f83f506fb320d23762fa030063 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Back to the top