Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Rosenberg2012-11-25 16:17:20 +0000
committerRobin Rosenberg2012-12-27 15:57:38 +0000
commitc310fa0c802f40a774edb58641de3ac5bfad0e2c (patch)
tree28dc002136ce8a2c122e2cb012a317aa7d8a0efa /org.eclipse.jgit.ui
parent03d50dc50b584caf2826f7db8a4748435b610f63 (diff)
downloadjgit-c310fa0c802f40a774edb58641de3ac5bfad0e2c.tar.gz
jgit-c310fa0c802f40a774edb58641de3ac5bfad0e2c.tar.xz
jgit-c310fa0c802f40a774edb58641de3ac5bfad0e2c.zip
Mark non-externalizable strings as such
A few classes such as Constanrs are marked with @SuppressWarnings, as are toString() methods with many liternal, but otherwise $NLS-n$ is used for string containing text that should not be translated. A few literals may fall into the gray zone, but mostly I've tried to only tag the obvious ones. Change-Id: I22e50a77e2bf9e0b842a66bdf674e8fa1692f590
Diffstat (limited to 'org.eclipse.jgit.ui')
-rw-r--r--org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AWTPlotRenderer.java2
-rw-r--r--org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AwtAuthenticator.java6
-rw-r--r--org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/CommitGraphPane.java13
3 files changed, 11 insertions, 10 deletions
diff --git a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AWTPlotRenderer.java b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AWTPlotRenderer.java
index e699a72cfa..25d9f97ced 100644
--- a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AWTPlotRenderer.java
+++ b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AWTPlotRenderer.java
@@ -176,7 +176,7 @@ final class AWTPlotRenderer extends AbstractPlotRenderer<SwingLane, Color>
g.setBackground(new Color(colorComponents[0],colorComponents[1],colorComponents[2]));
}
if (txt.length() > 12)
- txt = txt.substring(0,11) + "\u2026"; // ellipsis "…" (in UTF-8)
+ txt = txt.substring(0,11) + "\u2026"; // ellipsis "…" (in UTF-8) //$NON-NLS-1$
final int texth = g.getFontMetrics().getHeight();
int textw = g.getFontMetrics().stringWidth(txt);
diff --git a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AwtAuthenticator.java b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AwtAuthenticator.java
index 6728d616da..486bbf6ab6 100644
--- a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AwtAuthenticator.java
+++ b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/AwtAuthenticator.java
@@ -75,13 +75,13 @@ public class AwtAuthenticator extends CachedAuthenticator {
final StringBuilder instruction = new StringBuilder();
instruction.append(UIText.get().enterUsernameAndPasswordFor);
- instruction.append(" ");
+ instruction.append(" "); //$NON-NLS-1$
if (getRequestorType() == RequestorType.PROXY) {
instruction.append(getRequestorType());
- instruction.append(" ");
+ instruction.append(" "); //$NON-NLS-1$
instruction.append(getRequestingHost());
if (getRequestingPort() > 0) {
- instruction.append(":");
+ instruction.append(":"); //$NON-NLS-1$
instruction.append(getRequestingPort());
}
} else {
diff --git a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/CommitGraphPane.java b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/CommitGraphPane.java
index 9c9d1f4a5c..0752dceec4 100644
--- a/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/CommitGraphPane.java
+++ b/org.eclipse.jgit.ui/src/org/eclipse/jgit/awtui/CommitGraphPane.java
@@ -94,7 +94,8 @@ public class CommitGraphPane extends JTable {
int h = 0;
for (int i = 0; i<getColumnCount(); ++i) {
TableCellRenderer renderer = getDefaultRenderer(getColumnClass(i));
- Component c = renderer.getTableCellRendererComponent(this, "ÅOj", false, false, 0, i);
+ Component c = renderer.getTableCellRendererComponent(this,
+ "ÅOj", false, false, 0, i); //$NON-NLS-1$
h = Math.max(h, c.getPreferredSize().height);
}
setRowHeight(h + getRowMargin());
@@ -129,7 +130,7 @@ public class CommitGraphPane extends JTable {
final TableColumn author = cols.getColumn(1);
final TableColumn date = cols.getColumn(2);
- graph.setHeaderValue("");
+ graph.setHeaderValue(""); //$NON-NLS-1$
author.setHeaderValue(UIText.get().author);
date.setHeaderValue(UIText.get().date);
@@ -186,9 +187,9 @@ public class CommitGraphPane extends JTable {
final String valueStr;
if (pi != null)
- valueStr = pi.getName() + " <" + pi.getEmailAddress() + ">";
+ valueStr = pi.getName() + " <" + pi.getEmailAddress() + ">"; //$NON-NLS-1$ //$NON-NLS-2$
else
- valueStr = "";
+ valueStr = ""; //$NON-NLS-1$
return super.getTableCellRendererComponent(table, valueStr,
isSelected, hasFocus, row, column);
}
@@ -198,7 +199,7 @@ public class CommitGraphPane extends JTable {
private static final long serialVersionUID = 1L;
private final DateFormat fmt = new SimpleDateFormat(
- "yyyy-MM-dd HH:mm:ss");
+ "yyyy-MM-dd HH:mm:ss"); //$NON-NLS-1$
public Component getTableCellRendererComponent(final JTable table,
final Object value, final boolean isSelected,
@@ -209,7 +210,7 @@ public class CommitGraphPane extends JTable {
if (pi != null)
valueStr = fmt.format(pi.getWhen());
else
- valueStr = "";
+ valueStr = ""; //$NON-NLS-1$
return super.getTableCellRendererComponent(table, valueStr,
isSelected, hasFocus, row, column);
}

Back to the top