diff options
| author | David Pursehouse | 2020-01-27 00:47:05 +0000 |
|---|---|---|
| committer | Matthias Sohn | 2020-01-27 13:40:08 +0000 |
| commit | 4cc13297ccf1fa3e982bbb5638162b3bad63f93c (patch) | |
| tree | 3f0b0c0aead716773d569e0b2eb1efb3b6f02081 /org.eclipse.jgit.junit | |
| parent | 0e4a717870f64e667e657650f12e93d477d369c3 (diff) | |
| download | jgit-4cc13297ccf1fa3e982bbb5638162b3bad63f93c.tar.gz jgit-4cc13297ccf1fa3e982bbb5638162b3bad63f93c.tar.xz jgit-4cc13297ccf1fa3e982bbb5638162b3bad63f93c.zip | |
ErrorProne: Enable and fix UnusedException check
Enable UnusedException at ERROR level which causes the build to fail
in many places with:
[UnusedException] This catch block catches an symbol and re-throws
another, but swallows the caught symbol rather than setting it as a
cause. This can make debugging harder.
Fix it by setting the caught exception as cause on the subsequently
thrown exception.
Note: The grammatically incorrect error message is copy-pasted as-is
from the version of ErrorProne currently used in Bazel; it has been
fixed by [1] in the latest version.
[1] https://github.com/google/error-prone/commit/d57a39c
Change-Id: I11ed38243091fc12f64f1b2db404ba3f1d2e98b5
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Diffstat (limited to 'org.eclipse.jgit.junit')
| -rw-r--r-- | org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java index d68c5c891b..a5b3b1f3ac 100644 --- a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java +++ b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java @@ -973,7 +973,7 @@ public class TestRepository<R extends Repository> implements AutoCloseable { try { lck.write(bin); } catch (IOException ioe) { - throw new ObjectWritingException("Can't write " + p); + throw new ObjectWritingException("Can't write " + p, ioe); } if (!lck.commit()) throw new ObjectWritingException("Can't write " + p); |