Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Wilkins2013-06-24 03:13:03 +0000
committerGreg Wilkins2013-06-24 03:13:03 +0000
commit068e67a8df4d65d1c3645659ffb8e2582171b7a1 (patch)
tree2656a794adc2d05fb31c55c59c501adf2e21f23e
parentb2b2ce25fc5caa7383a78600d0bfa070370f237b (diff)
downloadorg.eclipse.jetty.project-068e67a8df4d65d1c3645659ffb8e2582171b7a1.tar.gz
org.eclipse.jetty.project-068e67a8df4d65d1c3645659ffb8e2582171b7a1.tar.xz
org.eclipse.jetty.project-068e67a8df4d65d1c3645659ffb8e2582171b7a1.zip
Code cleanups for direct RequestDispatcher access
-rw-r--r--jetty-server/src/main/java/org/eclipse/jetty/server/Response.java9
-rw-r--r--jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java9
2 files changed, 10 insertions, 8 deletions
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
index 272955324c..2ab4e6c9f0 100644
--- a/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
+++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java
@@ -26,6 +26,7 @@ import java.util.Collections;
import java.util.Enumeration;
import java.util.Locale;
+import javax.servlet.RequestDispatcher;
import javax.servlet.ServletOutputStream;
import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletResponse;
@@ -341,10 +342,10 @@ public class Response implements HttpServletResponse
error_handler = _connection.getConnector().getServer().getBean(ErrorHandler.class);
if (error_handler!=null)
{
- request.setAttribute(Dispatcher.ERROR_STATUS_CODE,new Integer(code));
- request.setAttribute(Dispatcher.ERROR_MESSAGE, message);
- request.setAttribute(Dispatcher.ERROR_REQUEST_URI, request.getRequestURI());
- request.setAttribute(Dispatcher.ERROR_SERVLET_NAME,request.getServletName());
+ request.setAttribute(RequestDispatcher.ERROR_STATUS_CODE,new Integer(code));
+ request.setAttribute(RequestDispatcher.ERROR_MESSAGE, message);
+ request.setAttribute(RequestDispatcher.ERROR_REQUEST_URI, request.getRequestURI());
+ request.setAttribute(RequestDispatcher.ERROR_SERVLET_NAME,request.getServletName());
error_handler.handle(null,_connection.getRequest(),_connection.getRequest(),this );
}
else
diff --git a/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java b/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java
index 14e5fe054c..9aff148ce9 100644
--- a/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java
+++ b/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java
@@ -38,6 +38,7 @@ import javax.servlet.AsyncContext;
import javax.servlet.DispatcherType;
import javax.servlet.Filter;
import javax.servlet.FilterChain;
+import javax.servlet.RequestDispatcher;
import javax.servlet.Servlet;
import javax.servlet.ServletContext;
import javax.servlet.ServletException;
@@ -562,8 +563,8 @@ public class ServletHandler extends ScopedHandler
if (!response.isCommitted())
{
- request.setAttribute(Dispatcher.ERROR_EXCEPTION_TYPE,th.getClass());
- request.setAttribute(Dispatcher.ERROR_EXCEPTION,th);
+ request.setAttribute(RequestDispatcher.ERROR_EXCEPTION_TYPE,th.getClass());
+ request.setAttribute(RequestDispatcher.ERROR_EXCEPTION,th);
if (th instanceof UnavailableException)
{
UnavailableException ue = (UnavailableException)th;
@@ -588,8 +589,8 @@ public class ServletHandler extends ScopedHandler
// TODO httpResponse.getHttpConnection().forceClose();
if (!response.isCommitted())
{
- request.setAttribute(Dispatcher.ERROR_EXCEPTION_TYPE,e.getClass());
- request.setAttribute(Dispatcher.ERROR_EXCEPTION,e);
+ request.setAttribute(RequestDispatcher.ERROR_EXCEPTION_TYPE,e.getClass());
+ request.setAttribute(RequestDispatcher.ERROR_EXCEPTION,e);
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
}
else

Back to the top