diff options
| author | Lars Vogel | 2017-12-11 10:12:13 +0000 |
|---|---|---|
| committer | Noopur Gupta | 2017-12-20 10:19:52 +0000 |
| commit | da6623602e470797e52f788591707cde85a3ee75 (patch) | |
| tree | 2d991da3f205ed415d349eca72a38f0dad2a593b | |
| parent | a1ea8707e65decd4f30c5e922ec29a2dc8f2208e (diff) | |
| download | eclipse.jdt.ui-da6623602e470797e52f788591707cde85a3ee75.tar.gz eclipse.jdt.ui-da6623602e470797e52f788591707cde85a3ee75.tar.xz eclipse.jdt.ui-da6623602e470797e52f788591707cde85a3ee75.zip | |
Bug 519783 - Adopt to change in - HTMLPrinter should migrate to
StringBuilder
Replaced all calls to HtmlPrinter to StringBuilder, so that we can
remove the internal API in platform.text
Change-Id: Ibde42396c4b59593c0c962b23fc3bb29cee9132d
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
6 files changed, 11 insertions, 11 deletions
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java index 5cd4a8d660..535741d685 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java @@ -937,7 +937,7 @@ public class JavadocView extends AbstractInfoView { if (input instanceof String) { javadocHtml= (String) input; } else { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); HTMLPrinter.insertPageProlog(buffer, 0, fForegroundColorRGB, fBackgroundColorRGB, fgStyleSheet); HTMLPrinter.addPageEpilog(buffer); javadocHtml= buffer.toString(); @@ -957,7 +957,7 @@ public class JavadocView extends AbstractInfoView { if (javadocHtml != null && javadocHtml.length() > 0) { boolean RTL= (getSite().getShell().getStyle() & SWT.RIGHT_TO_LEFT) != 0; if (RTL) { - StringBuffer buffer= new StringBuffer(javadocHtml); + StringBuilder buffer= new StringBuilder(javadocHtml); HTMLPrinter.insertStyles(buffer, new String[] { "direction:rtl" } ); //$NON-NLS-1$ javadocHtml= buffer.toString(); } @@ -988,7 +988,7 @@ public class JavadocView extends AbstractInfoView { * @return a string with the Javadoc in HTML format, or <code>null</code> if none */ private String getJavadocHtml(IJavaElement[] result, IWorkbenchPart activePart, ISelection selection, IProgressMonitor monitor) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); int nResults= result.length; if (nResults == 0) diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTMLAnnotationHover.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTMLAnnotationHover.java index e2906b87e0..7b4525fa3b 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTMLAnnotationHover.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/HTMLAnnotationHover.java @@ -42,7 +42,7 @@ public class HTMLAnnotationHover extends DefaultAnnotationHover { */ @Override protected String formatSingleMessage(String message) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); HTMLPrinter.addPageProlog(buffer); HTMLPrinter.addParagraph(buffer, HTMLPrinter.convertToHTMLContent(message)); HTMLPrinter.addPageEpilog(buffer); @@ -54,7 +54,7 @@ public class HTMLAnnotationHover extends DefaultAnnotationHover { */ @Override protected String formatMultipleMessages(List<String> messages) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); HTMLPrinter.addPageProlog(buffer); HTMLPrinter.addParagraph(buffer, HTMLPrinter.convertToHTMLContent(JavaUIMessages.JavaAnnotationHover_multipleMarkersAtThisLine)); diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AbstractJavaCompletionProposal.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AbstractJavaCompletionProposal.java index 5d039aa529..73e4589069 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AbstractJavaCompletionProposal.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AbstractJavaCompletionProposal.java @@ -602,7 +602,7 @@ public abstract class AbstractJavaCompletionProposal implements IJavaCompletionP if (getProposalInfo() != null) { String info= getProposalInfo().getInfo(monitor); if (info != null && info.length() > 0) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); ColorRegistry registry = JFaceResources.getColorRegistry(); RGB fgRGB = registry.getRGB("org.eclipse.jdt.ui.Javadoc.foregroundColor"); //$NON-NLS-1$ diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java index 6faa26159e..eb522e5a59 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java @@ -717,7 +717,7 @@ public class JavadocHover extends AbstractJavaEditorTextHover { * @since 3.4 */ public static JavadocBrowserInformationControlInput getHoverInfo(IJavaElement[] elements, ITypeRoot editorInputElement, IRegion hoverRegion, JavadocBrowserInformationControlInput previousInput) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); boolean hasContents= false; String base= null; IJavaElement element= null; @@ -1142,7 +1142,7 @@ public class JavadocHover extends AbstractJavaEditorTextHover { return buf.toString(); } - public static void addAnnotations(StringBuffer buf, IJavaElement element, ITypeRoot editorInputElement, IRegion hoverRegion) { + public static void addAnnotations(StringBuilder buf, IJavaElement element, ITypeRoot editorInputElement, IRegion hoverRegion) { try { if (element instanceof IAnnotatable) { String annotationString= getAnnotations(element, editorInputElement, hoverRegion); diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/NLSStringHover.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/NLSStringHover.java index beaea6d87b..090ec1a691 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/NLSStringHover.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/NLSStringHover.java @@ -215,7 +215,7 @@ public class NLSStringHover extends AbstractJavaEditorTextHover { } private String toHtml(String header, String string, String errorString, boolean addPreFormatted) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); HTMLPrinter.addSmallHeader(buffer, header); if (string != null) { diff --git a/org.eclipse.ltk.ui.refactoring/src/org/eclipse/ltk/internal/ui/refactoring/model/RefactoringDescriptorViewer.java b/org.eclipse.ltk.ui.refactoring/src/org/eclipse/ltk/internal/ui/refactoring/model/RefactoringDescriptorViewer.java index 68e21abf2d..b51578989e 100644 --- a/org.eclipse.ltk.ui.refactoring/src/org/eclipse/ltk/internal/ui/refactoring/model/RefactoringDescriptorViewer.java +++ b/org.eclipse.ltk.ui.refactoring/src/org/eclipse/ltk/internal/ui/refactoring/model/RefactoringDescriptorViewer.java @@ -77,7 +77,7 @@ public class RefactoringDescriptorViewer extends Viewer { * @return the input text */ protected String getInputText(final RefactoringDescriptorProxy proxy) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); // XXX: should use style sheet and set dialog font. @@ -114,7 +114,7 @@ public class RefactoringDescriptorViewer extends Viewer { String text= getInputText(fDescriptor); if (text != null && text.length() > 0) { if ((fBrowser.getShell().getStyle() & SWT.RIGHT_TO_LEFT) != 0) { - final StringBuffer buffer= new StringBuffer(text); + final StringBuilder buffer= new StringBuilder(text); HTMLPrinter.insertStyles(buffer, new String[] { "direction:rtl", "overflow:hidden"}); //$NON-NLS-1$ //$NON-NLS-2$ text= buffer.toString(); } |
