Bug 570226 - Give switch statements a default case

Change-Id: I15d362abf1bcb65c84a0b9a561e2c5df37c7e418
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

22 files changed, 61 insertions, 1 deletions

diff --git a/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
index aa18e2b2eb..ce8f59d486 100644
--- a/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
+++ b/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
@@ -67,7 +67,7 @@ org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
 org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=warning
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=error
-org.eclipse.jdt.core.compiler.problem.missingDefaultCase=info
+org.eclipse.jdt.core.compiler.problem.missingDefaultCase=error
 org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=enabled
 org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=error
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
index 27b30307b4..5415d4c28b 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
@@ -493,6 +493,8 @@ public class ASTResolving {
 					}
 				}
 				break;
+			default:
+				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
index ef86d8ec69..7dfbdc4d0e 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
@@ -52,6 +52,8 @@ class MethodReferencesSearchRequestor extends SearchRequestor {
                 case IJavaElement.INITIALIZER:
                     fSearchResults.addMember(member, member, match.getOffset(), match.getOffset()+match.getLength());
                     break;
+				default:
+					break;
             }
         }
     }
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
index c477266f62..9403727ec6 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
@@ -2768,6 +2768,8 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(sn, (FieldAccess) node2);
+			default:
+				break;
 			}
 			break;
 
@@ -2782,6 +2784,8 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(qn, (FieldAccess) node2);
+			default:
+				break;
 			}
 			break;
 
@@ -2796,7 +2800,12 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(fa, (FieldAccess) node2);
+			default:
+				break;
 			}
+			break;
+		default:
+			break;
 		}
 
 		return areVariableBindingsEqual(node1, node2);
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
index 5d1aa31529..ed3acdb09a 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
@@ -1290,6 +1290,8 @@ public class Bindings {
 				return ((IVariableBinding) binding).getVariableDeclaration() == binding;
 			case IBinding.METHOD:
 				return ((IMethodBinding) binding).getMethodDeclaration() == binding;
+			default:
+				break;
 		}
 		return true;
 	}
@@ -1303,6 +1305,8 @@ public class Bindings {
 				return ((IVariableBinding) binding).getVariableDeclaration();
 			case IBinding.METHOD:
 				return ((IMethodBinding) binding).getMethodDeclaration();
+			default:
+				break;
 		}
 		return binding;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
index cd7be3d79b..907fb42d54 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
@@ -248,6 +248,8 @@ public class LinkedNodeFinder  {
 				return NAME;
 			case IProblem.UndefinedType:
 				return TYPE;
+			default:
+				break;
 		}
 		return 0;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
index c7974e005e..b839da7096 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
@@ -186,6 +186,8 @@ public class ScopeAnalyzer {
 					return 'V' + binding.getName();
 				case IBinding.TYPE:
 					return 'T' + binding.getName();
+				default:
+					break;
 			}
 		}
 		return null;
@@ -567,6 +569,8 @@ public class ScopeAnalyzer {
 					return typeBinding;
 				}
 				return typeBinding;
+			default:
+				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
index e49fbffe51..5d25c0cf6d 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
@@ -168,6 +168,9 @@ public final class RefactoringAvailabilityTesterCore  {
 				return null;
 			case ASTNode.EXPRESSION_STATEMENT:
 				node= ((ExpressionStatement)node).getExpression();
+				break;
+			default:
+				break;
 		}
 		switch (node.getNodeType()) {
 			case ASTNode.METHOD_DECLARATION:
@@ -176,6 +179,8 @@ public final class RefactoringAvailabilityTesterCore  {
 			case ASTNode.SUPER_METHOD_INVOCATION:
 			case ASTNode.CONSTRUCTOR_INVOCATION:
 				return unit instanceof ICompilationUnit ? node : null; // don't start on invocations in binary
+			default:
+				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
index a128463298..e0a1c429bc 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
@@ -233,6 +233,8 @@ public class CallInliner {
 			case ASTNode.INITIALIZER:
 				fNumberOfLocals= LocalVariableIndex.perform(declaration);
 				break;
+			default:
+				break;
 		}
 	}
 
@@ -799,6 +801,8 @@ public class CallInliner {
 							currentStatement= node.getElseStatement();
 						}
 						break;
+					default:
+						break;
 				}
 				Assert.isNotNull(currentStatement);
 				fRewrite.replace(currentStatement, block, null);
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
index fee44e89b7..336ab3be1d 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
@@ -1137,6 +1137,9 @@ public class ConvertAnonymousToNestedRefactoring extends Refactoring {
                 		return false;
                 	}
                 }
+					break;
+				default:
+					break;
             }
             current = current.getParent();
         }
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
index 25e4772e38..a89c68dcc6 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
@@ -703,6 +703,8 @@ public class PromoteTempToFieldRefactoring extends Refactoring {
 			case INITIALIZE_IN_METHOD:
 				comment.addSetting(RefactoringCoreMessages.PromoteTempToFieldRefactoring_initialize_method);
 				break;
+			default:
+				break;
 		}
 		String visibility= JdtFlags.getVisibilityString(fVisibility);
 		if ("".equals(visibility)) //$NON-NLS-1$
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
index 5d6a793f3d..3ad32b698a 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
@@ -455,6 +455,8 @@ public abstract class FlowInfo {
 		 		return 4;
 		 	case UNKNOWN:
 		 		return 5;
+			default:
+				break;
 		 }
 		 return -1;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
index 1946d2e433..ecf8a95feb 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
@@ -130,6 +130,8 @@ public final class ArrayType extends TType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
index fd423df8fd..b9d511c6f5 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
@@ -85,6 +85,8 @@ public final class CaptureType extends AbstractTypeVariable {
 
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this.getWildcard());
+			default:
+				break;
 
 		}
 		return false;
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
index 1a138a8c4c..915af7045d 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
@@ -99,6 +99,8 @@ public final class ParameterizedType extends HierarchyType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
index 285c9367cf..03e038b444 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
@@ -130,6 +130,8 @@ public final class PrimitiveType extends TType {
 				}
 			case SHORT :
 				return (fId == BYTE);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
index f522d11f3d..bfc0775354 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
@@ -87,6 +87,8 @@ public final class RawType extends HierarchyType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
index a12cc56929..b3f52be425 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
@@ -79,6 +79,8 @@ public final class StandardType extends HierarchyType {
 
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
index b7b410c50e..02408d4909 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
@@ -75,6 +75,8 @@ public final class TypeVariable extends AbstractTypeVariable {
 				return doExtends((TypeVariable)lhs);
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
+			default:
+				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
index c66f5bf4a0..6aee696d30 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
@@ -60,6 +60,8 @@ public class CommentAnalyzer {
 							break loop;
 						}
 						break;
+					default:
+						break;
 				}
 			}
 		} catch (InvalidInputException e) {
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
index 5ce78b9ac8..61678e700e 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
@@ -315,6 +315,8 @@ public final class SignatureUtil {
 					if (depth == 0)
 						return pos + 1;
 					break;
+				default:
+					break;
 			}
 			pos++;
 		}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
index 5b2b1c5d09..763f07b3d6 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
@@ -710,6 +710,9 @@ public final class JavaModelUtil {
 					else
 						return rawEntry;
 				}
+				break;
+			default:
+				break;
 		}
 		return rawEntry;
 	}