Revert "Bug 570226 - Give switch statements a default case"I20210118-1800

This reverts commit ca21dda307bceba7c277428b01b091122a9ca168.

Reason for revert: Reverting this change until the discussion is finalized on the bug.

Change-Id: Ia412b0197ba6b58c1b69498df7e805bc98f2bc94

22 files changed, 1 insertions, 61 deletions

diff --git a/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
index ce8f59d486..aa18e2b2eb 100644
--- a/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
+++ b/org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.core.prefs
@@ -67,7 +67,7 @@ org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
 org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=warning
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=error
-org.eclipse.jdt.core.compiler.problem.missingDefaultCase=error
+org.eclipse.jdt.core.compiler.problem.missingDefaultCase=info
 org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=enabled
 org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=error
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
index 5415d4c28b..27b30307b4 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/core/manipulation/dom/ASTResolving.java
@@ -493,8 +493,6 @@ public class ASTResolving {
 					}
 				}
 				break;
-			default:
-				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
index 7dfbdc4d0e..ef86d8ec69 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/MethodReferencesSearchRequestor.java
@@ -52,8 +52,6 @@ class MethodReferencesSearchRequestor extends SearchRequestor {
                 case IJavaElement.INITIALIZER:
                     fSearchResults.addMember(member, member, match.getOffset(), match.getOffset()+match.getLength());
                     break;
-				default:
-					break;
             }
         }
     }
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
index 079539dc5f..84b9a96903 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java
@@ -2857,8 +2857,6 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(sn, (FieldAccess) node2);
-			default:
-				break;
 			}
 			break;
 
@@ -2873,8 +2871,6 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(qn, (FieldAccess) node2);
-			default:
-				break;
 			}
 			break;
 
@@ -2889,12 +2885,7 @@ public class ASTNodes {
 
 			case ASTNode.FIELD_ACCESS:
 				return isSameVariable(fa, (FieldAccess) node2);
-			default:
-				break;
 			}
-			break;
-		default:
-			break;
 		}
 
 		return areVariableBindingsEqual(node1, node2);
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
index ed3acdb09a..5d1aa31529 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/Bindings.java
@@ -1290,8 +1290,6 @@ public class Bindings {
 				return ((IVariableBinding) binding).getVariableDeclaration() == binding;
 			case IBinding.METHOD:
 				return ((IMethodBinding) binding).getMethodDeclaration() == binding;
-			default:
-				break;
 		}
 		return true;
 	}
@@ -1305,8 +1303,6 @@ public class Bindings {
 				return ((IVariableBinding) binding).getVariableDeclaration();
 			case IBinding.METHOD:
 				return ((IMethodBinding) binding).getMethodDeclaration();
-			default:
-				break;
 		}
 		return binding;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
index 907fb42d54..cd7be3d79b 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.java
@@ -248,8 +248,6 @@ public class LinkedNodeFinder  {
 				return NAME;
 			case IProblem.UndefinedType:
 				return TYPE;
-			default:
-				break;
 		}
 		return 0;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
index b839da7096..c7974e005e 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ScopeAnalyzer.java
@@ -186,8 +186,6 @@ public class ScopeAnalyzer {
 					return 'V' + binding.getName();
 				case IBinding.TYPE:
 					return 'T' + binding.getName();
-				default:
-					break;
 			}
 		}
 		return null;
@@ -569,8 +567,6 @@ public class ScopeAnalyzer {
 					return typeBinding;
 				}
 				return typeBinding;
-			default:
-				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
index 5d25c0cf6d..e49fbffe51 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTesterCore.java
@@ -168,9 +168,6 @@ public final class RefactoringAvailabilityTesterCore  {
 				return null;
 			case ASTNode.EXPRESSION_STATEMENT:
 				node= ((ExpressionStatement)node).getExpression();
-				break;
-			default:
-				break;
 		}
 		switch (node.getNodeType()) {
 			case ASTNode.METHOD_DECLARATION:
@@ -179,8 +176,6 @@ public final class RefactoringAvailabilityTesterCore  {
 			case ASTNode.SUPER_METHOD_INVOCATION:
 			case ASTNode.CONSTRUCTOR_INVOCATION:
 				return unit instanceof ICompilationUnit ? node : null; // don't start on invocations in binary
-			default:
-				break;
 		}
 		return null;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
index e0a1c429bc..a128463298 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/CallInliner.java
@@ -233,8 +233,6 @@ public class CallInliner {
 			case ASTNode.INITIALIZER:
 				fNumberOfLocals= LocalVariableIndex.perform(declaration);
 				break;
-			default:
-				break;
 		}
 	}
 
@@ -801,8 +799,6 @@ public class CallInliner {
 							currentStatement= node.getElseStatement();
 						}
 						break;
-					default:
-						break;
 				}
 				Assert.isNotNull(currentStatement);
 				fRewrite.replace(currentStatement, block, null);
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
index 336ab3be1d..fee44e89b7 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/ConvertAnonymousToNestedRefactoring.java
@@ -1137,9 +1137,6 @@ public class ConvertAnonymousToNestedRefactoring extends Refactoring {
                 		return false;
                 	}
                 }
-					break;
-				default:
-					break;
             }
             current = current.getParent();
         }
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
index a89c68dcc6..25e4772e38 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/PromoteTempToFieldRefactoring.java
@@ -703,8 +703,6 @@ public class PromoteTempToFieldRefactoring extends Refactoring {
 			case INITIALIZE_IN_METHOD:
 				comment.addSetting(RefactoringCoreMessages.PromoteTempToFieldRefactoring_initialize_method);
 				break;
-			default:
-				break;
 		}
 		String visibility= JdtFlags.getVisibilityString(fVisibility);
 		if ("".equals(visibility)) //$NON-NLS-1$
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
index 3ad32b698a..5d6a793f3d 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
@@ -455,8 +455,6 @@ public abstract class FlowInfo {
 		 		return 4;
 		 	case UNKNOWN:
 		 		return 5;
-			default:
-				break;
 		 }
 		 return -1;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
index ecf8a95feb..1946d2e433 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ArrayType.java
@@ -130,8 +130,6 @@ public final class ArrayType extends TType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
index b9d511c6f5..fd423df8fd 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/CaptureType.java
@@ -85,8 +85,6 @@ public final class CaptureType extends AbstractTypeVariable {
 
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this.getWildcard());
-			default:
-				break;
 
 		}
 		return false;
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
index 915af7045d..1a138a8c4c 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/ParameterizedType.java
@@ -99,8 +99,6 @@ public final class ParameterizedType extends HierarchyType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
index 03e038b444..285c9367cf 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/PrimitiveType.java
@@ -130,8 +130,6 @@ public final class PrimitiveType extends TType {
 				}
 			case SHORT :
 				return (fId == BYTE);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
index bfc0775354..f522d11f3d 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/RawType.java
@@ -87,8 +87,6 @@ public final class RawType extends HierarchyType {
 			case TYPE_VARIABLE: return false;
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
index b3f52be425..a12cc56929 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/StandardType.java
@@ -79,8 +79,6 @@ public final class StandardType extends HierarchyType {
 
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
index 02408d4909..b7b410c50e 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/typeconstraints/types/TypeVariable.java
@@ -75,8 +75,6 @@ public final class TypeVariable extends AbstractTypeVariable {
 				return doExtends((TypeVariable)lhs);
 			case CAPTURE_TYPE:
 				return ((CaptureType)lhs).checkLowerBound(this);
-			default:
-				break;
 		}
 		return false;
 	}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
index 6aee696d30..c66f5bf4a0 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/refactoring/util/CommentAnalyzer.java
@@ -60,8 +60,6 @@ public class CommentAnalyzer {
 							break loop;
 						}
 						break;
-					default:
-						break;
 				}
 			}
 		} catch (InvalidInputException e) {
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
index 61678e700e..5ce78b9ac8 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/template/java/SignatureUtil.java
@@ -315,8 +315,6 @@ public final class SignatureUtil {
 					if (depth == 0)
 						return pos + 1;
 					break;
-				default:
-					break;
 			}
 			pos++;
 		}
diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
index 91d9012bca..ae7d957236 100644
--- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
+++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/util/JavaModelUtil.java
@@ -710,9 +710,6 @@ public final class JavaModelUtil {
 					else
 						return rawEntry;
 				}
-				break;
-			default:
-				break;
 		}
 		return rawEntry;
 	}