Bug 553693: [code mining] Add link to Text Editors preference pageS4_14_0_RC2aS4_14_0_RC2R4_14I20191210-0610I20191204-1800I20191204-0600I20191203-1800

Change-Id: I66c70900d2ba68cda108f1b34e41b6bef5e068df

2 files changed, 16 insertions, 5 deletions

diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorCodeMiningConfigurationBlock.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorCodeMiningConfigurationBlock.java
index 265c3dd1cd..45cb853820 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorCodeMiningConfigurationBlock.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorCodeMiningConfigurationBlock.java
@@ -1,5 +1,5 @@
 /**
- *  Copyright (c) 2018 Angelo ZERR.
+ *  Copyright (c) 2018, 2019 Angelo ZERR.
  *  All rights reserved. This program and the accompanying materials
  *  are made available under the terms of the Eclipse Public License v1.0
  *  which accompanies this distribution, and is available at
@@ -7,6 +7,7 @@
  *
  *  Contributors:
  *     Angelo Zerr <angelo.zerr@gmail.com> - [CodeMining] Provide Java References/Implementation CodeMinings - Bug 529127
+ *     IBM Corporation
  */
 package org.eclipse.jdt.internal.ui.preferences;
 
@@ -19,10 +20,12 @@ import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
+import org.eclipse.swt.widgets.Shell;
 
 import org.eclipse.jface.dialogs.IDialogSettings;
 import org.eclipse.jface.layout.PixelConverter;
 
+import org.eclipse.ui.dialogs.PreferencesUtil;
 import org.eclipse.ui.forms.widgets.ExpandableComposite;
 import org.eclipse.ui.preferences.IWorkbenchPreferenceContainer;
 
@@ -93,7 +96,8 @@ public class JavaEditorCodeMiningConfigurationBlock extends OptionsConfiguration
 	@Override
 	protected Control createContents(Composite parent) {
 		fPixelConverter= new PixelConverter(parent);
-		setShell(parent.getShell());
+		Shell shell= parent.getShell();
+		setShell(shell);
 
 		Composite mainComp= new Composite(parent, SWT.NONE);
 		mainComp.setFont(parent.getFont());
@@ -103,8 +107,15 @@ public class JavaEditorCodeMiningConfigurationBlock extends OptionsConfiguration
 		mainComp.setLayout(layout);
 
 		// Add enabled code mining checkbox
-		Button codeMiningEnabledCheckBox= addCheckBox(mainComp, PreferencesMessages.JavaEditorCodeMiningConfigurationBlock_enableCodeMining_label, PREF_CODEMINING_ENABLED,
-				TRUE_FALSE, 0);
+		String text= PreferencesMessages.JavaEditorCodeMiningConfigurationBlock_enableCodeMining_label;
+		Button codeMiningEnabledCheckBox= addCheckBoxWithLink(mainComp, text, PREF_CODEMINING_ENABLED, TRUE_FALSE, 0, SWT.DEFAULT, new SelectionAdapter() {
+			@Override
+			public void widgetSelected(SelectionEvent e) {
+				if ("org.eclipse.ui.preferencePages.GeneralTextEditor".equals(e.text)) { //$NON-NLS-1$
+					PreferencesUtil.createPreferenceDialogOn(shell, e.text, null, null);
+				}
+			}
+		});
 
 		// - Only if there is at least one result
 		atLeastOneCheckBox= addCheckBox(mainComp,
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/PreferencesMessages.properties b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/PreferencesMessages.properties
index ffb2b4fe7b..65522c1769 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/PreferencesMessages.properties
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/PreferencesMessages.properties
@@ -1016,7 +1016,7 @@ JavaCompilerPropertyPage_ignore_optional_problems_label=&Ignore optional compile
 JavaCompilerPropertyPage_invalid_element_selection=Java Compiler settings cannot be changed for the selected element.
 
 # Code minings
-JavaEditorCodeMiningConfigurationBlock_enableCodeMining_label=&Enable code minings
+JavaEditorCodeMiningConfigurationBlock_enableCodeMining_label=&Enable code minings (also controls code minings of <a href=\"org.eclipse.ui.preferencePages.GeneralTextEditor\">'Text Editors'</a>)
 JavaEditorCodeMiningConfigurationBlock_showCodeMining_atLeastOne_label=Only if there is at &least one result
 JavaEditorCodeMiningConfigurationBlock_common_description=&Select the code minings that you wish to enable/disable:
 JavaEditorCodeMiningConfigurationBlock_section_general=General