diff options
| author | Lars Vogel | 2020-06-05 16:22:39 +0000 |
|---|---|---|
| committer | Jeff Johnston | 2020-06-16 19:30:09 +0000 |
| commit | 365b4d74002add5f9908ff161b734e901f56e14d (patch) | |
| tree | 62cb31b0e60a9c42dcca7f3d7e80403e2220b16d | |
| parent | 5c9bc2c4945c19bacc3510d1ce67ab43025ed618 (diff) | |
| download | eclipse.jdt.debug-365b4d74002add5f9908ff161b734e901f56e14d.tar.gz eclipse.jdt.debug-365b4d74002add5f9908ff161b734e901f56e14d.tar.xz eclipse.jdt.debug-365b4d74002add5f9908ff161b734e901f56e14d.zip | |
Bug 564063 - Using ArrayContentProvider.getInstance() instead of newI20200617-1800I20200616-1800
instance
ArrayContentProvider does not hold any data, hence it can be shared
across instances.
Change-Id: I5ff38114fd1f90ae8c797dc3b993dbee2fa98b85
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java index 265dd350b..e45346b35 100644 --- a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java +++ b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java @@ -191,7 +191,7 @@ public class ExecutionEnvironmentsPreferencePage extends PreferencePage implemen table.setLayout(layout); table.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true)); fProfilesViewer = new TableViewer(table); - fProfilesViewer.setContentProvider(new ArrayContentProvider()); + fProfilesViewer.setContentProvider(ArrayContentProvider.getInstance()); fProfilesViewer.setLabelProvider(new ExecutionEnvironmentsLabelProvider()); fProfilesViewer.setInput(JavaRuntime.getExecutionEnvironmentsManager().getExecutionEnvironments()); diff --git a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java index 04500a3d6..b62e1e89b 100644 --- a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java +++ b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java @@ -116,7 +116,7 @@ public class VMTypePage extends WizardPage { data.widthHint = 300; fTypesViewer.getControl().setFont(composite.getFont()); fTypesViewer.getControl().setLayoutData(data); - fTypesViewer.setContentProvider(new ArrayContentProvider()); + fTypesViewer.setContentProvider(ArrayContentProvider.getInstance()); fTypesViewer.setLabelProvider(new TypeLabelProvider()); fTypesViewer.setComparator(new ViewerComparator()); fTypesViewer.addDoubleClickListener(new IDoubleClickListener() { |