Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-11-20Bug 568959 - NPE when parsing .java file (build and edition assistanceI20201122-1800I20201122-0600I20201121-1800I20201121-0600I20201120-1800I20201120-0320Manoj Palat2-1/+26
broken) Change-Id: I636512094fe88338c3c50ea87909513b144d17ec Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-20Bug 568922 - cannonical constructor for local record throws verify errorManoj Palat3-1/+55
Change-Id: Idbbb8aafab293a2588e8e2adb3a015f5078e2ceb Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-19Bug 568949 - Version increment for jdt bundlesS4_18_0_M3I20201119-0730Jay Arthanareeswaran2-2/+2
Change-Id: Icb7002c94c50ac0899a0f0d325509603fbca0116 Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-18Bug 568514 - [15] Local Enum classes need to flagged for explicitI20201118-1800Manoj Palat2-1/+20
modifiers - strictfp allowed Change-Id: I9b3dcf59cb61c5f7b5b2d97f0801656a9d708c97 Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-17Bug 567532 - Extract methodsI20201118-0600Gunnar Wagenknecht1-365/+217
To avoid issues such as bug 567532, where developers missed to duplicate code this change extracts the code into methods and changes the implementation to call these methods. Change-Id: I66b4aa3e60d5fd716b0c9ce1092fb8126e24c6b4
2020-11-17Bug 567532 - Fix module updates not persisted for test locationsGunnar Wagenknecht2-3/+139
Duplicate reading and writing module patches and updates for testBinaryLocations. This fixes an issue with the first build always being a full build because of improperly persisted state for test classpath locations. Change-Id: If17f0aafe09c36fef738a8ffd3136339f31ae08f
2020-11-17Bug 567532 - Add toString methodsGunnar Wagenknecht1-0/+24
Change-Id: Ia2c8fdd002852ef566813ba0ad3559fac95b9963
2020-11-17Bug 567532 - Improve debug outputGunnar Wagenknecht1-2/+2
Allows to easier spot where a delta is. Change-Id: I905a66459ce9b605ab8938e103e9597ea4f18fe0
2020-11-17Bug 566498 - Capture time spent in findTypesGunnar Wagenknecht2-96/+134
Change-Id: Icab6ba1b6131a7acb0cace98660b981e6a562a21
2020-11-17Bug 565447 - [15] ASTConverter showing pattern variable forI20201117-1800I20201117-0600Sarika Sinha1-2/+13
InstanceOfExpression as final non-sealed Change-Id: I9d9faf99de50b3ee0c0770dca773727ffe1e0598
2020-11-17Bug 563427 - [test] [model] testConvertToModuleJay Arthanareeswaran2-4/+4
testAddInclusionOnPackage failing Change-Id: I5168219dd739a8ef4d400dff7b63e1060000df13 Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-17Bug 568871 - Compiler warnings in jdt.core in latest buildJay Arthanareeswaran2-3/+3
Change-Id: I08b9df727cc375c5aa633e2ffd41c6fafa9ca615 Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-16Bug 565447 - [15] ASTConverter showing pattern variable forI20201116-1800Sarika Sinha2-2/+54
InstanceOfExpression as final non-sealed Change-Id: I50b0a0bebbcad523c961e4a5f8efed98ad5472be
2020-11-16Bug 561544 - NullPointerException in Expression.forcedToBeRaw whenJay Arthanareeswaran2-2/+48
COMPILER_PB_UNAVOIDABLE_GENERIC_TYPE_PROBLEMS is disabled Change-Id: If4e391f6dee7636cda1d1272dace56c622a0e676 Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-16Bug 561199 - [14] [quick fix] Serializable record doesn't require aI20201116-0600Manoj Palat2-0/+22
serialVersionUID Change-Id: Ib22727590181bb936b067437da3b13489d504875
2020-11-14Bug 568802 - regression testAndrey Loskutov1-0/+40
Change-Id: I92f18537f11bfd2c057ccff64f1460f7d07584a9 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-14Revert "Bug 537665 - Cannot parse module-info file standalone."Andrey Loskutov8-70/+8
This reverts commit 5a9f17e0594f387986b9c6f60d367deda690b056.
2020-11-13Bug 561167 - "Source > Cleanup" removes necessary cast of nullI20201115-1800I20201115-0600I20201114-1800I20201114-0740I20201114-0600I20201113-1800Jeff Johnston3-0/+49
- add setVarTypeDeclaration() method to CastExpression to indicate when CastExpression is the initialization of a var type - add logic in CastExpression to disable unnecessary cast checks if we are initializing a var type variable and the type of the cast and expression are not equal - add logic in LocalDeclaration to call CastExpression.setVarTypeDeclaration() when appropriate - add new test to CastTest Change-Id: I43ac031a69796a14be3a00fc2656becec5b38b81 Signed-off-by: Jeff Johnston <jjohnstn@redhat.com>
2020-11-13Bug 568758 - [15] sealed - Use "implement" for interface cases inManoj Palat5-8/+40
message Change-Id: I313a492a52b484cc82482c898a7c0cc342f1a40f Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-12Bug 566979 - No Syntax error seen: when "sealed" token used in method signatureKalyan Prasad Tatavarthi3-15/+79
Change-Id: I51688a2cfac26259814a6fa8ceffb38d64bf7d3c Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-11-12Bug 506230 - [1.9] Message for '_' as identifier needs to be harder inI20201112-1800Sravan Kumar Lakkimsetti6-8/+16
1.9 - Added a new message for the case of java 9 and above. - Selection of message is based on whethe '_' is error or warning. Updated tests as well Change-Id: I464b3063446258d1dab522d7c49a18c8438e2b7f Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2020-11-11Bug 568710 - [15] [javadoc] for @see , @link tags spaces should not be ↵I20201111-1800Kalyan Prasad Tatavarthi2-0/+134
considered as part of the reference type after module name Change-Id: If73d5660724278f17f73e38f6561e0b97e698112 Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-11-11Bug 499037 [9][resource] Include effectively final variables in t-w-r inManoj Palat3-11/+408
resource leak analysis Change-Id: I560561c9ec7f35534154210febe0d31429cd345b Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-10Bug 565609 - some code cleanup in JrtFileSystem.cachePackage()I20201110-1800Andrey Loskutov1-18/+25
- only intern strings if needed - added / fixed comments - restructured if/else chain to make the code easier to understand Change-Id: I5907c51f1d9533580689c625ac9d127a280900a0 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-09Bug 537665 - Cannot parse module-info file standalone.I20201109-1800Roland Grunberg8-8/+70
- Binding resolution of module-info file fails with ASTParser setEnvironment/createASTs API because ClasspathJar does not parse module information, causing issues when resolution of the required module is attempted using the environment - Add testcase Change-Id: I1b94e9b8f3113faa10fbe063707a5631909ef217 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2020-11-08Bug 565609 - NPE in JrtFileSystem.cachePackage(JRTUtil.java:626) onAndrey Loskutov1-1/+1
startup JrtFileSystem.cachePackage() can be called from different threads, and while doing so, there are few possibilities where the threads read/modify shared data in parallel. cachePackage() reads/writes to two different maps, does not aquire additional locks and doesn't call into other classes. Without modifying lot of code safest solution is to declare the entire method synchronized. Change-Id: I7e49385077920f890bf6a7904617025243a30bca Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-06Bug 566853 - [15] record - generate Delegate Methods does not give any outputI20201108-1800I20201107-1800I20201107-0750I20201106-1800I20201106-0710Kalyan Prasad Tatavarthi3-0/+69
Added an API in JDT core to find out if a method is a synthetic record method or not. Change-Id: I80ef0aa44c347f0f1075518f57e81b1d873dce35 Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-11-06Bug 565447 - [15] ASTConverter showing pattern variable forSarika Sinha4-19/+17
InstanceOfExpression as final non-sealed Change-Id: Ib72d64948d137154677c5bb6c16d0305f604ab6d
2020-11-06Bug 566498 - Optimize classpath scanning to selected packages onlyGunnar Wagenknecht3-30/+313
The existing implementation had an O(n) performance where n directly depends on classpath size. Thus, the lookup performance increased directly with the numbers of jars and source folders. The new implementation narrows the scope down to package fragments first. This is achieved by maintaining an index for package names. This change includes a test for JavaSearchNameEnvironment which documents some hidden implementation detail required for the index to work properly. Change-Id: I3bdba84f8aeffbc92b0de3ac86e6e445d906ebb2
2020-11-06Temporarily disabling Bug 541443 comment 6Manoj Palat1-2/+2
Change-Id: Ibc6fb7fab6507d752634fa281f54958efa772232
2020-11-05Bug 566262 - AIOOBE in DiskIndex.readChunkI20201105-1800Simeon Andreev1-0/+5
During JDT indexing of a project its possible that the project is deleted in parallel, deleting also index files for that project. With bad ordering, the indexing can save a "stale" index file after the project is deleted. Re-creating the project and deleting it again (e.g. during tests) can result in DiskIndex throwing an ArrayIndexOutOfBoundsException (AIOOBE). In particular, the AIOOBE is caused by reading a bad value (-1) for DiskIndex.bufferEnd, due to the deleted index file. As a result DiskIndex.readStreamBuffer() will return without resetting DiskIndex.bufferIndex to 0, when the end of DiskIndex.streamBuffer is reached. DiskIndex.readChunk() will then increment DiskIndex.bufferIndex() past the length of the buffer, accessing an invalid index with the next operation and so throwing an exception. This change ensures an IOException is thrown in case DiskIndex.bufferEnd has a bad value and the input stream of DiskIndex has no more available data to read. An IOException is already handled by JDT, unlike an AIOOBE. Change-Id: I1c95d87faf1bf01348c602fb721be1b85b8a7306 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2020-11-05Bug 568535 - [indexer] JobManager.processingThread &Andrey Loskutov1-2/+2
JobManager.executing aren't volatile Changed fields to volatile to make sure different threads see the latest version. Change-Id: I278aaec032d254d45a2be95d8ad631d949b30b05 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-05Bug 568534 -Andrey Loskutov1-1/+1
org.eclipse.jdt.internal.core.search.indexing.IndexRequest.isCancelled is not volatile Changed this field to volatile to make sure different threads see the latest version. Change-Id: I1a0ea6564aa29e9fe870e4eca8f0acda3e27c9a4 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-05Bug 568529 - Broken check pattern for submitting new indexer jobsAndrey Loskutov2-4/+15
Added JobManager.requestIfNotWaiting() method to allow properly synchronized task dispatching. Change-Id: I833182f679286781d504014d2d2b0287840e6070 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-05Bug 568521 - org.eclipse.jdt.internal.core.index.Index.monitor is notAndrey Loskutov1-1/+1
volatile Changed this field to volatile to make sure different threads see the latest version. Change-Id: I51e41af15730c6d6fe1660a7708a1f97815bfdcc Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-11-05Bug 566985 - [15] Compile error should use "interface" instead ofI20201105-0230Manoj Palat2-9/+9
"class" Change-Id: I569e2dabf821ff46bb346ed8da8ef9224eb2aadb Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-04Bug 568514 - [15] Local Enum classes need to flagged for explicitManoj Palat8-38/+100
modifiers Change-Id: I14fde929123d9f0422be9a197b9a43e6e8573709 Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-03Revert incomplete - fix of bug 566979I20201104-1800I20201103-1800Manoj Palat2-5/+5
Change-Id: I4e3806f51ae8a071ff7831c103b6c2a9e587f750
2020-11-03Reverting bug 566979 fixManoj Palat3-8/+8
Change-Id: I1260f6847d47fa2ff5d48c1d9efe470dc1259042 Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-03Bug 568428 - [15] incorrect/No error flagged for sealed/non-sealed localManoj Palat2-18/+101
interfaces respectively Change-Id: Ife12a73af82b40907ddca5673061196fbc915dd1 Signed-off-by: Manoj Palat <manpalat@in.ibm.com>
2020-11-02Bug 566498 - Fix comparisonI20201103-0030I20201102-1910Gunnar Wagenknecht1-1/+1
Identity comparison is wrong in this case. These are handles which need to be checked with equality. Change-Id: Ie4cd5fee213047d550b15d36efeafe714dc17d3b
2020-11-02Bug 565930 - Passing --release option to JDT compiler causes strangeJay Arthanareeswaran3-83/+126
compilation errors Change-Id: I1dfbe77d24f50e76054de36a86567e52cfe527ce Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-02Bug 568333 - Errors reported in parsing compilation logsJay Arthanareeswaran1-102/+125
Change-Id: Ic6417e2efacf188f5d28a3ee2d2ea160cb2bfb59 Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
2020-11-02Bug 566498 - Use a better hash code implementationGunnar Wagenknecht1-1/+5
Although simple addition isn't wrong it's not following best practices for combining hash codes. Change-Id: Iab8c7fb0c0694d592124b3f7853f59bdcc304a6e
2020-11-02Bug 566498 - Use parsed module-info.class from cacheGunnar Wagenknecht1-11/+5
The getter always triggered parsing of the module-info.class file ignoring any cached state. This is especially worrisome for JRT modules, which effectively never change. Change-Id: I0d27adbaa545291dff768b317f8e4960b06539c4
2020-10-31Bug 565462 - SourceLookup + Java 11 + Find Duplicates brokenY20201103-1200Y20201102-1200I20201101-1800I20201031-1800Andrey Loskutov1-0/+29
Provide a way for clients (like debugger) to determine if two non-equal class file objects point to the same physical storage. Change-Id: Ie00303661fd1e6ed5b84bb2a70d1f1da3629b096 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-10-30Tests for bug 566846: [15] record with just an identifier not givingJay Arthanareeswaran1-1/+47
error Change-Id: I4318706ff8bf22d0d917874344a665e0003263b7
2020-10-30Bug 566979 - No Syntax error seen: when "sealed" token used inI20201030-1800Manoj Palat3-7/+112
method signature Change-Id: I5bfb48ab285697caaa69bc826d65cddcfea442d6
2020-10-30Bug 566498 - Collect more timings for analysisGunnar Wagenknecht5-175/+256
Change-Id: I9c8e70fc2daf3cfb5e1744d57e2f65306baf984a
2020-10-29Remove @noreference from text block and yield statement APIsI20201029-1800Noopur Gupta1-4/+2
These preview features have been promoted to standard features now Change-Id: I138f0f61614ece6c4e687d508cb545c9c555db80

Back to the top