Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoerg Kubitz2021-07-01 10:18:52 +0000
committerJeff Johnston2021-09-15 22:29:21 +0000
commit5734e6af8588329da60535da9600c840a1f84dea (patch)
treebf44696313227fe2edd7e2a5ee31a52a17954556 /org.eclipse.jdt.core/dom/org/eclipse/jdt
parentfb40c517f1845863da4b3efea1a0453e22229122 (diff)
downloadeclipse.jdt.core-5734e6af8588329da60535da9600c840a1f84dea.tar.gz
eclipse.jdt.core-5734e6af8588329da60535da9600c840a1f84dea.tar.xz
eclipse.jdt.core-5734e6af8588329da60535da9600c840a1f84dea.zip
Bug 574586 - [dogfooding][cleanup] Use try-with-resource cleanup
Change-Id: Ib4a64d26190545f489891c5a4197e26f7ac31410 Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/182672 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Tested-by: JDT Bot <jdt-bot@eclipse.org> Tested-by: Jeff Johnston <jjohnstn@redhat.com>
Diffstat (limited to 'org.eclipse.jdt.core/dom/org/eclipse/jdt')
-rw-r--r--org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java12
1 files changed, 2 insertions, 10 deletions
diff --git a/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java b/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java
index 932c3cca07..de7c59b880 100644
--- a/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java
+++ b/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTParser.java
@@ -1137,12 +1137,8 @@ public class ASTParser {
} catch(JavaModelException e) {
// an error occured accessing the java element
StringWriter stringWriter = new StringWriter();
- PrintWriter writer = null;
- try {
- writer = new PrintWriter(stringWriter);
+ try (PrintWriter writer = new PrintWriter(stringWriter)) {
e.printStackTrace(writer);
- } finally {
- if (writer != null) writer.close();
}
throw new IllegalStateException(String.valueOf(stringWriter.getBuffer()));
}
@@ -1211,12 +1207,8 @@ public class ASTParser {
} catch(JavaModelException e) {
// an error occured accessing the java element
StringWriter stringWriter = new StringWriter();
- PrintWriter writer = null;
- try {
- writer = new PrintWriter(stringWriter);
+ try (PrintWriter writer = new PrintWriter(stringWriter)) {
e.printStackTrace(writer);
- } finally {
- if (writer != null) writer.close();
}
throw new IllegalStateException(String.valueOf(stringWriter.getBuffer()));
}

Back to the top