Bug 559724 - Manual array copy Use Arrays.asList or System.arraycopyI20200324-1800

instead of copying array in a for
loop

Change-Id: Ide697655e30fe65b99e4b082c8737b7ddd44655b
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

2 files changed, 4 insertions, 6 deletions

diff --git a/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java b/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java
index b1307d94e6..4a4ed03817 100644
--- a/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java
+++ b/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java
@@ -17,6 +17,7 @@ import java.io.File;
 import java.io.IOException;
 import java.net.URLClassLoader;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Iterator;
 import java.util.List;
 import java.util.ServiceConfigurationError;
@@ -115,9 +116,7 @@ public class BatchAnnotationProcessorManager extends BaseAnnotationProcessorMana
 			else if ("-processor".equals(option)) { //$NON-NLS-1$
 				commandLineProcessors = new ArrayList<>();
 				String procs = commandLineArguments[++i];
-				for (String proc : procs.split(",")) { //$NON-NLS-1$
-					commandLineProcessors.add(proc);
-				}
+				commandLineProcessors.addAll(Arrays.asList(procs.split(","))); //$NON-NLS-1$
 				break;
 			}
 		}
diff --git a/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchProcessingEnvImpl.java b/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchProcessingEnvImpl.java
index d18579c645..d13d2cb628 100644
--- a/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchProcessingEnvImpl.java
+++ b/org.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchProcessingEnvImpl.java
@@ -17,6 +17,7 @@ package org.eclipse.jdt.internal.compiler.apt.dispatch;
 import java.lang.reflect.Field;
 import java.nio.charset.Charset;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
@@ -84,9 +85,7 @@ public class BatchProcessingEnvImpl extends BaseProcessingEnvImpl {
 			Charset charset = encoding != null ? Charset.forName(encoding) : null;
 			JavaFileManager manager = new EclipseFileManager(batchCompiler.compilerLocale, charset);
 			ArrayList<String> options = new ArrayList<>();
-			for (String argument : commandLineArguments) {
-				options.add(argument);
-			}
+			options.addAll(Arrays.asList(commandLineArguments));
 			for (Iterator<String> iterator = options.iterator(); iterator.hasNext(); ) {
 				manager.handleOption(iterator.next(), iterator);
 			}