diff options
| author | Stephan Herrmann | 2021-03-18 12:53:02 +0000 |
|---|---|---|
| committer | Manoj Palat | 2021-03-19 03:54:49 +0000 |
| commit | 2af7f7fe05757222d516240b39d11bc70398f1d3 (patch) | |
| tree | 24fd48f6c57f0926d710686185b582f55a01fd7f | |
| parent | f2581b1159c6eae4cec91d9b3e929200fcd7e1b0 (diff) | |
| download | eclipse.jdt.core-2af7f7fe05757222d516240b39d11bc70398f1d3.tar.gz eclipse.jdt.core-2af7f7fe05757222d516240b39d11bc70398f1d3.tar.xz eclipse.jdt.core-2af7f7fe05757222d516240b39d11bc70398f1d3.zip | |
Bug 571640 - JDT Gerrit tests failing with "Cannot run program lsof:
error=2"
Change-Id: I55cfb235218f3acdd3bec31eae0f574d92e8b4ba
3 files changed, 7 insertions, 15 deletions
diff --git a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/AbstractLeakTest.java b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/AbstractLeakTest.java index 31d324d590..6f45710150 100644 --- a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/AbstractLeakTest.java +++ b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/AbstractLeakTest.java @@ -171,7 +171,7 @@ public abstract class AbstractLeakTest extends BuilderTests { // -a : to "and" all following options // -b :to avoid blocking calls // -p <pid>: to select process with opened files - List<String> lines = readLsofLines("lsof -F n -a -p " + pid + " / -b ", true); + List<String> lines = readLsofLines("lsof -F n -a -p " + pid + " -b", true); return lines; } diff --git a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsAfter9.java b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsAfter9.java index 09ea701aad..f9c569a8bf 100644 --- a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsAfter9.java +++ b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsAfter9.java @@ -31,22 +31,18 @@ public class LeakTestsAfter9 extends AbstractLeakTest { return CompilerOptions.VERSION_9; } - /* - * https://bugs.eclipse.org/bugs/show_bug.cgi?id=571640 - * Commenting out the super calls as a workaround - */ @Override public void testLeaksOnCleanBuild() throws Exception { - //super.testLeaksOnCleanBuild(); + super.testLeaksOnCleanBuild(); } @Override public void testLeaksOnFullBuild() throws Exception { - //super.testLeaksOnFullBuild(); + super.testLeaksOnFullBuild(); } @Override public void testLeaksOnIncrementalBuild() throws Exception { - //super.testLeaksOnIncrementalBuild(); + super.testLeaksOnIncrementalBuild(); } } diff --git a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsBefore9.java b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsBefore9.java index 75c23a3e22..f3a837f3bd 100644 --- a/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsBefore9.java +++ b/org.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/LeakTestsBefore9.java @@ -31,22 +31,18 @@ public class LeakTestsBefore9 extends AbstractLeakTest { return CompilerOptions.VERSION_1_4; } - /* - * https://bugs.eclipse.org/bugs/show_bug.cgi?id=571640 - * Commenting out the super calls as a workaround - */ @Override public void testLeaksOnCleanBuild() throws Exception { - //super.testLeaksOnCleanBuild(); + super.testLeaksOnCleanBuild(); } @Override public void testLeaksOnFullBuild() throws Exception { - //super.testLeaksOnFullBuild(); + super.testLeaksOnFullBuild(); } @Override public void testLeaksOnIncrementalBuild() throws Exception { - //super.testLeaksOnIncrementalBuild(); + super.testLeaksOnIncrementalBuild(); } } |