Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephan Herrmann2020-05-15 13:06:33 +0000
committerStephan Herrmann2020-05-15 13:45:57 +0000
commit26ed2eeed70be007d0d75c31379cc16a0c6c4ed2 (patch)
tree2928df9332e491f119b5d28cc2c8dfb5b749fe3e
parent8cf64302cf48ebc8b9e15908bc66f2358cbcccb9 (diff)
downloadeclipse.jdt.core-26ed2eeed70be007d0d75c31379cc16a0c6c4ed2.tar.gz
eclipse.jdt.core-26ed2eeed70be007d0d75c31379cc16a0c6c4ed2.tar.xz
eclipse.jdt.core-26ed2eeed70be007d0d75c31379cc16a0c6c4ed2.zip
Bug 560630 - No warning on unused import on class from same package
- fix for comment 25 Change-Id: I8f4f0937ad5f4734ae020218c7b0f78fd455d6ba
-rw-r--r--org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
index a71e6ae6ea..4f3ab65d38 100644
--- a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
+++ b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
@@ -3560,8 +3560,9 @@ public abstract class Scope {
private boolean isUnnecessarySamePackageImport(Binding resolvedImport, Scope unitScope) {
if (resolvedImport instanceof ReferenceBinding) {
- if (unitScope.getCurrentPackage() == ((ReferenceBinding) resolvedImport).getPackage()) {
- if ((resolvedImport.getAnnotationTagBits() & TagBits.IsNestedType) != 0)
+ ReferenceBinding referenceBinding = (ReferenceBinding) resolvedImport;
+ if (unitScope.getCurrentPackage() == referenceBinding.getPackage()) {
+ if (referenceBinding.isNestedType())
return false; // importing nested types is still necessary
return true;
}

Back to the top