Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimeon Andreev2019-07-30 06:56:42 +0000
committerSimeon Andreev2019-07-30 06:56:42 +0000
commit2d905647ce7b6e58c4064c51029cee2b8e3691c5 (patch)
treedb94893c3d99905ac76ccb9d68d790076e996582
parent1e052a8f67b9f7c8dc2c3f8bb4f7cafc00966e06 (diff)
downloadeclipse.jdt.core-2d905647ce7b6e58c4064c51029cee2b8e3691c5.tar.gz
eclipse.jdt.core-2d905647ce7b6e58c4064c51029cee2b8e3691c5.tar.xz
eclipse.jdt.core-2d905647ce7b6e58c4064c51029cee2b8e3691c5.zip
Bug 549457 - extracted constant for JDT core settings pathI20190801-1800I20190801-0600I20190731-1800I20190730-1800
This change extracts a constant for .settings/org.eclipse.jdt.core.prefs path, to avoid creating a path object on every delta file. Change-Id: Id7f7c2c22f9ce9cf485a1b41fb5ebdc66c422239 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
-rw-r--r--org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java
index 4a363da340..f6a67cf324 100644
--- a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java
+++ b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java
@@ -51,6 +51,7 @@ public static boolean SHOW_STATS = false;
* specify VM property: {@code -Dorg.eclipse.jdt.core.disableAutoBuildOnSettingsChange=true}
*/
private static final boolean DISABLE_AUTO_BUILDING_ON_SETTINGS_CHANGE = Boolean.getBoolean("org.eclipse.jdt.core.disableAutoBuildOnSettingsChange"); //$NON-NLS-1$
+private static final IPath JDT_CORE_SETTINGS_PATH = Path.fromPortableString(JavaProject.DEFAULT_PREFERENCES_DIRNAME + IPath.SEPARATOR + JavaProject.JAVA_CORE_PREFS_FILE);
/**
* A list of project names that have been built.
@@ -542,9 +543,7 @@ private boolean hasJdtCoreSettingsChange(SimpleLookupTable deltas) {
static boolean isJdtCoreSettingsResource(IResource resource) {
IPath resourcePath = resource.getProjectRelativePath();
- String prefs = JavaProject.DEFAULT_PREFERENCES_DIRNAME + IPath.SEPARATOR + JavaProject.JAVA_CORE_PREFS_FILE;
- IPath expectedPath = Path.fromPortableString(prefs);
- boolean isJdtCoreSettingsResource = expectedPath.equals(resourcePath);
+ boolean isJdtCoreSettingsResource = JDT_CORE_SETTINGS_PATH.equals(resourcePath);
return isJdtCoreSettingsResource;
}

Back to the top