Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoratikhomirov2006-04-10 11:53:24 +0000
committeratikhomirov2006-04-10 11:53:24 +0000
commit2b871116ed64253309f3ef9ff4dcfb5ef12b8610 (patch)
tree709b77b74c046e0b267b78505ebd16d4a2368b0d /plugins/org.eclipse.gmf.graphdef.codegen/src
parent096616f398e7160e44bebb0a8ae38622b54ba4c3 (diff)
downloadorg.eclipse.gmf-tooling-2b871116ed64253309f3ef9ff4dcfb5ef12b8610.tar.gz
org.eclipse.gmf-tooling-2b871116ed64253309f3ef9ff4dcfb5ef12b8610.tar.xz
org.eclipse.gmf-tooling-2b871116ed64253309f3ef9ff4dcfb5ef12b8610.zip
Follow-up for #135016 Background colour is not used to fill polygons - most polylines are links, thus, no much sense to setFill(true) for them
Diffstat (limited to 'plugins/org.eclipse.gmf.graphdef.codegen/src')
-rw-r--r--plugins/org.eclipse.gmf.graphdef.codegen/src/org/eclipse/gmf/graphdef/codegen/templates/ShapeAttrGenerator.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/plugins/org.eclipse.gmf.graphdef.codegen/src/org/eclipse/gmf/graphdef/codegen/templates/ShapeAttrGenerator.java b/plugins/org.eclipse.gmf.graphdef.codegen/src/org/eclipse/gmf/graphdef/codegen/templates/ShapeAttrGenerator.java
index d838b68ad..1238d5524 100644
--- a/plugins/org.eclipse.gmf.graphdef.codegen/src/org/eclipse/gmf/graphdef/codegen/templates/ShapeAttrGenerator.java
+++ b/plugins/org.eclipse.gmf.graphdef.codegen/src/org/eclipse/gmf/graphdef/codegen/templates/ShapeAttrGenerator.java
@@ -49,9 +49,10 @@ final ImportAssistant importManager = dispatcher.getImportManager();
// Most of the properties are set only if corresponding eProperty isSet.
// The difference is in the default values. If default value of eProperty matches d2d one, the setter may be omitted.
-// d2d.Shape#fill == true (matches default of gmfgraph.Shape#fill), while d2d.Polyline#fill == false, thus we need additional check
+// d2d.Shape#fill == true (matches default of gmfgraph.Shape#fill), while d2d.Polyline#fill == false, thus we need additional check.
+// Note Polygon in the check instead of Polyline - (it looks like) there's no sense to setFill(true) for polylines in any case.
- if (figureInstance instanceof Polyline ^ figureInstance.eIsSet(GMFGraphPackage.eINSTANCE.getShape_Fill())) {
+ if (figureInstance instanceof Polygon ^ figureInstance.eIsSet(GMFGraphPackage.eINSTANCE.getShape_Fill())) {
stringBuffer.append(TEXT_1);
stringBuffer.append(figureVarName);
stringBuffer.append(TEXT_2);

Back to the top