From bff55f297a5c1f61add01419da9671cfea908c46 Mon Sep 17 00:00:00 2001 From: Alex Blewitt Date: Wed, 16 Mar 2016 01:30:35 +0000 Subject: Bug 489706 - Replace new Integer() with Integer.valueOf() There are a lot of new Integer() calls in the P2 codebase, which results in many duplicate values of Integer being stored, particularly when performing updates or checks. Integer.valueOf() performs this caching already, which means that it's unnecessary to call new Integer() and instead can call Integer.valueOf(). In the places where the int value is being used directly, the call can be further optimised to Integer.parseInt() instead. Replace calls to new Integer() with Integer.valueOf() or .parseInt() as appropriate. Change-Id: Ic760e66084c856fc90cb7c8a358007c975213638 Signed-off-by: Alex Blewitt --- .../equinox/internal/p2/transport/ecf/RepositoryTransport.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'bundles/org.eclipse.equinox.p2.transport.ecf') diff --git a/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/RepositoryTransport.java b/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/RepositoryTransport.java index 9db59789b..816bd7a2f 100644 --- a/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/RepositoryTransport.java +++ b/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/RepositoryTransport.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2012 IBM Corporation and other. + * Copyright (c) 2006, 2016 IBM Corporation and others. * The code, documentation and other materials contained herein have been * licensed under the Eclipse Public License - v 1.0 by the copyright holder * listed above, as the Initial Contributor under such license. The text of @@ -277,13 +277,13 @@ public class RepositoryTransport extends Transport { Integer retryCount = null; if (socketExceptionRetry == null) { socketExceptionRetry = new HashMap(); - retryCount = new Integer(1); + retryCount = Integer.valueOf(1); } else { Integer alreadyRetryCount = socketExceptionRetry.get(toDownload); if (alreadyRetryCount == null) - retryCount = new Integer(1); + retryCount = Integer.valueOf(1); else if (alreadyRetryCount.intValue() < retry) { - retryCount = new Integer(alreadyRetryCount.intValue() + 1); + retryCount = Integer.valueOf(alreadyRetryCount.intValue() + 1); } } if (retryCount != null) { -- cgit v1.2.3