Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-08-13Bug: new UnsupportedOperationException() not thrown inY20210820-0230Y20210819-0800Y20210819-0340Y20210818-0520Y20210817-1030Y20210817-0500Y20210813-0710S4_21_0_M3I20210818-1800I20210818-1250I20210818-0600I20210817-1840I20210817-0600I20210816-1800I20210816-0600I20210815-1800I20210815-0600I20210814-1800I20210814-0600I20210813-1800Carsten Hammer2-2/+2
org.eclipse.equinox.internal.p2.importexport.internal.wizard.ImportFromInstallationPage.setCheckedElements(Object[]) This code creates an exception (or error) object, but doesn't do anything with it. For example, something like if (x < 0) { new IllegalArgumentException("x must be nonnegative"); } It was probably the intent of the programmer to throw the created exception: if (x < 0) { throw new IllegalArgumentException("x must be nonnegative"); } Rank: Scariest (1), confidence: High Pattern: RV_EXCEPTION_NOT_THROWN Type: RV, Category: CORRECTNESS (Correctness) Change-Id: I50c598c0d09ab05caf651d83463247278121e120 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/171584 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Tested-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-30Bug 572410 - Remove activator from org.eclipse.equinox.p2.ui.impLars Vogel4-58/+45
Uses new API from Bug 549929 to access the dialog settings. This way we can remove the activator. Change-Id: I3fe5aabedd94463f8e547c8256639ae180da1146 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-01-14Bug 570362 - Move bundles to Java 11 where neededAlexander Kurtakov1-3/+3
Move p2.ui.importexport. Fix some new warnings detected after the move. Change-Id: Iee1740db3b6de4e9673b4cb88eb582bc79f1b207 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-10-15Bug 567899 - P2 import software "install latest versions" not workingY20201102-1200Y20201101-1200Y20201031-1200Y20201030-1200Y20201029-1200Y20201028-1200Y20201027-1200Y20201026-1200Y20201025-1200Y20201024-1200Y20201023-1200Y20201021-1200Y20201020-1200Y20201019-1200Y20201018-1200Y20201017-1200Y20201016-1200Y20201015-1200I20201103-0030I20201102-1910I20201101-1800I20201031-1800I20201030-1800I20201029-1800I20201028-1800I20201028-0800I20201028-0610I20201028-0130I20201028-0020I20201027-2350I20201027-1800I20201026-1850I20201026-0840I20201026-0650I20201025-1800I20201025-0040I20201024-1800I20201023-1800I20201023-0250I20201021-1800I20201021-0200I20201020-1800I20201020-0240I20201019-1800I20201018-1800I20201017-1800I20201016-1800I20201016-0000I20201015-1800Andrey Loskutov2-12/+33
Fixed selection algorithm to install "latest" versions if asked to do so, and install "oldest" versions otherwise. Change-Id: I929b5d5f458810acd62df2d8982a89d49aa494b3 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-07-31Lambdas and method reference cleanup for p2Y20200808-1200Y20200807-1200Y20200806-1200Y20200805-1200Y20200804-1200Y20200801-1200I20200808-0230I20200807-1800I20200806-1800I20200805-1800I20200805-0750I20200805-0630I20200804-1800I20200803-1800I20200803-0210I20200801-1800I20200801-0010I20200731-2040I20200731-1800Lars Vogel1-1/+1
Done via JDT cleanup actions Change-Id: I5e9085d4f3bfa6cf6dbe06d1d339ccd0ead89a32 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-10-16Use jdk 5 for-each loopCarsten Hammer2-12/+15
Replace simple uses of Iterator with a corresponding for-loop. Also add missing braces on loops as necessary. Change-Id: I0895b7e934ede33af1bbacd6d7aaa70c316f190e Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-09-24Bug 551396 - Fix files that have ended up with CRLF in the gitI20190924-1800Ed Merks3-931/+931
repository Change-Id: Id4b41b08f3a4dc32130aa5b22c1d58118fba7a7c Signed-off-by: Ed Merks <ed.merks@gmail.com>
2019-07-16Remove useless non-javadoc comments.Alexander Kurtakov1-8/+1
Change-Id: I8344b55fde0515c8b64c576017a692108e4cadd7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-07-16Convert to the generic IProvisioningAgent.getService()Alexander Kurtakov4-97/+156
Take 3. Change-Id: I1509b415bfda56813884a6410c3b12161ddcf883 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-27Bug 535802 - Update p2 EPL-2.0 for its plug-ins - Part 5I20180827-0800Lars Vogel21-63/+126
Change-Id: I5f6906b87cbc08760a35a71420f1a90780346769 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-01-26Bug 530396 - Move UI code to lambdasAlexander Kurtakov2-68/+42
Change-Id: I92c7b5c6cbde04280da91a9ee617495ff0381a73 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-10-11Fix warnings in ui.importexport.I20171012-2000I20171011-2000Alexander Kurtakov2-19/+14
* Unnecessary else clauses. * Variables hiding. * Synthetic methods by using lambdas. Change-Id: Ibc6e456ff22313e95c2000ab26b0b439f74c6332 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-10-07Bug 521147 - Move p2 ui.importexport to Java 8Alexander Kurtakov1-1/+2
Add missing Override annotation. Change-Id: I8a7155e5355679d52a8caf9b3036fe9f9613dbcf Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-19Bug 521147 - Move p2 ui.importexport to Java 8Alexander Kurtakov11-212/+182
Bump minor version, add missing Override annotations, remove redundant type declarations and some lambda conversions. Change-Id: I2d122a18122b24687f4629a9ac87d43094ff0e8f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-04Bug 462404: New Eclipse.app layout: "Import > From ExistingI20170816-2000I20170815-2000I20170815-0035I20170814-2000I20170814-0635I20170814-0300I20170813-2000I20170812-1500I20170811-2000I20170810-2000I20170809-2000I20170808-2000I20170807-2000I20170806-2000I20170805-1500I20170804-2000Lakshmi Shanmugam2-1/+25
Installation" doesn't accept app bundle When Mac app bundle is provided try to drill down to Contents/Eclipse folder if it exists. Change-Id: I29844aed359b1b062cf209675a993e1ba06d09d3 Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2017-06-21Bug 518574 - Use StandardCharsetsAlexander Kurtakov2-8/+4
Bump BREE to 1.8 for bundles that were too low to have StandardCharsets. Change-Id: Iac9e9615c5179b970df893182f5f1c6e3dd4d574 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-04-18Bug 514863: Use png files in org.eclipse.equinox.p2.uiMatthias Becker3-66/+66
Change-Id: Ia891112782c251e903149d5e3db8d873f3b1b6d9 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2016-04-19Bug 489706 - Replace new Integer() with Integer.valueOf()I20160419-0800Alex Blewitt1-3/+3
There are a lot of new Integer() calls in the P2 codebase, which results in many duplicate values of Integer being stored, particularly when performing updates or checks. Integer.valueOf() performs this caching already, which means that it's unnecessary to call new Integer() and instead can call Integer.valueOf(). In the places where the int value is being used directly, the call can be further optimised to Integer.parseInt() instead. Replace calls to new Integer() with Integer.valueOf() or .parseInt() as appropriate. Change-Id: Ic760e66084c856fc90cb7c8a358007c975213638 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-01-02Bug 466249 - Propagate more exceptions to ease problem analysisEike Stepper1-2/+6
We often get problem reports with stack traces that "end" somewhere in p2 even though it's obvious from looking at these places that there was a causing exception. These causing exceptions are often not propagated with the new exception that p2 creates and throws. I'm not sure if that's on purpose or just an oversight. I've prepared a proposal to enhance these places and make it easier to analyze the problems that users report. Change-Id: Iaa53448c53c18301113b42dbe80558eccec49e8e Signed-off-by: Eike Stepper <stepper@esc-net.de>
2015-02-26Bug 460967 - Use type safe service retrievingI20150303-0800Alexander Kurtakov1-2/+3
Instead of retrieving services based on their String class name there is newer implementation that takes the class directly and returns the correct class preventing casts. Change-Id: I8b26f4d294b927f4c28a6ba4e68e35bd401df4ec Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2015-02-24Bug 460627 - Fix compiler problems from generified IAdaptable#getAdapterAlexander Kurtakov1-5/+3
Generify where needed and bump the min version requirement for o.e.core.runtime and o.e.equinox.common to ensure that generified dependency will be used. Change-Id: I3e177a3c8384b5aaabe4c77c949e9802e53923b1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2013-12-10bug 423628 - False positives warnings in the official build.I20131211-0800I20131210-2000I20131210-0800Krzysztof Daniel3-6/+15
False positives are caused by projects settings being different than build settings. Typical example is that project is configured to warn about local variable hiding a field, and suppression is added, but the regular releng build is not configured to warn, and it finds unnecessary suppression. I have did following things: * fixed warnings that I was able to fix (renamed variables, added generics, comments, etc, etc). * reduced the number of warnings in tests * commented warnings that must not be suppresed in the workspace unless we want "Unnecessary @SuppressWarnings" at build time. Change-Id: Iab2c962e5c331eab170b5f6e08d9bb29d05f0cc4
2013-12-09Bug 409073 - Cannot install items from .p2f file (no repository found)Hamdan Msheik1-147/+160
Signed-off-by: Pascal Rapicault <pascal@rapicault.net> Signed-off-by: Hamdan Msheik <hamdan.msheik@ericsson.com>
2013-11-15Bug 421798 - Fix various warnings.Alexander Kurtakov1-1/+1
* Remove unneeded casts. * Remove unneeded throws. * Remove unneeded semicolons. Change-Id: I7454ea216cfc194a0d394550feecc29042d23363 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2013-01-24Bug 398655 - [import/export] Browse button does not open file chooserv20130124-045504Mengxin Zhu3-6/+53
2012-12-05Improve user experience when manually typing location in Import install wizard.v20121205-085939Mengxin Zhu2-2/+3
2012-11-27Bug 395210 - [import/export] NPE when browsing content from existing installv20121127-204218Pascal Rapicault (Ericsson)1-123/+125
2012-11-27Externalize stringPascal Rapicault3-1/+3
2012-11-27Bug 387115 - [import/export] Enable "Import->Install->Install Software Items ↵v20121127-161011Pascal Rapicault (Ericsson)8-47/+84
from File" without explicit locations
2012-11-26Revert "Set ProvisioningContent repos to null when contacting all update ↵v20121126-184335I20121127-0800Pascal Rapicault1-446/+448
sites is checked" This reverts commit 0adeb78ec4ba86f79f27f4ebc1e3358c5e3ce22a.
2012-11-26Set ProvisioningContent repos to null when contacting all updatePascal Rapicault1-448/+446
sites is checked
2012-11-26Improve messagePascal Rapicault1-1/+1
2011-08-18Bug 354848 - Compiler warnings in I20110816-0800v20110818-1344dj1-1/+1
2011-08-13fix 353348 Install/import from existing installation fails to produceMengxin Zhu1-24/+71
expected choices when 3.6 is the source Change-Id: I88114df30315add5bc3f34da1ceffd90184d8404
2011-07-01merge the fix of 346401, 346406mzhu10-58/+442
2011-05-10Bug 345209 - [import/export] VersionInCompatibleException spelt wrongRoot_R3_7_maintenancePascal Rapicault4-7/+7
2011-05-10Bug 344192 - [import/export] Polish comments for p2 import/exportv20110510-0732Pascal Rapicault2-26/+22
2011-05-10fix bug 343555v20110510mzhu3-1/+16
2011-05-10fix bugzilla 343551mzhu5-550/+558
2011-05-10fix bugzilla 344496mzhu3-3/+42
2011-05-06release the fix of bugzilla 343921mzhu6-20/+57
2011-05-06Fixed bugzilla 343548.mzhu5-35/+212
2011-05-02copyright updateIan Bull1-0/+10
2011-04-14Bug 342661 - compile warnings in official buildsDJ Houghton2-13/+15
2011-04-13Bug 342661 - compile warnings in official buildsDJ Houghton1-2/+5
2011-04-13Bug 342495 - Chkpii error in org.eclipse.equinox.p2.ui.importexportPascal Rapicault1-1/+1
2011-04-10tweak messagePascal Rapicault1-2/+2
2011-04-10cleanupsPascal Rapicault1-6/+7
2011-04-10Remove reference to the word featurePascal Rapicault1-22/+21
2011-04-10fix up messagePascal Rapicault1-1/+1

Back to the top