Skip to main content
summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-27Bug 535802 - EPL 2.0 for remaining test plug-insI20180829-0800I20180828-2000I20180828-0800I20180827-2000Lars Vogel35-105/+210
Change-Id: If2e35c4c118edbcf6ef4db5858726dde942da562 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-22Adds linebreak before the EPL 1.0 licenceLars Vogel1-1/+2
Change-Id: Ic1638772d5f58d4567a83b519ecd885b80f5602b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-22Fixes incorrectly formated EPL 1.0 license headerI20180822-0800Lars Vogel1-1/+2
Change-Id: I6337f0a9e32e7eb71ba6e368137e180a456bb8da Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-03-01Bug 423715 - Support multiple algorithms for artifact checksumsI20180301-2000Mykola Nikishov2-1/+116
Developer of p2-based software should be able to check integrity of artifact checksums using any MessageDigest implementation available, at his own discretion, without ever touching p2 internals. For the purpose of this bug, limit enabled checksum algorithms to: - MD5 (legacy one, deprecated now, for backward compatibility only) - SHA-256 (more collision-resistant than MD5) See artifactChecksums.exsd for more details. First, encode ID of the checksum algorithm into the name of the property itself so that artifact descriptor now may look like: <artifact classifier='binary' id='testKeyId' version='1.2.3'> <properties size='6'> <property name='download.md5' value='b3788632488d48b850255acf68669651'/> <property name='artifact.md5' value='b3788632488d48b850255acf68669651'/> <property name='download.checksum.sha-256' value='d594816b995d1689c2dfc97dc244859abe6bdb9ebeb4b396e401afd85a97ee16'/> <property name='download.checksum.whirlpool' value='e4f3ece3d3f289cc2686a68f0b1b5a2d03da3a8ccdc3cd6d03209e4c789af724c8fa915bb890079e1abe78df44875cec132885dd6ae1176eed7938dfb3c7b551'/> <property name='artifact.checksum.sha-256' value='d594816b995d1689c2dfc97dc244859abe6bdb9ebeb4b396e401afd85a97ee16'/> <property name='artifact.checksum.tiger' value='462a72a1a593b9e2de8721b8d79335fd03e974f2e2e1f35a'/> </properties> </artifact> Prefix helps to avoid conflicts with other, not checksum-related, properties. To find checksums of specific type, we need all properties with prefix 'artifact.checksum.', Extracting checksum id from the name of the property is also trivial. Store these prefixes in IArtifactDescriptor's DOWNLOAD_CHECKSUM and ARTIFACT_CHECKSUM. ChecksumUtilities provides internal API to deal with properties. Second, map ID of checksum algorithm to the name of MessageDigest implementation with a contribution to a new extension point org.eclipse.equinox.p2.artifact.repository.artifactChecksums: <extension point="org.eclipse.equinox.p2.artifact.repository.artifactChecksums"> <artifactChecksum algorithm="SHA-256" id="sha-256" ... /> </extension> Number of actual checksums in artifact descriptor depends on the configuration of the application that created such descriptor because p2 will: - handle MD5 checksums as usual, preserving backward compatibility - calculate other checksums using extensions that contribute to artifactChecksums extension point Last, we use id of specific checksum to get MessageDigest instance with getInstance(String). There is a number of standalone applications (like MirrorApplication) and Ant tasks (like ValidateTask) that allow user to chose specific comparator by id and ArtifactComparatorFactory is responsible for instantiating it. Legacy MD5 comparator requires no special configuration while the new ArtifactChecksumComparator is more generic and needs some parameters to instantiate. ArtifactComparatorFactory handles this by accepting fake comparator id - concatenated ArtifactChecksumComparator's id and checksum algorithm id. In other words, to compare artifacts using SHA-256 algorithm use 'org.eclipse.equinox.artifact.comparator.checksum.sha-256' as comparator id. We generate, consume and compare artifact checksums using all enabled algorithms. Ideally, configuration options should provide more control for both repository publisher and p2 client like: - a priority (compare with SHA-512 first, then SHA-256 and, finally, MD5) - skip specific checksum (do not use MD5 even if provided) - mandatory checksum (require Whirlpool and it's an error if its not available) While I have no good solution for this right now, there are some configuration options provided. Also, number of new enabled checksum algorithms is limited to SHA-256 only (more checksums = more reasons to fail = more reasons to disable). To turn checksum verification off completely: - for p2 client, use property 'eclipse.p2.checksums.disable' (see SimpleArtifactRepository.CHECKSUMS_ENABLED constant). - for p2 publisher, the old PublisherInfo's setArtifactOptions(int) and IPublisherInfo.A_NO_MD5 still could be used. To disable MD5 checksums only, existing properties 'eclipse.p2.MD5Check' and 'eclipse.p2.MD5ArtifactCheck' still can be used. Change-Id: Iacd267e13d5d096694001d34cafbaea5451e7157 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2018-01-02Fix warnings in p2.tests.I20180103-0140I20180102-2215I20180102-2000Alexander Kurtakov1-5/+5
Useless throws and instanceof checks. Change-Id: I104e88433c551512e68329b4648b8038d9ccd146 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-09-19Bug 522466 - Fix generification warnings in p2.tests Alexander Kurtakov3-22/+22
Second round. Change-Id: I624199cb119e374788521bf20189852e4c15d3cc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-09-19Bug 522466 - Fix generification warnings in p2.tests Alexander Kurtakov2-15/+15
First round of generifying everything faced. Change-Id: I78bb9ce2655caf41da22235b0ac85ad6ad922365 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-09-19Bug 522466 - Fix generification warnings in p2.tests Alexander Kurtakov5-37/+37
Generification of most IQuery* related warnings possible and surrounding other generic warnings. Change-Id: I8516236c712722d7c40ea15c7334d7ba87b7e6b4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-23Bug 521301 - Stop using deprecated p2 methods in p2 tests Alexander Kurtakov6-44/+46
Change-Id: I08b47ba0d4219f15b061b759c01f874747a496df Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-22Bug 518587 - Modernize o.e.equinox.p2.testsI20170623-0110I20170622-2000Alexander Kurtakov6-228/+138
Use try-with-resources. Change-Id: I6c1d3efb7f0fd4f5dd0f014d8801ec8e375355f9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-06-21Bug 518587 - Modernize o.e.equinox.p2.testsI20170621-2000Alexander Kurtakov24-277/+320
Move to Java 8, enable more warnings and save actions and go through the codebase to minimize the warnings. Change-Id: I6283bfeef18e250f5283e80f7bfad38e6ef65415 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-05-05Bug 438584 - p2 unit tests not cleaning up after themselvesI20170510-0800I20170509-2000I20170509-1300I20170509-1100I20170509-0945I20170509-0800I20170508-2000I20170508-0800I20170507-2000I20170506-2000I20170505-2000Alexander Kurtakov1-0/+1
Change-Id: I651c22e089d17929f00ee086e3de6910ef901266 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-01-31Revert "Make Tycho's compiler use configuration from ↵Markus Keller2-2/+3
.settings/org.eclipse.jdt.core.prefs" This reverts commit 678bfa1aad9cf5fbe6a488d168763288acabb501. Change-Id: Ia1ec726e051392b3fefa753b6def2d937f68523e
2017-01-27Make Tycho's compiler use configuration from ↵I20170130-2000Mykola Nikishov2-3/+2
.settings/org.eclipse.jdt.core.prefs Change-Id: I60cd95811a1c12a8e961d05a1e4da077fc9a3c30 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2016-12-16Fix 'always true' assertionY20161229-1000Y20161223-1030Y20161222-1000I20170105-0320I20170105-0230I20170104-2000I20170104-0800I20170103-2000I20170102-2000I20170101-2000I20161231-2000I20161230-2000I20161229-2000I20161228-2000I20161227-2000I20161226-2000I20161225-2000I20161224-2000I20161223-2000I20161223-0615I20161222-2000I20161221-2000I20161221-0400I20161220-2000I20161220-0530Mykola Nikishov1-2/+3
Use org.junit.Assert's assertNotEquals(String, Object, Object) to check if two MD5 are different. junit.framework.TestCase's assertNotSame(String, Object, Object) compares arguments by reference and for String arguments, in most cases, returns true even if both arguments are equal by value. As we need a negative assertion (two MD5 are not equal), junit.framework.TestCase doesn't fit the bill - it does provide assertEquals() but not assertNotEquals(). Change-Id: I1ce6123d9102de963c92da88bea5e713ecdf44e6 Signed-off-by: Mykola Nikishov <mn@mn.com.ua>
2015-02-26Bug 460967 - Use type safe service retrievingI20150303-0800Alexander Kurtakov3-6/+9
Instead of retrieving services based on their String class name there is newer implementation that takes the class directly and returns the correct class preventing casts. Change-Id: I8b26f4d294b927f4c28a6ba4e68e35bd401df4ec Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2013-11-15Bug 421814 - Fix deprecated usages in tests.Alexander Kurtakov1-3/+1
Use Hamcrest matchers directly instead of via deprecated junit class. Change-Id: Iec5e4b6c482a85f5ed6b05020c1af85ec83d39ec Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2013-11-15Bug 421798 - Fix various warnings.Alexander Kurtakov5-7/+6
* Remove unneeded casts. * Remove unneeded throws. * Remove unneeded semicolons. Change-Id: I7454ea216cfc194a0d394550feecc29042d23363 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2013-11-12Revert "bug 420260: org.eclipse.equinox.p2.tests take 1.5h longer on theKrzysztof Daniel1-6/+0
Mac " This reverts commit 8c9187a7cdfca9ae0c93566c5f383a6c7e6137bf, as it was released only for instrumentation. Signed-off-by: Krzysztof Daniel <kdaniel@redhat.com> Change-Id: I5ca7c147d8434b3a72b84d38953817ff541b9066
2013-11-12Bug 419418: testSimpleRepositoryPerformanceOnLoadReadonlyLocalRepositoryI20131112-0800Krzysztof Daniel1-10/+7
fails when invoked with maven surefire Tests rely on changing privileges, which cannot be changed without platform. Platform can't be installed into surefire, because it depends on bundles in the reactor, and would cause circular dependencies. So, the proper way is to use File API to manage file attributes. Change-Id: I93ab9eaaf9891b265e0ef4fbabe3f22a66616738 Signed-off-by: Krzysztof Daniel <kdaniel@redhat.com>
2013-11-04bug 420260: org.eclipse.equinox.p2.tests take 1.5h longer on the Mac I20131105-0800Krzysztof Daniel1-0/+6
This is a temporary instrumentation to gather thread dumps when a test takes longer than 60 seconds. Change-Id: I242857ccdd600d954e539e656a3fb0e0613f747d Signed-off-by: Krzysztof Daniel <kdaniel@redhat.com>
2013-03-14Clear the repository nick name after the testN20130318-2000N20130317-2000N20130316-1500N20130315-2000I20130319-1000Ian Bull1-0/+3
This clears the Repository NickName after the test so other test can run and assume it's null.
2013-03-14Fix for transfer testsIan Bull1-1/+1
We were looking for a specific ECF bundle name which changed when HttpClient 4 was used. This fix updates the test to reflect that.
2013-01-15Fixed test failure on Hudsonv20130115-153126I20130115-1300John Arthorne1-2/+2
2012-10-11356561 Revert default of composite loading back to non-atomicv20121011-091400I20121030-0800I20121029-2000I20121029-0800I20121028-2000I20121024-1200I20121024-1130I20121023-0800I20121016-2240I20121016-0800Tobias Oberlies1-4/+4
- There has been a suggestion of how to fix non-atomic loading (i.e. implement it in a way that network problems are not silently ignored), so we may keep non-atomic loading as the default. Bug: 356561 Composite repositories ignores errors when loading children (errors are treated like missing children)
2012-10-09391400 Include repository URL in status if getArtifacts failsTobias Oberlies1-0/+28
Bug: 391400 Status returned by getArtifacts does not include repository URL of problematic repository in case of an error
2012-10-01Revert "Revert "Bug 387557 - stable tests""v20121001-214426Ian Bull2-8/+24
This reverts commit 0f85cc10f6086cde746b969917a23ad5cd24d167.
2012-10-01Revert "Revert "Bug 387557 - JarProcessor 'tampers' eclipse.inf of signed ↵Ian Bull1-0/+29
jars in some cases"" This reverts commit b1df469a2938fd2d98cba299ca8d9a88cbdaf0f9.
2012-09-28356561 Require that all children of a composite repository can be loadedv20120928-180332Tobias Oberlies1-4/+4
- Loading a composite repository now fails if any of its children cannot be loaded. So in case of transient network problems, a p2 operation now fails fast, instead of generating obscure (and possibly severe, yet unnoticed) follow-up problems. - p2 repository providers who rely on the old, lenient behaviour may re-enable it by adding the property 'p2.atomic.composite.loading' with value 'false' in their compositeContent.xml/ compositeArtifact.xml. - p2 clients who need to communicate with broken composite repositories which are out of maintenance can revert to the old behaviour by setting the system property eclipse.p2.atomic.composite.loading.default=false. Bug: 356561 Composite Repositories have non-deterministic content by default
2012-09-20Revert "Bug 387557 - JarProcessor 'tampers' eclipse.inf of signed jars in ↵v20120920-155211I20120925-0800I20120920-1300John Arthorne1-29/+0
some cases" This reverts commit ea959ede352a6b092680341160ceb851accf0924.
2012-09-20Revert "Bug 387557 - stable tests"John Arthorne2-24/+8
This reverts commit 65e53144a4b36388f31092cc6c7ef00ae5b833ae.
2012-09-11Bug 387557 - stable testsv20120911-175849I20120919-2000I20120919-0800I20120919-0330I20120918-2200I20120918-2000I20120918-0800I20120917-2000I20120917-0800I20120916-2000johna/bug387557John Arthorne2-8/+24
2012-09-11Bug 387557 - JarProcessor 'tampers' eclipse.inf of signed jars in some casesv20120911-175848John Arthorne1-0/+29
2012-08-29Disabled the two MD5 tests that were failing because of JRE 6v7 issuesv20120829-183414Ian Bull2-2/+2
2012-08-29Bug 381673: Fixes a few compile warningsv20120829-182520Ian Bull1-4/+10
This fixes 2 types of compile warnings. 1. Stream not closed warnings. 2. Unused object warnings
2012-02-16Bug 371566 - test failure in I20120214-0800Ian Bull1-1/+1
We had an over-protective null check. In fact, we want the null selector to be set.
2012-02-15Bug 371566 - test failure in I20120214-0800Ian Bull1-10/+31
We hijack the mirror selector and never removed it. Whne the tests run in a non-deterministic order, the temp selector causes problems with other test cases. This fixes it by clearing the custom selector after the test finishes.
2012-01-17364929 support customizable download statisticsv20120117-1140v20120117-0330Mengxin Zhu1-0/+176
Signed-off-by: Mengxin Zhu <kane.zhu@windriver.com>
2011-12-15Bug 366668 - Test case ↵v20111215-0657Mengxin Zhu1-20/+25
'testSimpleRepositoryPerformanceOnLoadReadonlyLocalRepository' fails on Windows. Disable case 'testSimpleRepositoryPerformanceOnLoadReadonlyLocalRepository' on Windows. There is no way to create a test folder on Windows then new file can't be created in it. Signed-off-by: Mengxin Zhu <kane.zhu@windriver.com>
2011-12-07Fix 351944 to avoid unnecessary loading artifact repository when doing ↵v20111207-0646Mengxin Zhu2-0/+110
query, getting artifact descriptors via artifact key. Without fixing though simple artifact repository always checks the last modify of artifacts.jar file, however it still cost some time, it will waste a lot of time especially the repository locates on a read-only NFS server. This version of fix introduces the dependency on o.e.core.filesystem to use EFS API to change the file permission crossing platforms. Signed-off-by: Mengxin Zhu <kane.zhu@windriver.com>
2011-12-05Revert "Fix 351944 to avoid unnecessary loading artifact repository when ↵v20111205-2311Ian Bull2-104/+0
doing query, getting artifact descriptors via artifact key." This reverts commit 82aeb8dee11f4114494fe3dd0ca1097312d2dfd5.
2011-12-02Fix 351944 to avoid unnecessary loading artifact repository when doing ↵v20111202-0654Mengxin Zhu2-0/+104
query, getting artifact descriptors via artifact key. Without fixing though simple artifact repository always checks the last modify of artifacts.jar file, however it still cost some time, it will waste a lot of time especially the repository locates on a read-only NFS server. Signed-off-by: Mengxin Zhu <kane.zhu@windriver.com>
2011-09-10bug 357107. Remove test case 'MirrorRequest2' from nightly test suite.v20110910-0411Meng Xin Zhu2-1/+10
SDK doesn't have bundle 'org.eclipse.equinox.http', so can't run testserver on Hudson. Change-Id: Iba8d1e41d3c2a164906c4100dd309a5e1fc94170
2011-09-02fix 350014 to use a system property to set the retrying number if socketv20110902-0807Mengxin Zhu2-0/+158
timeout happened Change-Id: I1bab6db693a3ee739e058bda1a4d00fbc8bd1eb8
2011-06-29Bug 317785 - [repository] Synchronization problem in mirror selectionJohn Arthorne1-50/+297
2011-05-02copyright updatev20110502-1955v20110502-1930Ian Bull24-22/+42
2011-04-21Bug 312984 - [repository] Composite repo should have the ability to be ↵v20110421Pascal Rapicault1-0/+51
marked in error if a child repo is bad
2011-04-04NEW - bug 341826: Add a stopgap measure for artifact lockingv20110404-2011Ian Bull1-0/+11
https://bugs.eclipse.org/bugs/show_bug.cgi?id=341826
2011-03-29NEW - bug 339164: File level locking doesn't 'lock' the file between ↵Ian Bull1-4/+4
multiple threads in the same VM (Java 1.5) https://bugs.eclipse.org/bugs/show_bug.cgi?id=339164
2011-03-08NEW - bug 339164: File level locking doesn't 'lock' the file between ↵v20110308-0106Ian Bull1-4/+4
multiple threads in the same VM (Java 1.5) https://bugs.eclipse.org/bugs/show_bug.cgi?id=339164

Back to the top