Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-07-06Bug 574667 - Use Jenkins multibranch pipeline based onY20210722-0800Y20210720-0800Y20210719-0550Y20210715-1150Y20210715-1000Y20210715-0820Y20210713-0800Y20210708-0800S4_21_0_M1I20210722-1800I20210721-1800I20210721-0530I20210720-1800I20210719-1800I20210718-1800I20210717-1800I20210716-1800I20210716-0020I20210715-2200I20210715-1800I20210714-1800I20210713-1800I20210712-1800I20210712-0340I20210712-0240I20210711-1800I20210710-1800I20210710-0000I20210709-0030I20210707-1800I20210707-0600I20210706-1800Mickael Istria1-0/+70
Jenkinsfile+Gerrit Change-Id: I7809ab093b79d5c029606d2261af97a28ef3ec5c Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182795 Tested-by: Mickael Istria <mistria@redhat.com> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-07-06Bug 574602 - Eclipse 4.21 prerequisites: OrbitY20210706-1050Y20210706-0800I20210706-0600Sravan Kumar Lakkimsetti1-0/+1
Change-Id: I34927698671e25de155e72098d9434a75bccc2c5 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182777 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-07-03Bug 573131 - Make bundlepool installations relocatableI20210705-1800I20210705-0600I20210704-1800I20210704-0600I20210703-1800Ed Merks1-1/+1
Fix regression in getOSGiInstallArea for @launcher.dir replacement. Change-Id: Ie695ecb173d8421c760a907af25934cd6e43b2b2 Signed-off-by: Ed Merks <ed.merks@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182738
2021-07-01Bug 574584 - Various AutomaticUpdateScheduler issues after changing initY20210701-0800I20210703-0600I20210702-1800I20210701-1800Andrey Loskutov3-17/+32
to Job - prevent NPE if early startup job was not executed yet - give 3rd party a chance to get the job execution status / join on it Change-Id: I39e62dfc3fee73c86335072b2607898808449570 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182669 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-30Bug 537757 - Convert BackupStore to java.nio.fileI20210630-1800Todor Boev14-1374/+1283
- Cleanup to the path conversion methods - Cleaned up the backup store root handling - Using UUID for the unique part of the backup dir name - Convert to Java 7 file API using only File.move() for the most critical operation. - Improved logging - Changed BackupStore to SimpleBackupStore - Fixed the backup tests to use Java 7 Signed-off-by: Todor Boev <rinsvind@gmail.com> Change-Id: I16f3496bf9accacdb2932b0a2a14a96d3581d37b Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182585 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-29Bug 537757 - Format codeY20210630-0410Y20210630-0230I20210629-1800Todor Boev4-187/+202
Change-Id: I3eb94846144a6683f8ee918f9c4abd2f0deb603f Signed-off-by: Todor Boev <rinsvind@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182080 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-28Bug 573131: Make bundlepool installations relocatableY20210629-0800I20210629-0210I20210628-1800Torbjörn Svensson4-10/+14
Contributed by STMicroelectronics Change-Id: I399899441fd926ad4bf89eb64360bd3f213a7320 Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179791 Reviewed-by: Mickael Istria <mistria@redhat.com> Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-18Bug 572816 - Fix JavadocY20210623-0320Y20210622-1150I20210627-1800I20210626-1800I20210625-1800I20210624-1800I20210624-1210I20210622-1800I20210621-1800I20210620-1800I20210619-1800I20210618-1920I20210618-1800Mickael Istria1-17/+24
Change-Id: I66049499b6a43933edf2bcd3e31a0b74bf4538c5 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/182152 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-15Bug 574186 - Better error message for negative dependencyI20210617-1800I20210616-1800I20210615-1800Christian Walther3-1/+4
When an unsatisfied dependency has max='0', i.e. expresses that A depends on B *not* being there, make that clear in the error message by saying "A conflicts with B" instead of "A depends on B". Change-Id: Id06e2d8130be2016bcd4432c541a6d178bb5c2b8 Signed-off-by: Christian Walther <walther@indel.ch> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181923 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-15Bug 572816 - Add Javadoc to UIServices & TrustInfo about new methodsMickael Istria1-7/+19
2021-06-15Bug 572816 - p2 strategy to trust PGP signaturesMickael Istria28-201/+563
This makes users declare whether PGP keys are trusted or not at installation, and to skip installation if one artifact has no signature/signer being trusted. * Propagate the pgp.signatures on local artifact description, so it's usable for CheckTrust * Add support in the Trust model for PGP keys * Add (limited) support for PGP approval in TrustCertificationDialog * Skip installation is PGP Keys are not trusted (similarly to certificates). Current limitations: * Dialog doesn't show whether a subset of PGP Keys is sufficient to complete installation (eg 1 artifact may have mulitple signature, only 1 is necessary to be approved for installation to complete, dialog doesn't show that and gives impression all keys need to be approved) * The dialog doesn't give any form of hint about how to decide whether to trust a key or net (eg check PGP key registries and so on); but it's also the case for certificates apparently... Change-Id: I65f698c7412027fedefc28ddfaa344caa6bfecdc # Conflicts: # bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179275 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-15Bug 573965 - Version bumps for 4.21 streamY20210615-0910Y20210615-0900Alexander Kurtakov2-2/+2
Change-Id: I4c488f3e4a8fefb3592b3006d8f49bcfadac53c7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181973 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-14Bug 574186 - Bump p2.director versionI20210614-1800Christian Walther2-2/+2
Change-Id: If964fa3a5756ed74f98e8d34d3e49f2f4c445eec Signed-off-by: Christian Walther <walther@indel.ch> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181926 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-13Bug 574173 expose hard coded RepositoryPreferences as system propertiesY20210614-0420I20210613-1800Andrey Loskutov2-12/+37
Allow to use following system properties to configure RepositoryPreferences: p2.RepositoryPreferences.retryOnSocketTimeout (default is false) p2.RepositoryPreferences.connectionRetryCount (default is 1) p2.RepositoryPreferences.connectionMsRetryDelay (default is 200) Change-Id: I9340493bb6e88a706fcd94662a92e82ecc4fb76b Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181876 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-13Bug 574173 - bump p2 repository and transport versions for 4.21Andrey Loskutov4-4/+4
Change-Id: I99193df266dc0151f69bbf8d7dd5b2ad1e0a1206 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181875 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-11Slightly change Profile.toString() for better readabilityY20210611-0900I20210612-1800I20210611-2000Andrey Loskutov1-1/+1
Change-Id: I88f09b488b9a0466618d2a5d083de9833d4efa61 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181828 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-10Bug 567045 - use always growing currentTimeMillis for Profile savingI20210610-1850Andrey Loskutov1-3/+16
Change-Id: I9ac3bab1a9b70d394df50ca5dde60193ef93081c Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181801 Reviewed-by: Jörg Kubitz <jkubitz-eclipse@gmx.de> Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-10Bug 567045 - include profile information into the messageAndrey Loskutov3-5/+6
Change-Id: Ia2864c9e2ea1e7871a42fac254bec68a98b622e0 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181791 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-10Bug 567045 - bump org.eclipse.equinox.p2.engine versionAndrey Loskutov6-6/+6
Change-Id: I1f481d1ae063203a94a063c769ca980240f034b2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181796 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-10Bug 572099 - testBug242346 fail since I20210316-1800Vikas Chandra3-7/+144
- Switched default profile used by JREAction to Java 11. - If no JRE profile given, JREAction generates a temporary profile based on default profile version and containing packages observed by the currently running JVM. - Updated JREActionTest to Java 11 expectations: 228 system packages and 23 capabilities Change-Id: Iaa8cbd62b8d70576ee55ade49e9a416799dfed5d Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181182 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-06-10Don't reformat entire file on saveAndrey Loskutov1-1/+1
Change-Id: Ie45d5b7d8b37ff5652452cee8aa8c094ec3c95b2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181775
2021-06-09Bug 572099 - bump org.eclipse.equinox.p2.publisher versionI20210609-1800Andrey Loskutov8-8/+8
Change-Id: I6fd84acee00996edcfa9317f7aba9f4837b0ce1c Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181681 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-06-04Bug 573962 - Update product version number to 4.21 across build scriptY20210608-2330I20210608-2130I20210608-1800I20210608-1300I20210606-1800I20210605-1800I20210604-2250I20210604-1020I20210604-0640I20210604-0350Sravan Kumar Lakkimsetti1-1/+1
Change-Id: Ia60c93f54b17842ab1f37039b67e2c9102a11e62 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181362
2021-06-04Bug 573960 - POM and product version change for 4.21 releaseSravan Kumar Lakkimsetti64-64/+64
Change-Id: Icdb9ea67799b20308f4143439a953c0e86e91b07 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/181361
2021-05-07[dogfooding] Use String.join JDT cleanup in p2S4_20_0_RC2aS4_20_0_RC2S4_20_0_RC1S4_20_0_M3R4_20I20210611-1600I20210610-1250I20210610-1220I20210610-0400I20210609-0520I20210609-0400I20210609-0220I20210603-0040I20210602-1800I20210602-0600I20210601-1800I20210601-0600I20210531-1800I20210531-0600I20210530-1800I20210529-1800I20210529-0600I20210528-1800I20210526-2310I20210526-1800I20210526-0600I20210525-1800I20210525-0730I20210524-1800I20210524-0600I20210523-1800I20210523-0600I20210522-1800I20210522-0600I20210521-1800I20210521-0150I20210521-0110I20210519-1800I20210519-0600I20210518-1800I20210518-0850I20210518-0600I20210518-0200I20210517-1800I20210517-0600I20210516-1800I20210516-0600I20210515-1800I20210515-0600I20210514-1800I20210513-1800I20210512-2250I20210512-1800I20210511-1800I20210511-0740I20210511-0330I20210511-0200I20210510-1800I20210509-1800I20210508-1800I20210507-1800R4_20_maintenanceLars Vogel1-7/+2
The resulting code is much shorter. Change-Id: I1b5e6a59b1cc236c273e8005c174ef6bdf393341 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179100 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-05-05Bug 572034 - update corrupted test jar to modern digest algorithmI20210506-1800I20210505-1800Thomas Watson4-4/+4
Old corrupted test JAR was using MD5 digest algorithm which is no longer supported with the Java JAR API. Updating corrupted test JAR with latest signed JAR for equinox.common. Change-Id: Ibe5c3a901de016c8636c159697941b3e32dad9de Signed-off-by: Thomas Watson <tjwatson@us.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/180251 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-27Bug 572799 - Replace arm64 with aarch64I20210505-0510I20210505-0100I20210504-1800I20210503-1800I20210502-1800I20210502-0730I20210501-1800I20210430-1800I20210429-1800I20210429-0600I20210428-1800I20210428-0330I20210428-0040I20210427-1800Lakshmi Shanmugam2-2/+2
Change-Id: Ifa67cc7b3158bef53c7308bdd3fe19b926dd4ad6 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179751 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Thomas Watson <tjwatson@us.ibm.com>
2021-04-26Bug 573111 - Export certificate from TrustCertificateDialogI20210426-2110I20210426-1800Mickael Istria3-15/+67
Auditing certificate and security can usually be performed more efficiently with some dedicated external tools. This new feature offers the opportunity to export the certificate to audit at installation, so process it with other tools if necessary. Change-Id: Ic5fd60a29d51055c9496dcc8459fe84491b15d81 Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179809 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-26Bug 573159 - Tycho 2.4 makes p2'sMickael Istria3-7/+18
org.eclipse.equinox.frameworkadmin.test fail Change-Id: If871959490b365340220cdcde170469789a89a6e Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179816 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-21Bug 342198 - Refactor IconExe for usage without main and extended errorI20210425-1800I20210424-1800I20210423-1800I20210423-0350I20210423-0140I20210422-1800I20210421-1800laeubi1-136/+97
reporting Change-Id: I267fc0f6ae83daa9ba472b646518a6bd03be6e5b Signed-off-by: laeubi <laeubi@laeubi-soft.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/151888 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-18Fix API tools reporting version issueI20210420-1800I20210420-0500I20210420-0240I20210418-1800Mickael Istria1-0/+11
Change-Id: I2c098b825a82fd3172b15c2ff172f19c4863f5d8 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179470 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-04-18Revert "Revert "Bug 570907 - A processingStep to verify PGP signaturesMickael Istria45-4/+1392
in artifact"" This reverts commit 6b5269b19fefdfc34c819212c5fe6c0f838e349f. This adds the necessary bouncycastle bundles to the p2 feature Change-Id: I4b5f8f761e4e683d35fef2ea0ce00bc3d3b34fa2 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179465 Tested-by: Mickael Istria <mistria@redhat.com> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-04-18Revert "Bug 570907 - A processingStep to verify PGP signatures in artifact"I20210417-2330Sravan Kumar Lakkimsetti44-1378/+4
This reverts commit d92c82f87cef36cc6840b14b6d8e85be55f9f335. Reason for revert: Build failure in I20210417-1800 Change-Id: Ieeb68052b0d9aa73f564d8eeb7f97f33bda6b6e8 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179035 Tested-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-04-16Bug 570907 - A processingStep to verify PGP signatures in artifactI20210416-1800Mickael Istria44-4/+1378
metadata Change-Id: I2300bce7861e59f5851c81a5b0204da9bfa111d0 Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/175851 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-15Bug 572789 - Comparator errors in I20210412-1800 after moving toI20210416-0810I20210415-1800Mickael Istria4-2/+4
compiler from 4.20 M1 Change-Id: Ia59f1466335318b6322f7a930d9beb22bdcb7f49 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179343 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-04-14Version bump for 4.20I20210415-0010I20210414-1800Alexander Kurtakov2-2/+2
I build pointed o.e.equinox.p2.tests.ui to have changed qualifier only. Change-Id: I73808e209f1510cbfdde020c8180c54a52c4bbe7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-05Bug 572010 - Remove Chromium support from eclipseS4_20_0_M1I20210414-0330I20210413-2350I20210413-1800I20210413-1400I20210412-2130I20210412-1800I20210411-1800I20210410-1800I20210410-0630I20210409-2140I20210409-1800I20210407-1800I20210407-0600I20210407-0040I20210406-1800I20210406-0600I20210405-1800I20210405-0840Alexander Kurtakov4-11/+6
Cleanup p2 products from references to chromium fragments.. Change-Id: I482c8eaf70a67cbb530a068d22da9b77acacb628 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-03Bug: Return value of String.replace(CharSequence, CharSequence) ignoredI20210405-0630I20210405-0600I20210404-1800I20210404-0600I20210403-1800Carsten Hammer3-3/+3
in org.eclipse.equinox.internal.p2.ui.discovery.wizards.CatalogViewer.createPattern(String) The return value of this method should be checked. One common cause of this warning is to invoke a method on an immutable object, thinking that it updates the object. For example, in the following code fragment, String dateString = getHeaderField(name); dateString.trim(); the programmer seems to be thinking that the trim() method will update the String referenced by dateString. But since Strings are immutable, the trim() function returns a new String value, which is being ignored here. The code should be corrected to: String dateString = getHeaderField(name); dateString = dateString.trim(); Rank: Scariest (3), confidence: High Pattern: RV_RETURN_VALUE_IGNORED Type: RV, Category: CORRECTNESS (Correctness) Change-Id: I742c36e979c97ce67bbe1ef69abd8d19cfa04ec8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-31Fix p2ql usage of reflection in Java 16I20210403-0600I20210402-1800I20210402-0510I20210331-1800Mickael Istria1-41/+56
p2ql does use reflection for some queries. Java 16 added restrictions on accessibility, such as non-public method from Java API modules can strictly not be invoked any more. So instead of blindly calling the first method match, we crawl the type hierarchy for a method that match and is accessible (possibly from a super type or interface). One example is LinkedHashMap$Entry#getValue() now becoming not accessible at all in Java 16; we then navigate type hierarchy to resolve to Map$Entry#getValue(), which is accessible API. Change-Id: Idd58a4e7a64faf7955b81aaa1c2ce342a2297c8d Signed-off-by: Mickael Istria <mistria@redhat.com>
2021-03-30Bug 572410 - Remove activator from org.eclipse.equinox.p2.ui.impLars Vogel5-59/+45
Uses new API from Bug 549929 to access the dialog settings. This way we can remove the activator. Change-Id: I3fe5aabedd94463f8e547c8256639ae180da1146 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-304.20 update of org.eclipse.equinox.p2.ui.importexportI20210330-1800Lars Vogel2-2/+2
Change-Id: Id81a645ac0ef87f940467374a3d804b189f70e01 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-29P2 should honor retry property on time outs for repository metadataI20210329-1800Laurent Goubet5-9/+37
Bug: 520461 Signed-off-by: Laurent Goubet <laurent.goubet@obeo.fr> Change-Id: Iaa96aea34026c6cd1c539f651ff3d6aef7ca168a
2021-03-28Bug: Possible null pointer dereference of profileDirectories inI20210329-0200I20210328-1800Carsten Hammer1-0/+1
org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry.restore() There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception can't ever be executed; deciding that is beyond the ability of SpotBugs. Rank: Scary (8), confidence: Normal Pattern: NP_NULL_ON_SOME_PATH Type: NP, Category: CORRECTNESS (Correctness) see https://bugs.eclipse.org/bugs/show_bug.cgi?id=336435 Change-Id: Ib73e1a65f6428beea9b3f6aa6b88b4903f86a9ec Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-27Bug: ↵I20210327-1800Carsten Hammer3-2/+7
org.eclipse.equinox.internal.p2.ui.sdk.scheduler.PreviousConfigurationFinder$Identifier defines equals and uses Object.hashCode() This class overrides equals(Object), but does notoverride hashCode(), and inherits the implementation of hashCode() from java.lang.Object (which returnsthe identity hash code, an arbitrary value assigned to the objectby the VM). Therefore, the class is very likely to violate theinvariant that equal objects must have equal hashcodes. If you don't think instances of this class will ever be inserted into a HashMap/HashTable, the recommended hashCode implementation to use is: public int hashCode() { assert false : "hashCode not designed"; return 42; // any arbitrary constant will do } Rank: Troubling (14), confidence: High Pattern: HE_EQUALS_USE_HASHCODE Type: HE, Category: BAD_PRACTICE (Bad practice) Change-Id: Ie4e1a6dc1d71882a48721cf3f79ba16be4c947f4 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-26Bug 572289 - Fix CopyActionTestI20210326-1800Mickael Istria2-19/+33
Change-Id: I253d5363605c385ddc372abf68dba8d018cea49e Signed-off-by: Mickael Istria <mistria@redhat.com>
2021-03-26Bug: 32 bit int shifted by 32 bits inCarsten Hammer1-8/+8
org.eclipse.pde.internal.swt.tools.IconExe.read8(RandomAccessFile) The code performs shift of a 32 bit int by a constant amount outside the range -31..31. The effect of this is to use the lower 5 bits of the integer value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits, and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected, and it is at least confusing. Rank: Scariest (1), confidence: High Pattern: ICAST_BAD_SHIFT_AMOUNT Type: BSHIFT, Category: CORRECTNESS (Correctness) Change-Id: I8a50ebdc0171938901bd125e0733422d1c6593a6 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-26Use "Exit loop earlier" JDT cleanup on SimpleArtifactRepositoryLars Vogel1-1/+3
Change-Id: Id12f2d88683d130bf1135b5bc7ace1ecf8f2c08a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-25Bug 572043 - Deprecate pack200 support for removalI20210325-1800Alexander Kurtakov3-7/+5
Hopefully last warnings patch. Change-Id: Ibbbb2f086826d0c19423bfd0de1569edeb0270a8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-25Use JDT clean up "Convert field into local variable if field is usedLars Vogel2-9/+7
only local" No need to save the value as field if it is only used locally. Change-Id: Iedcab54309243a4dcd944c6b6302450b094bfd3c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-24Adding space to messagesI20210324-1800I20210324-0950Karsten Thoms1-3/+3
Change-Id: I75c2a024de51c824dc34d1018cae2f374e425ada Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>

Back to the top