Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-04-27Bug 572799 - Replace arm64 with aarch64I20210505-0510I20210505-0100I20210504-1800I20210503-1800I20210502-1800I20210502-0730I20210501-1800I20210430-1800I20210429-1800I20210429-0600I20210428-1800I20210428-0330I20210428-0040I20210427-1800Lakshmi Shanmugam2-2/+2
Change-Id: Ifa67cc7b3158bef53c7308bdd3fe19b926dd4ad6 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179751 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Thomas Watson <tjwatson@us.ibm.com>
2021-04-26Bug 573111 - Export certificate from TrustCertificateDialogI20210426-2110I20210426-1800Mickael Istria3-15/+67
Auditing certificate and security can usually be performed more efficiently with some dedicated external tools. This new feature offers the opportunity to export the certificate to audit at installation, so process it with other tools if necessary. Change-Id: Ic5fd60a29d51055c9496dcc8459fe84491b15d81 Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179809 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-26Bug 573159 - Tycho 2.4 makes p2'sMickael Istria3-7/+18
org.eclipse.equinox.frameworkadmin.test fail Change-Id: If871959490b365340220cdcde170469789a89a6e Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179816 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-21Bug 342198 - Refactor IconExe for usage without main and extended errorI20210425-1800I20210424-1800I20210423-1800I20210423-0350I20210423-0140I20210422-1800I20210421-1800laeubi1-136/+97
reporting Change-Id: I267fc0f6ae83daa9ba472b646518a6bd03be6e5b Signed-off-by: laeubi <laeubi@laeubi-soft.de> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/151888 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-18Fix API tools reporting version issueI20210420-1800I20210420-0500I20210420-0240I20210418-1800Mickael Istria1-0/+11
Change-Id: I2c098b825a82fd3172b15c2ff172f19c4863f5d8 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179470 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-04-18Revert "Revert "Bug 570907 - A processingStep to verify PGP signaturesMickael Istria45-4/+1392
in artifact"" This reverts commit 6b5269b19fefdfc34c819212c5fe6c0f838e349f. This adds the necessary bouncycastle bundles to the p2 feature Change-Id: I4b5f8f761e4e683d35fef2ea0ce00bc3d3b34fa2 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179465 Tested-by: Mickael Istria <mistria@redhat.com> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-04-18Revert "Bug 570907 - A processingStep to verify PGP signatures in artifact"I20210417-2330Sravan Kumar Lakkimsetti44-1378/+4
This reverts commit d92c82f87cef36cc6840b14b6d8e85be55f9f335. Reason for revert: Build failure in I20210417-1800 Change-Id: Ieeb68052b0d9aa73f564d8eeb7f97f33bda6b6e8 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179035 Tested-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-04-16Bug 570907 - A processingStep to verify PGP signatures in artifactI20210416-1800Mickael Istria44-4/+1378
metadata Change-Id: I2300bce7861e59f5851c81a5b0204da9bfa111d0 Signed-off-by: Mickael Istria <mistria@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/175851 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
2021-04-15Bug 572789 - Comparator errors in I20210412-1800 after moving toI20210416-0810I20210415-1800Mickael Istria4-2/+4
compiler from 4.20 M1 Change-Id: Ia59f1466335318b6322f7a930d9beb22bdcb7f49 Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/179343 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-04-14Version bump for 4.20I20210415-0010I20210414-1800Alexander Kurtakov2-2/+2
I build pointed o.e.equinox.p2.tests.ui to have changed qualifier only. Change-Id: I73808e209f1510cbfdde020c8180c54a52c4bbe7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-05Bug 572010 - Remove Chromium support from eclipseS4_20_0_M1I20210414-0330I20210413-2350I20210413-1800I20210413-1400I20210412-2130I20210412-1800I20210411-1800I20210410-1800I20210410-0630I20210409-2140I20210409-1800I20210407-1800I20210407-0600I20210407-0040I20210406-1800I20210406-0600I20210405-1800I20210405-0840Alexander Kurtakov4-11/+6
Cleanup p2 products from references to chromium fragments.. Change-Id: I482c8eaf70a67cbb530a068d22da9b77acacb628 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-04-03Bug: Return value of String.replace(CharSequence, CharSequence) ignoredI20210405-0630I20210405-0600I20210404-1800I20210404-0600I20210403-1800Carsten Hammer3-3/+3
in org.eclipse.equinox.internal.p2.ui.discovery.wizards.CatalogViewer.createPattern(String) The return value of this method should be checked. One common cause of this warning is to invoke a method on an immutable object, thinking that it updates the object. For example, in the following code fragment, String dateString = getHeaderField(name); dateString.trim(); the programmer seems to be thinking that the trim() method will update the String referenced by dateString. But since Strings are immutable, the trim() function returns a new String value, which is being ignored here. The code should be corrected to: String dateString = getHeaderField(name); dateString = dateString.trim(); Rank: Scariest (3), confidence: High Pattern: RV_RETURN_VALUE_IGNORED Type: RV, Category: CORRECTNESS (Correctness) Change-Id: I742c36e979c97ce67bbe1ef69abd8d19cfa04ec8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-31Fix p2ql usage of reflection in Java 16I20210403-0600I20210402-1800I20210402-0510I20210331-1800Mickael Istria1-41/+56
p2ql does use reflection for some queries. Java 16 added restrictions on accessibility, such as non-public method from Java API modules can strictly not be invoked any more. So instead of blindly calling the first method match, we crawl the type hierarchy for a method that match and is accessible (possibly from a super type or interface). One example is LinkedHashMap$Entry#getValue() now becoming not accessible at all in Java 16; we then navigate type hierarchy to resolve to Map$Entry#getValue(), which is accessible API. Change-Id: Idd58a4e7a64faf7955b81aaa1c2ce342a2297c8d Signed-off-by: Mickael Istria <mistria@redhat.com>
2021-03-30Bug 572410 - Remove activator from org.eclipse.equinox.p2.ui.impLars Vogel5-59/+45
Uses new API from Bug 549929 to access the dialog settings. This way we can remove the activator. Change-Id: I3fe5aabedd94463f8e547c8256639ae180da1146 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-304.20 update of org.eclipse.equinox.p2.ui.importexportI20210330-1800Lars Vogel2-2/+2
Change-Id: Id81a645ac0ef87f940467374a3d804b189f70e01 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-29P2 should honor retry property on time outs for repository metadataI20210329-1800Laurent Goubet5-9/+37
Bug: 520461 Signed-off-by: Laurent Goubet <laurent.goubet@obeo.fr> Change-Id: Iaa96aea34026c6cd1c539f651ff3d6aef7ca168a
2021-03-28Bug: Possible null pointer dereference of profileDirectories inI20210329-0200I20210328-1800Carsten Hammer1-0/+1
org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry.restore() There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception can't ever be executed; deciding that is beyond the ability of SpotBugs. Rank: Scary (8), confidence: Normal Pattern: NP_NULL_ON_SOME_PATH Type: NP, Category: CORRECTNESS (Correctness) see https://bugs.eclipse.org/bugs/show_bug.cgi?id=336435 Change-Id: Ib73e1a65f6428beea9b3f6aa6b88b4903f86a9ec Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-27Bug: ↵I20210327-1800Carsten Hammer3-2/+7
org.eclipse.equinox.internal.p2.ui.sdk.scheduler.PreviousConfigurationFinder$Identifier defines equals and uses Object.hashCode() This class overrides equals(Object), but does notoverride hashCode(), and inherits the implementation of hashCode() from java.lang.Object (which returnsthe identity hash code, an arbitrary value assigned to the objectby the VM). Therefore, the class is very likely to violate theinvariant that equal objects must have equal hashcodes. If you don't think instances of this class will ever be inserted into a HashMap/HashTable, the recommended hashCode implementation to use is: public int hashCode() { assert false : "hashCode not designed"; return 42; // any arbitrary constant will do } Rank: Troubling (14), confidence: High Pattern: HE_EQUALS_USE_HASHCODE Type: HE, Category: BAD_PRACTICE (Bad practice) Change-Id: Ie4e1a6dc1d71882a48721cf3f79ba16be4c947f4 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-26Bug 572289 - Fix CopyActionTestI20210326-1800Mickael Istria2-19/+33
Change-Id: I253d5363605c385ddc372abf68dba8d018cea49e Signed-off-by: Mickael Istria <mistria@redhat.com>
2021-03-26Bug: 32 bit int shifted by 32 bits inCarsten Hammer1-8/+8
org.eclipse.pde.internal.swt.tools.IconExe.read8(RandomAccessFile) The code performs shift of a 32 bit int by a constant amount outside the range -31..31. The effect of this is to use the lower 5 bits of the integer value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits, and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected, and it is at least confusing. Rank: Scariest (1), confidence: High Pattern: ICAST_BAD_SHIFT_AMOUNT Type: BSHIFT, Category: CORRECTNESS (Correctness) Change-Id: I8a50ebdc0171938901bd125e0733422d1c6593a6 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-03-26Use "Exit loop earlier" JDT cleanup on SimpleArtifactRepositoryLars Vogel1-1/+3
Change-Id: Id12f2d88683d130bf1135b5bc7ace1ecf8f2c08a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-25Bug 572043 - Deprecate pack200 support for removalI20210325-1800Alexander Kurtakov3-7/+5
Hopefully last warnings patch. Change-Id: Ibbbb2f086826d0c19423bfd0de1569edeb0270a8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-25Use JDT clean up "Convert field into local variable if field is usedLars Vogel2-9/+7
only local" No need to save the value as field if it is only used locally. Change-Id: Iedcab54309243a4dcd944c6b6302450b094bfd3c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-24Adding space to messagesI20210324-1800I20210324-0950Karsten Thoms1-3/+3
Change-Id: I75c2a024de51c824dc34d1018cae2f374e425ada Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>
2021-03-23Bug 572043 - Deprecate pack200 support for removalAlexander Kurtakov7-0/+7
Further silencing of removal warnings in our codebase. Change-Id: Ibdbac953d9ebe291d87992e4f5560587437faeb9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-22Bug 572043 - Deprecate pack200 support for removalI20210324-0320I20210323-2250I20210323-1800I20210323-1240I20210323-0200I20210322-1800Alexander Kurtakov3-10/+20
Deprecate pack200 in ant tasks and show warnings in the ant log. Change-Id: I5a7ce482f3be8a1f66c6d1e4989671136ff24149 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-22Bug 572043 - Deprecate pack200 support for removalAlexander Kurtakov22-411/+535
Silence removal warnings in the main build. Deprecated few extra methods as spotted in the process. Change-Id: Iaa40ac2a1a088dec9ef12799cf53aa22f750cb6c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-21Bug 332714: Brand console application on WindowsTorbjörn Svensson3-23/+41
The name of the console application must match the GUI application name or it will try to load the wrong ini file. Contributed by STMicroelectronics Change-Id: I53e231eb6b4958e9da5b09fab3ab8b2fc0baafbb Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-03-20Version bump for 4.20.I20210321-1800I20210321-0340I20210320-1800I20210320-0650Alexander Kurtakov2-2/+2
Change-Id: I0e87ce7cbf9ffd08287555d9fd9bda4953f5fee0 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-19Bug 572043 - Deprecate pack200 support for removalI20210319-1800Alexander Kurtakov19-305/+655
Mark for removal and annotate with pde.apitools so projects start seeing the future breakage and act on it. Change-Id: I947650999c584bb70356859a94e8124eb5441775 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-18Break loop early in AbsolutePlanTestI20210319-0030I20210318-2320I20210318-2100Lars Vogel1-0/+1
Done with JDT Cleanup exit loop early Change-Id: I8290dcbc44fa255fd13c23df0dd4cf1207eeb0f2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-03-18Bug 571923 - Move p2 to Java 11 BREEEd Merks1-1/+0
Remove the src entry from the .classpath that was introduced by the previous comment. Change-Id: I7cf2a2b7f38032501ce4307d49748a77ad693c23 Signed-off-by: Ed Merks <ed.merks@gmail.com>
2021-03-16Bug 571923 - Move p2 to Java 11 BREEI20210317-1850I20210317-1320I20210317-0910I20210317-0650I20210317-0330I20210316-1800Alexander Kurtakov28-66/+118
Last changes. Change-Id: Ic002dc3c897d47c9f0ebe380e88bfc72fc5a2c7a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-16Use reflection varargs in p2.metadata Member classAlexander Kurtakov1-17/+23
Remove two useless members. Change-Id: Idebc24d217cee43d11f885845db9490011b487c1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-15Bug 571923 - Move p2 to Java 11 BREEAlexander Kurtakov55-148/+182
Move rest of the bundles. Change-Id: Iacd8711504700dde94259112e380a3131ae730c9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-15Bug 571923 - Move p2 to Java 11 BREEI20210315-2050Alexander Kurtakov38-106/+139
Convert more bundles. Change-Id: I976ed48dbdcf6584ad0790853443299d56ec5e69 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-12Bug 571923 - Move p2 to Java 11 BREEAlexander Kurtakov27-98/+167
To allow full MethodHandle functionality as a preparation for Java 16 streghtening encapsulation https://openjdk.java.net/jeps/396 . o.e.equinox.p2.metadata and dependent bundles handled here. Change-Id: I45ac594c47b2c7b302f673ea92052a4ae15b5cb5 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-12Bug 570540 - Build eclipse for Mac M1 processor architectureI20210314-1800I20210313-1800I20210312-2010I20210312-1800I20210312-1540I20210312-1410I20210312-1150I20210312-0940I20210312-0840Sravan Kumar Lakkimsetti6-6/+8
Change-Id: I9ed3bd4729cca40ad3c7cc264b2abc31c3667fcf Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-03-08Bug 571697 - Version bumps for 4.20 streamI20210311-1800I20210310-2050I20210310-0620I20210310-0250I20210309-1800I20210309-0500Alexander Kurtakov12-12/+12
Change-Id: Iefa8bba675edaa85255b72a50974f72a45c9f88e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-05Bug 571731 - Comparator errors in I20210305-0820I20210308-1800I20210308-1030I20210308-0720Alexander Kurtakov1-1/+2
Touch bundle as jdt.core lambda order generation is not stable. Change-Id: I280626a414b8c4666f9072ad8d3d3f98d4c21f30 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-03-05Bug 571689 - POM and product version change for 4.20 releaseI20210305-0820Alexander Kurtakov64-64/+64
Change-Id: I3adc2961dfcfb7cc647efdc9655303ab12f5836f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-02-27Bug 571555 - Comparator errors in I20210226-1800Y20210316-1310Y20210316-0510Y20210315-1000Y20210314-1000Y20210313-1000Y20210312-2250Y20210312-1250Y20210312-1000Y20210311-1000Y20210310-1000Y20210309-1000Y20210307-1000Y20210306-1000Y20210305-1000Y20210304-1000Y20210303-1000Y20210301-1000Y20210228-1000Y20210227-1000S4_19_0_RC2R4_19I20210303-1800I20210303-0600I20210302-1800I20210302-0930I20210302-0720I20210302-0600I20210301-1800I20210301-0600I20210228-1800I20210228-0600I20210227-1800I20210227-0600I20210226-2140R4_19_maintenanceSravan Kumar Lakkimsetti1-1/+2
Change-Id: Ie36b180feb2db3d2890d4cd0a9b96d1f49f64fe0 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-02-17Bug 571246 - Icons used in p2 import/export wizard have wrong sizeY20210226-1000Y20210225-1000Y20210224-1000Y20210223-1050Y20210222-1000Y20210221-1000Y20210220-1000Y20210219-1000Y20210218-1000Y20210217-1000S4_19_0_RC1S4_19_0_M3I20210226-1800I20210226-0220I20210224-1800I20210224-0840I20210224-0600I20210223-1800I20210223-0650I20210223-0600I20210222-1800I20210222-0600I20210221-1800I20210221-0600I20210220-1800I20210220-0600I20210219-1800I20210219-0300I20210217-1800Andrey Loskutov3-3/+3
New icons are coming from org.eclipse.pde.ui/icons/obj16/install-handler.png & Co Change-Id: Ie6abe83e27039ccd91479efb8ade991b459c4c0c Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2021-02-12Bug 571156 - Javadoc build failure in I20210211-1810Y20210216-1000Y20210215-1020Y20210214-1000Y20210213-1200Y20210212-1200I20210217-0600I20210216-2020I20210216-1800I20210216-1340I20210216-1140I20210216-1030I20210216-0600I20210215-1800I20210215-0700I20210215-0600I20210214-1800I20210214-0600I20210213-1800I20210213-0600I20210212-1840Sravan Kumar Lakkimsetti2-2/+2
Change-Id: I58f95223e8f0906b136bb1df7ceb7950c0a7e400 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-02-11Bug: Repeated conditional test inY20210211-1200I20210211-1810Carsten Hammer1-1/+1
org.eclipse.equinox.spi.p2.publisher.PublisherHelper.fromOSGiVersion(Version) The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). Rank: Scary (6), confidence: High Pattern: RpC_REPEATED_CONDITIONAL_TEST Type: RpC, Category: CORRECTNESS (Correctness) Change-Id: I9d5f1d8c05859048fc66c131d6672e1ab962a7a2 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2021-02-09Bug 571007 - Move copyright tool to buildtools repositoryY20210211-0600Y20210210-1200Y20210210-0100Y20210209-1200I20210210-1800I20210210-0910I20210209-1800Alexander Kurtakov1-2/+0
No need for it in P2 UI tests launcher. Change-Id: I102ac59dec49fc8b1bf83b65e49b6ba284ef8352 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-02-05Bug 570960 - Generate IU for launcher with machine architecture on MacY20210205-1200I20210208-1800I20210207-1800I20210206-1800I20210206-0720I20210206-0050I20210205-1800Sravan Kumar Lakkimsetti3-9/+3
Change-Id: Iba89254a445fa4cbabbbd8f0682d482c5b3ef9ac Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-01-30Remove useless private abstract class in LocalizationHelperY20210202-1200I20210204-2320I20210204-1800I20210204-1430I20210204-1300I20210204-1100I20210204-0900I20210204-0300I20210203-1800I20210202-1840I20210201-1800I20210131-1800I20210130-1800Alexander Kurtakov1-26/+16
It simply adds nothing to FilenameFilter that way, prevents being lambda and etc. Change-Id: Ibd16733cedc9f75ae272292afc73da443fb641c3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-30Bug 570770 - Migrate p2 usage of legacy resolver to OSGi wiring APIAlexander Kurtakov2-4/+2
Remove x-friend org.eclipse.pde.publishing as it's from experiment that never succeeded in bug 331974 . Change-Id: I5263d4ea78b26efde88b6e6f5f830a990d380998 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2021-01-29Bug 570766 - Allow mapper in artifacts.xml to use all artifact propertieI20210129-1800Mickael Istria4-28/+35
Change-Id: I03ae5eb64791ff2e2a9be47de82fa7c58448adbc Signed-off-by: Mickael Istria <mistria@redhat.com>

Back to the top