Skip to main content
diff options
authorIan Bull2012-05-15 16:50:43 +0000
committerIan Bull2012-05-15 16:50:43 +0000
commitcb3694589d14417cbbce60197f5b787dae4d04f5 (patch)
tree8632674204be2b75e82745438608849cd731bf79 /bundles/org.eclipse.equinox.p2.ui.sdk
parent94ce7f80072142e392b024a108525f7310c904a8 (diff)
When a repository fails to load, we continue the update check. All the repositories that fail to load are 'accumulated' and shown to the user, but the update check proceeds with the available repositories. This commit changes the visibility of a method in an API class from private to protected. However, this class is marked as 'noextend' so really shouldn't be considered new API.
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.ui.sdk')
1 files changed, 7 insertions, 0 deletions
diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk/src/org/eclipse/equinox/internal/p2/ui/sdk/ b/bundles/org.eclipse.equinox.p2.ui.sdk/src/org/eclipse/equinox/internal/p2/ui/sdk/
index e1f89a97a..e8a3822b0 100644
--- a/bundles/org.eclipse.equinox.p2.ui.sdk/src/org/eclipse/equinox/internal/p2/ui/sdk/
+++ b/bundles/org.eclipse.equinox.p2.ui.sdk/src/org/eclipse/equinox/internal/p2/ui/sdk/
@@ -77,6 +77,7 @@ abstract class PreloadingRepositoryHandler extends AbstractHandler {
//cancel any load that is already running
final LoadMetadataRepositoryJob loadJob = new LoadMetadataRepositoryJob(getProvisioningUI()) {
public IStatus runModal(IProgressMonitor monitor) {
SubMonitor sub = SubMonitor.convert(monitor, getProgressTaskName(), 1000);
IStatus status = super.runModal(sub.newChild(500));
@@ -87,6 +88,12 @@ abstract class PreloadingRepositoryHandler extends AbstractHandler {
} catch (OperationCanceledException e) {
return Status.CANCEL_STATUS;
+ if (shouldAccumulateFailures()) {
+ // If we are accumulating failures, don't return a combined status here. By returning OK,
+ // we are indicating that the operation should continue with the repositories that
+ // did load.
+ return Status.OK_STATUS;
+ }
return status;

Back to the top