Bug 489706 - Replace new Integer() with Integer.valueOf()I20160419-0800

There are a lot of new Integer() calls in the P2 codebase, which results
in many duplicate values of Integer being stored, particularly when
performing updates or checks. Integer.valueOf() performs this caching
already, which means that it's unnecessary to call new Integer() and
instead can call Integer.valueOf(). In the places where the int value is
being used directly, the call can be further optimised to
Integer.parseInt() instead.

Replace calls to new Integer() with Integer.valueOf() or .parseInt()
as appropriate.

Change-Id: Ic760e66084c856fc90cb7c8a358007c975213638
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/bundles/org.eclipse.equinox.p2.testserver/src/org/eclipse/equinox/p2/testserver/servlets/Stats.java b/bundles/org.eclipse.equinox.p2.testserver/src/org/eclipse/equinox/p2/testserver/servlets/Stats.java
index 5d8f47316..a9123506a 100644
--- a/bundles/org.eclipse.equinox.p2.testserver/src/org/eclipse/equinox/p2/testserver/servlets/Stats.java
+++ b/bundles/org.eclipse.equinox.p2.testserver/src/org/eclipse/equinox/p2/testserver/servlets/Stats.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2012 Wind River and others.
+ * Copyright (c) 2012, 2016 Wind River and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -39,7 +39,7 @@ public class Stats extends HttpServlet {
 	private Map downloadStats = new HashMap();
 
 	public Stats() {
-		downloadStats.put(UnkownPackage, new Integer(0));
+		downloadStats.put(UnkownPackage, Integer.valueOf(0));
 	}
 
 	protected void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
@@ -97,9 +97,9 @@ public class Stats extends HttpServlet {
 					found = true;
 					Integer count = (Integer) downloadStats.get(paraPair[1]);
 					if (count == null) {
-						count = new Integer(1);
+						count = Integer.valueOf(1);
 					} else
-						count = new Integer(1 + count.intValue());
+						count = Integer.valueOf(1 + count.intValue());
 					downloadStats.put(paraPair[1], count);
 					break;
 				}
@@ -107,7 +107,7 @@ public class Stats extends HttpServlet {
 		}
 		if (!found) {
 			Integer count = (Integer) downloadStats.get(UnkownPackage);
-			downloadStats.put(UnkownPackage, new Integer(1 + count.intValue()));
+			downloadStats.put(UnkownPackage, Integer.valueOf(1 + count.intValue()));
 		}
 	}
 }